ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

handle features with null bounds in OpenLayers.Renderer.Canvas.drawFeature. p=arublev,me r=erilem (closes #3442)

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@12205 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
Frédéric Junod
2011-08-03 15:47:06 +00:00
parent d1fe8f8df4
commit 0b8a98d9a6
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/OpenLayers/Renderer/Canvas.js
View File

@@ -140,8 +140,9 @@ OpenLayers.Renderer.Canvas = OpenLayers.Class(OpenLayers.Renderer, {
if (feature.geometry) {
style = this.applyDefaultSymbolizer(style || feature.style);
// don't render if display none or feature outside extent
rendered = (style.display !== "none") &&
feature.geometry.getBounds().intersectsBounds(this.extent);
var bounds = feature.geometry.getBounds();
rendered = (style.display !== "none") && !!bounds &&
bounds.intersectsBounds(this.extent);
if (rendered) {
// keep track of what we have rendered for redraw
this.features[feature.id] = [feature, style];

11
tests/Renderer/Canvas.html
View File

@@ -123,7 +123,7 @@
return;
}
t.plan(8);
t.plan(10);
var layer = new OpenLayers.Layer.Vector(null, {
isBaseLayer: true,
renderers: ["Canvas"]
@@ -183,6 +183,15 @@
t.eq(count, 1, "d) redraw is called when drawing a feature outside renderer extent");
renderer.clear();
// e) draw a polygon feature without bounds
count = 0;
exp = renderer.drawFeature(
new OpenLayers.Feature.Vector(new OpenLayers.Geometry.Polygon()), {}
);
t.eq(exp, false, "d) drawFeature returns false");
t.eq(count, 1, "d) redraw is called when drawing a feature without bounds");
renderer.clear();
map.destroy();
}