mirror of
https://github.com/maputnik/editor.git
synced 2026-07-08 23:17:26 +00:00
HarelM
ac9186e7f8
Make the driver page-lazy (it resolves the running test's page on demand via
an auto fixture) so it can be created a single time at describe scope and
reused across the block's tests, matching the pre-migration ergonomics:
const { given, get, when, then } = new MaputnikDriver();
instead of pulling `driver` out of a fixture and destructuring it in every
test. Coverage collection and dialog handling move into the auto fixture.
Also inject a bare invalid token ("zzz") in the json-editor parse-error test:
CodeMirror auto-closes brackets/quotes, so " {" no longer reliably breaks the
JSON.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
47 lines
1.6 KiB
TypeScript
47 lines
1.6 KiB
TypeScript
import { test as base, expect, type Page } from "@playwright/test";
|
|
import { readCoverage, writeCoverage } from "./coverage";
|
|
|
|
let activePage: Page | undefined;
|
|
const coverageChunks: unknown[] = [];
|
|
|
|
/** The page for the currently running test. Throws if used outside a test. */
|
|
export function currentPage(): Page {
|
|
if (!activePage) {
|
|
throw new Error("No active page: a MaputnikDriver method was called outside of a running test.");
|
|
}
|
|
return activePage;
|
|
}
|
|
|
|
/** Records a coverage snapshot (called before navigations, which reset __coverage__). */
|
|
export function recordCoverageChunk(chunk: unknown): void {
|
|
if (chunk) coverageChunks.push(chunk);
|
|
}
|
|
|
|
/**
|
|
* Auto fixture that binds the current test's page for the (page-lazy)
|
|
* MaputnikDriver, auto-accepts confirm dialogs, and writes the istanbul
|
|
* coverage collected during the test to `.nyc_output`.
|
|
*/
|
|
export const test = base.extend<{ maputnikPage: void }>({
|
|
maputnikPage: [
|
|
async ({ page }, use, testInfo) => {
|
|
activePage = page;
|
|
coverageChunks.length = 0;
|
|
// Accept confirm dialogs (e.g. the "replace current style" prompt). These
|
|
// are dismissed by default, which would cancel loading a style via URL.
|
|
page.on("dialog", (dialog) => dialog.accept().catch(() => undefined));
|
|
|
|
await use();
|
|
|
|
const finalCoverage = await readCoverage(page);
|
|
if (finalCoverage) coverageChunks.push(finalCoverage);
|
|
coverageChunks.forEach((chunk, index) => writeCoverage(chunk, `${testInfo.testId}-${index}`));
|
|
coverageChunks.length = 0;
|
|
activePage = undefined;
|
|
},
|
|
{ auto: true },
|
|
],
|
|
});
|
|
|
|
export { expect };
|