mirror of
https://github.com/maputnik/editor.git
synced 2026-07-14 09:57:29 +00:00
f14eeae38b
## Launch Checklist This PR increases coverage by adding unit tests to lib folde, replace the skipped end to end placeholder with actual tests and adds more end to end tests. This was mostly done by AI (Claude opus 4.8) and I reviewed it and requested changes where needed. - [x] Briefly describe the changes in this PR. - [x] Link to related issues. - [x] Include before/after visuals or gifs if this PR includes visual changes. - [x] Write tests for all new functionality. - [x] Add an entry to `CHANGELOG.md` under the `## main` section. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
166 lines
5.2 KiB
YAML
166 lines
5.2 KiB
YAML
name: ci
|
|
|
|
on:
|
|
pull_request:
|
|
branches: [ main ]
|
|
push:
|
|
branches: [ main ]
|
|
|
|
jobs:
|
|
|
|
build-node:
|
|
name: "build on ${{ matrix.os }}"
|
|
runs-on: ${{ matrix.os }}
|
|
permissions:
|
|
contents: read
|
|
if: ${{ github.event_name == 'push' || github.event_name == 'pull_request' }}
|
|
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
os: [ ubuntu-latest, windows-latest, macos-latest ]
|
|
|
|
steps:
|
|
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
|
|
with: { persist-credentials: false }
|
|
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
|
|
with:
|
|
node-version-file: '.nvmrc'
|
|
- run: npm ci
|
|
- run: npm run build
|
|
- run: npm run lint
|
|
- run: npm run lint-css
|
|
|
|
|
|
|
|
build-artifacts:
|
|
name: "build artifacts"
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
contents: read
|
|
if: ${{ github.event_name == 'push' || github.event_name == 'pull_request' }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
|
|
with: { persist-credentials: false }
|
|
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
|
|
with:
|
|
node-version-file: '.nvmrc'
|
|
- run: npm ci
|
|
- run: npm run build
|
|
- name: artifacts/maputnik
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
with:
|
|
name: maputnik
|
|
path: dist
|
|
|
|
# Build and upload desktop CLI artifacts
|
|
- name: Set up Go
|
|
uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6.5.0
|
|
with:
|
|
go-version: ^1.23.x
|
|
cache-dependency-path: desktop/go.sum
|
|
id: go
|
|
|
|
- name: Build desktop artifacts
|
|
run: npm run build-desktop
|
|
|
|
- name: Artifacts/linux
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
with:
|
|
name: maputnik-linux
|
|
path: ./desktop/bin/linux/
|
|
|
|
- name: Artifacts/darwin
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
with:
|
|
name: maputnik-darwin
|
|
path: ./desktop/bin/darwin/
|
|
|
|
- name: Artifacts/windows
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
with:
|
|
name: maputnik-windows
|
|
path: ./desktop/bin/windows/
|
|
|
|
unit-tests:
|
|
name: "Unit tests"
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
contents: read
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
|
|
with: { persist-credentials: false }
|
|
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
|
|
with:
|
|
node-version-file: '.nvmrc'
|
|
- run: npm ci
|
|
- run: npm run test-unit-ci
|
|
- name: Upload coverage reports to Codecov
|
|
uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
|
|
with:
|
|
files: ${{ github.workspace }}/coverage/coverage-final.json
|
|
verbose: true
|
|
|
|
e2e-tests:
|
|
name: "E2E tests using chrome"
|
|
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
contents: read
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
|
|
with: { persist-credentials: false }
|
|
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
|
|
with:
|
|
node-version-file: '.nvmrc'
|
|
- run: npm ci
|
|
- run: npx playwright install --with-deps chromium
|
|
- name: Playwright run
|
|
run: npm run test-e2e
|
|
- name: Upload coverage reports to Codecov
|
|
uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
|
|
with:
|
|
files: ${{ github.workspace }}/coverage/coverage-final.json
|
|
verbose: true
|
|
- name: Upload Playwright report
|
|
if: ${{ !cancelled() }}
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
with:
|
|
name: playwright-report
|
|
path: playwright-report/
|
|
retention-days: 7
|
|
|
|
e2e-tests-docker:
|
|
name: "E2E tests using chrome and docker"
|
|
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
|
|
with: { persist-credentials: false }
|
|
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
|
|
with:
|
|
node-version-file: '.nvmrc'
|
|
- run: npm ci
|
|
- run: npx playwright install --with-deps chromium
|
|
- name: Build docker image
|
|
run: docker build -t maputnik .
|
|
- name: Start maputnik container
|
|
run: docker run -d --network host --name maputnik maputnik --port=8888
|
|
- name: Wait for maputnik to be ready
|
|
run: |
|
|
for i in $(seq 1 60); do
|
|
if curl -sSf http://localhost:8888/ > /dev/null; then
|
|
echo "maputnik is up"; exit 0
|
|
fi
|
|
sleep 1
|
|
done
|
|
echo "maputnik did not start in time"; docker logs maputnik; exit 1
|
|
- name: Playwright run
|
|
run: npm run test-e2e
|
|
env:
|
|
E2E_NO_WEBSERVER: "1"
|