ashatora/editor
1
0
Fork 0
mirror of https://github.com/maputnik/editor.git synced 2026-02-06 04:30:01 +00:00
Code Issues Projects Releases Wiki Activity

remove left overs

Browse Source
This commit is contained in:
shelly_goldblit
2023-12-31 20:47:10 +02:00
parent 2213e74e2a
commit fa2dfa7480
4 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cypress/e2e/cypress-wrapper-driver.ts
View File

@@ -1,6 +1,6 @@
import { CypressHelper } from "@shellygo/cypress-test-utils";
export default class CypressWrapperDriver {
export default class MaputnikCypressHelper {
private helper = new CypressHelper({ defaultDataAttribute: "data-wd-key" });
public given = {
@@ -13,9 +13,6 @@ export default class CypressWrapperDriver {
public when = {
...this.helper.when,
confirmAlert() {
cy.on("window:confirm", () => true);
},
};
public beforeAndAfter = this.helper.beforeAndAfter;

2
cypress/e2e/layers.cy.ts
View File

@@ -2,7 +2,7 @@ import { v1 as uuid } from "uuid";
import { MaputnikDriver } from "./maputnik-driver";
describe("layers", () => {
let { beforeAndAfter, get, when, should, then } = new MaputnikDriver();
let { beforeAndAfter, get, when, then } = new MaputnikDriver();
beforeAndAfter();
beforeEach(() => {
when.setStyle("both");

6
cypress/e2e/maputnik-driver.ts
View File

@@ -1,6 +1,6 @@
import { CypressHelper } from "@shellygo/cypress-test-utils";
import { Assertable, then } from "@shellygo/cypress-test-utils/assertable";
import CypressWrapperDriver from "./cypress-wrapper-driver";
import MaputnikCypressHelper from "./cypress-wrapper-driver";
import ModalDriver from "./modal-driver";
const baseUrl = "http://localhost:8888/";
@@ -22,7 +22,7 @@ export class MaputnikAssertable<T> extends Assertable<T> {
}
export class MaputnikDriver {
private helper = new CypressWrapperDriver();
private helper = new MaputnikCypressHelper();
private modalDriver = new ModalDriver();
public beforeAndAfter = () => {
@@ -126,7 +126,7 @@ export class MaputnikDriver {
}
this.helper.when.visit(baseUrl + url);
if (styleProperties) {
this.helper.when.confirmAlert();
this.helper.when.acceptConfirm();
}
// when methods should not include assertions
this.helper.get.elementByTestId("toolbar:link").should("be.visible");

6
cypress/e2e/modal-driver.ts
View File

@@ -1,11 +1,13 @@
import { v1 as uuid } from "uuid";
import CypressWrapperDriver from "./cypress-wrapper-driver";
import MaputnikCypressHelper from "./cypress-wrapper-driver";
export default class ModalDriver {
private helper = new CypressWrapperDriver();
private helper = new MaputnikCypressHelper();
public when = {
fillLayers: (opts: { type: string; layer?: string; id?: string }) => {
// Having logic in test code is an anti pattern.
// This should be splitted to multiple single responsibility functions
let type = opts.type;
let layer = opts.layer;
let id;