ashatora/editor
1
0
Fork 0
mirror of https://github.com/maputnik/editor.git synced 2026-06-18 05:07:25 +00:00
Code Issues Projects Releases Wiki Activity

review comments

Browse Source
This commit is contained in:
shelly_goldblit
2024-01-01 15:53:15 +02:00
parent 13336bf2af
commit 1d938b5a8b
4 changed files with 16 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cypress/e2e/cypress-wrapper-driver.ts → cypress/e2e/maputnik-cypress-helper.ts
View File
cypress/e2e/maputnik-driver.ts
+13 -20
View File
@@ -1,6 +1,6 @@
import { CypressHelper } from "@shellygo/cypress-test-utils"; import { CypressHelper } from "@shellygo/cypress-test-utils";
import { Assertable, then } from "@shellygo/cypress-test-utils/assertable"; import { Assertable, then } from "@shellygo/cypress-test-utils/assertable";
import MaputnikCypressHelper from "./cypress-wrapper-driver"; import MaputnikCypressHelper from "./maputnik-cypress-helper";
import ModalDriver from "./modal-driver"; import ModalDriver from "./modal-driver";
const baseUrl = "http://localhost:8888/"; const baseUrl = "http://localhost:8888/";
@@ -108,18 +108,18 @@ export class MaputnikDriver {
) => { ) => {
let url = "?debug"; let url = "?debug";
switch (styleProperties) { switch (styleProperties) {
case "geojson": case "geojson":
url += `&style=${baseUrl}geojson-style.json`; url += `&style=${baseUrl}geojson-style.json`;
break; break;
case "raster": case "raster":
url += `&style=${baseUrl}raster-style.json`; url += `&style=${baseUrl}raster-style.json`;
break; break;
case "both": case "both":
url += `&style=${baseUrl}geojson-raster-style.json`; url += `&style=${baseUrl}geojson-raster-style.json`;
break; break;
case "layer": case "layer":
url += `&style=${baseUrl}/example-layer-style.json`; url += `&style=${baseUrl}/example-layer-style.json`;
break; break;
} }
if (zoom) { if (zoom) {
url += `#${zoom}/41.3805/2.1635`; url += `#${zoom}/41.3805/2.1635`;
@@ -169,13 +169,6 @@ export class MaputnikDriver {
styleFromLocalStorage: () => styleFromLocalStorage: () =>
this.helper.get.window().then((win) => styleFromWindow(win)), this.helper.get.window().then((win) => styleFromWindow(win)),
maputnikStyleFromLocalStorageObj: () => {
const styleId = localStorage.getItem("maputnik:latest_style");
const styleItem = localStorage.getItem(`maputnik:style:${styleId}`);
const obj = JSON.parse(styleItem || "");
return obj;
},
exampleFileUrl: () => { exampleFileUrl: () => {
return baseUrl + "example-style.json"; return baseUrl + "example-style.json";
}, },
cypress/e2e/modal-driver.ts
+1 -1
View File
@@ -1,5 +1,5 @@
import { v1 as uuid } from "uuid"; import { v1 as uuid } from "uuid";
import MaputnikCypressHelper from "./cypress-wrapper-driver"; import MaputnikCypressHelper from "./maputnik-cypress-helper";
export default class ModalDriver { export default class ModalDriver {
private helper = new MaputnikCypressHelper(); private helper = new MaputnikCypressHelper();
cypress/e2e/modals.cy.ts
+2 -2
View File
@@ -5,7 +5,7 @@ describe("modals", () => {
beforeAndAfter(); beforeAndAfter();
beforeEach(() => { beforeEach(() => {
when.visit("/"); when.setStyle("");
}); });
describe("open", () => { describe("open", () => {
beforeEach(() => { beforeEach(() => {
@@ -51,7 +51,7 @@ describe("modals", () => {
when.click("nav:export"); when.click("nav:export");
}); });
it.skip("close", () => { it("close", () => {
when.modal.close("modal:export"); when.modal.close("modal:export");
then(get.elementByTestId("modal:export")).shouldNotExist(); then(get.elementByTestId("modal:export")).shouldNotExist();
}); });