review comments

This commit is contained in:
shelly_goldblit
2024-01-01 15:53:15 +02:00
parent 13336bf2af
commit 1d938b5a8b
4 changed files with 16 additions and 23 deletions

View File

@@ -1,6 +1,6 @@
import { CypressHelper } from "@shellygo/cypress-test-utils";
import { Assertable, then } from "@shellygo/cypress-test-utils/assertable";
import MaputnikCypressHelper from "./cypress-wrapper-driver";
import MaputnikCypressHelper from "./maputnik-cypress-helper";
import ModalDriver from "./modal-driver";
const baseUrl = "http://localhost:8888/";
@@ -108,18 +108,18 @@ export class MaputnikDriver {
) => {
let url = "?debug";
switch (styleProperties) {
case "geojson":
url += `&style=${baseUrl}geojson-style.json`;
break;
case "raster":
url += `&style=${baseUrl}raster-style.json`;
break;
case "both":
url += `&style=${baseUrl}geojson-raster-style.json`;
break;
case "layer":
url += `&style=${baseUrl}/example-layer-style.json`;
break;
case "geojson":
url += `&style=${baseUrl}geojson-style.json`;
break;
case "raster":
url += `&style=${baseUrl}raster-style.json`;
break;
case "both":
url += `&style=${baseUrl}geojson-raster-style.json`;
break;
case "layer":
url += `&style=${baseUrl}/example-layer-style.json`;
break;
}
if (zoom) {
url += `#${zoom}/41.3805/2.1635`;
@@ -169,13 +169,6 @@ export class MaputnikDriver {
styleFromLocalStorage: () =>
this.helper.get.window().then((win) => styleFromWindow(win)),
maputnikStyleFromLocalStorageObj: () => {
const styleId = localStorage.getItem("maputnik:latest_style");
const styleItem = localStorage.getItem(`maputnik:style:${styleId}`);
const obj = JSON.parse(styleItem || "");
return obj;
},
exampleFileUrl: () => {
return baseUrl + "example-style.json";
},

View File

@@ -1,5 +1,5 @@
import { v1 as uuid } from "uuid";
import MaputnikCypressHelper from "./cypress-wrapper-driver";
import MaputnikCypressHelper from "./maputnik-cypress-helper";
export default class ModalDriver {
private helper = new MaputnikCypressHelper();

View File

@@ -5,7 +5,7 @@ describe("modals", () => {
beforeAndAfter();
beforeEach(() => {
when.visit("/");
when.setStyle("");
});
describe("open", () => {
beforeEach(() => {
@@ -51,7 +51,7 @@ describe("modals", () => {
when.click("nav:export");
});
it.skip("close", () => {
it("close", () => {
when.modal.close("modal:export");
then(get.elementByTestId("modal:export")).shouldNotExist();
});