RC3 had a major bug with event handling in the MouseToolbar, introduced due

to firebug/safari-specific debug statements left in the RC. This will fix the
"Every time I drag a rectangle, it just keeps dragging" issue that users
were reporting.


git-svn-id: http://svn.openlayers.org/tags/openlayers/release-2.0-rc4@1349 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf

examples/kamap.html

@@ -18,7 +18,7 @@
                  {layers: 'basic'} );
 
             var jpl_wms = new OpenLayers.Layer.KaMap( "Satellite",
-                    "/world/index.php", {g: "satellite", map: "world"});
+                    "http://www.openlayers.org/world/index.php", {g: "satellite", map: "world"});
             var dm_wms = new OpenLayers.Layer.WMS( "Canada",
                 "http://www2.dmsolutions.ca/cgi-bin/mswms_gmap",
                 {layers: "bathymetry,land_fn,park,drain_fn,drainage," +

lib/OpenLayers/Control/MouseDefaults.js

@@ -60,6 +60,7 @@ OpenLayers.Control.MouseDefaults.prototype =
         var newCenter = this.map.getLonLatFromViewPortPx( evt.xy ); 
         this.map.setCenter(newCenter, this.map.zoom + 1);
         Event.stop(evt);
+        return false;
     },
 
     /**
@@ -124,20 +125,24 @@ OpenLayers.Control.MouseDefaults.prototype =
     defaultMouseUp: function (evt) {
         if (!Event.isLeftClick(evt)) return;
         if (this.zoomBox) {
-            var start = this.map.getLonLatFromViewPortPx( this.mouseDragStart ); 
+            if (Math.abs(this.mouseDragStart.x - evt.xy.x) > 5 ||    
-            var end = this.map.getLonLatFromViewPortPx( evt.xy );
+                Math.abs(this.mouseDragStart.y - evt.xy.y) > 5) {   
-            var top = Math.max(start.lat, end.lat);
+                var start = this.map.getLonLatFromViewPortPx( this.mouseDragStart ); 
-            var bottom = Math.min(start.lat, end.lat);
+                var end = this.map.getLonLatFromViewPortPx( evt.xy );
-            var left = Math.min(start.lon, end.lon);
+                var top = Math.max(start.lat, end.lat);
-            var right = Math.max(start.lon, end.lon);
+                var bottom = Math.min(start.lat, end.lat);
-            var bounds = new OpenLayers.Bounds(left, bottom, right, top);
+                var left = Math.min(start.lon, end.lon);
-            var zoom = this.map.getZoomForExtent(bounds);
+                var right = Math.max(start.lon, end.lon);
-            this.map.setCenter(new OpenLayers.LonLat(
+                var bounds = new OpenLayers.Bounds(left, bottom, right, top);
-              (start.lon + end.lon) / 2,
+                var zoom = this.map.getZoomForExtent(bounds);
-              (start.lat + end.lat) / 2
+                this.map.setCenter(new OpenLayers.LonLat(
-             ), zoom);
+                  (start.lon + end.lon) / 2,
+                  (start.lat + end.lat) / 2
+                 ), zoom);
+            }
             this.map.viewPortDiv.removeChild(document.getElementById("zoomBox"));
             this.zoomBox = null;
+            
         } else {
             if (this.performedDrag) {
                 this.map.setCenter(this.map.center);

lib/OpenLayers/Control/MouseToolbar.js

@@ -47,9 +47,7 @@ OpenLayers.Control.MouseToolbar.prototype =
         centered = centered.add((this.direction == "vertical" ? 0 : sz.w), (this.direction == "vertical" ? sz.h : 0));
         this._addButton("pan", "panning-hand-off.png", "panning-hand-on.png", centered, sz, "Drag the map to pan.");
         centered = centered.add((this.direction == "vertical" ? 0 : sz.w), (this.direction == "vertical" ? sz.h : 0));
-        this._addButton("measure", "measuring-stick-off.png", "measuring-stick-on.png", centered, sz, "Hold alt when clicking to show distance between selected points");
         this.switchModeTo("pan");
-        this.map.events.register("zoomend", this, function() { this.switchModeTo("pan"); });
         return this.div;
         
     },
@@ -95,6 +93,8 @@ OpenLayers.Control.MouseToolbar.prototype =
         this.performedDrag = false;
         var newCenter = this.map.getLonLatFromViewPortPx( evt.xy ); 
         this.map.setCenter(newCenter, this.map.zoom + 2);
+        Event.stop(evt);
+        return false;
     },
 
     /**
@@ -104,8 +104,10 @@ OpenLayers.Control.MouseToolbar.prototype =
         if (!Event.isLeftClick(evt)) return;
         this.mouseDragStart = evt.xy.clone();
         this.performedDrag = false;
+        this.startViaKeyboard = false;
         if (evt.shiftKey && this.mode !="zoombox") {
             this.switchModeTo("zoombox");
+            this.startViaKeyboard = true;
         } else if (evt.altKey && this.mode !="measure") {
             this.switchModeTo("measure");
         } else if (!this.mode) {
@@ -238,21 +240,25 @@ OpenLayers.Control.MouseToolbar.prototype =
         if (!Event.isLeftClick(evt)) return;
         switch (this.mode) {
             case "zoombox":
-                var start = this.map.getLonLatFromViewPortPx( this.mouseDragStart ); 
+                if (Math.abs(this.mouseDragStart.x - evt.xy.x) > 5 ||    
-                var end = this.map.getLonLatFromViewPortPx( evt.xy );
+                    Math.abs(this.mouseDragStart.y - evt.xy.y) > 5) {  
-                var top = Math.max(start.lat, end.lat);
+                    var start = this.map.getLonLatFromViewPortPx( this.mouseDragStart ); 
-                var bottom = Math.min(start.lat, end.lat);
+                    var end = this.map.getLonLatFromViewPortPx( evt.xy );
-                var left = Math.min(start.lon, end.lon);
+                    var top = Math.max(start.lat, end.lat);
-                var right = Math.max(start.lon, end.lon);
+                    var bottom = Math.min(start.lat, end.lat);
-                var bounds = new OpenLayers.Bounds(left, bottom, right, top);
+                    var left = Math.min(start.lon, end.lon);
-                var zoom = this.map.getZoomForExtent(bounds);
+                    var right = Math.max(start.lon, end.lon);
-                this.map.setCenter(new OpenLayers.LonLat(
+                    var bounds = new OpenLayers.Bounds(left, bottom, right, top);
-                  (start.lon + end.lon) / 2,
+                    var zoom = this.map.getZoomForExtent(bounds);
-                  (start.lat + end.lat) / 2
+                    this.map.setCenter(new OpenLayers.LonLat(
-                 ), zoom);
+                      (start.lon + end.lon) / 2,
+                      (start.lat + end.lat) / 2
+                     ), zoom);
+                }    
                 this.map.viewPortDiv.removeChild(document.getElementById("zoomBox"));
                 this.zoomBox = null;
-                this.leaveMode();
+                console.log(this.startViaKeyboard);
+                if (this.startViaKeyboard) this.leaveMode();
                 break;
             case "pan":
                 if (this.performedDrag) {

lib/OpenLayers/Layer.js

@@ -182,6 +182,9 @@ OpenLayers.Layer.prototype = {
           'minExtent', 'maxExtent',
           'numZoomLevels'
         );
+        if (this.map.maxZoomLevel && !this.numZoomLevels) {
+            this.numZoomLevels = this.map.maxZoomLevel + 1;
+        }
         for(var i=0; i < properties.length; i++) {
             if (this[properties[i]] == null) {
                 this[properties[i]] = this.map[properties[i]];

lib/OpenLayers/Layer/EventPane.js

@@ -63,7 +63,6 @@ OpenLayers.Layer.EventPane.prototype =
         } else {
             this.map.layerContainerDiv.appendChild(this.pane);
         }
-        this.map.events.attachToElement(this.pane);
     },
   
     /** 

lib/OpenLayers/Layer/KaMap.js

@@ -49,7 +49,7 @@ OpenLayers.Layer.KaMap.prototype =
      */
     getURL: function (bounds) {
         var mapRes = this.map.getResolution();
-        var scale = this.map.getScale();        
+        var scale = Math.round((this.map.getScale() * 10000)) / 10000;        
         var cellSize = new OpenLayers.Size(mapRes*this.tileSize.w, mapRes*this.tileSize.h);
         var pX = Math.round(((bounds.left) / cellSize.w) * this.tileSize.w);
         var pY = -Math.round(((bounds.top) / cellSize.h) * this.tileSize.h);