Commit Graph

68 Commits

Author SHA1 Message Date
Maximilian Krög
58e2e57638 Fix hit detection of RegularShape with transparent fill 2021-07-12 19:33:17 +02:00
Maximilian Krög
5f3b22bf7f Remove lineCap, it is useless on closed paths 2021-07-12 19:32:42 +02:00
Maximilian Krög
ad37baf351 Remove redundant size properties / getter 2021-07-11 12:32:04 +02:00
Maximilian Krög
bee28d61ea cache render options object 2021-07-11 12:32:03 +02:00
Maximilian Krög
53cf5bb282 Lazily create Regular shape canvases
Creating the cached canvases is expensive and they may never be used.
E. g. the hit detect canvas is not needed with the Immediate renderer
and if a feature is never in the viewport the image is not needed either.
2021-07-11 12:32:03 +02:00
Maximilian Krög
87f215939c Fix some RegularShape bugs related to canvsa size
- remove jitter when using RegularShape size in animation, size should
always be an integer
- canvas may have been too small for miter line join
- canvas was at least one stroke width too large for round line join
- reduce canvas size even more for bevel line join

Canvas now precisely fits the shape including stroke, The angle of the
shape is ignored for the calculation.
2021-07-11 12:32:03 +02:00
Maximilian Krög
f21513ab5a Consistent behaviour if two radii are provided
Always double the points event when two radii of same size are provided.
2021-07-11 12:32:03 +02:00
Maximilian Krög
28c40fe93e getImage is always called with valid pixelRatio 2021-07-11 12:32:03 +02:00
Maximilian Krög
5716c614a8 Cleanup drawing of RegularShape
Fixes missing miter/bevel line join because path was not closed before
stroking.
Reduce canvas context calls, skip beginPath, and instead of drawing the
last point use closePath
2021-07-11 12:31:55 +02:00
Maximilian Krög
82265ef031 No unnecessary canvas with transparent fill
With pixelRatio != 1 and a transparent fill a unnecessary image was created.
2021-07-11 12:30:18 +02:00
Simon Seyock
2ad5789797 Add descriptions for properties. 2021-02-04 18:19:33 +01:00
Simon Seyock
808868ad1f Fixed some jsdoc issues. 2021-02-02 12:15:30 +01:00
Simon Seyock
f590cb3473 Harmonize jsdoc 2021-02-02 12:14:56 +01:00
mike-000
0807b44722 Clear this.canvas_ whenever render() is called 2020-09-01 09:27:17 +01:00
mike-000
f897503e10 Cosmetic fix to doc (missing closing quote) 2020-08-28 22:27:33 +01:00
mike-000
722e0c5b69 Include scale in options
Add rectangle to example
Add ellipse and rectangle to rendering tests
2020-08-09 10:25:16 +01:00
Andreas Hocevar
ac5f52a21f Hit detect everything with a pixel ratio of 1 2020-07-27 19:56:35 +02:00
Stéphane Brunner
f2fe6e5957 Have high resolution regular shape 2020-07-15 10:53:20 +02:00
Tim Schaub
054af09032 Make code prettier
This updates ESLint and our shared eslint-config-openlayers to use Prettier.  Most formatting changes were automatically applied with this:

    npm run lint -- --fix

A few manual changes were required:

 * In `examples/offscreen-canvas.js`, the `//eslint-disable-line` comment needed to be moved to the appropriate line to disable the error about the `'worker-loader!./offscreen-canvas.worker.js'` import.
 * In `examples/webpack/exapmle-builder.js`, spaces could not be added after a couple `function`s for some reason.  While editing this, I reworked `ExampleBuilder` to be a class.
 * In `src/ol/format/WMSGetFeatureInfo.js`, the `// @ts-ignore` comment needed to be moved down one line so it applied to the `parsersNS` argument.
2020-04-06 12:54:09 -06:00
Frederic Junod
506aa7aae7 Remove all inheritDoc tags from src/ol/style 2020-04-03 07:56:58 +02:00
jkonieczny
2112478b6b Added test + jsdoc 2020-01-15 11:13:45 +01:00
jkonieczny
78378f0253 refactor offset to displacement 2020-01-15 11:13:45 +01:00
jkonieczny
4c7f52c8a4 Offset for ImageStyle 2020-01-15 11:13:44 +01:00
jkonieczny
1506e13b60 use anchor for offsetting 2020-01-15 11:13:44 +01:00
jkonieczny
601bd7bae6 add offset option to RegularShape 2020-01-15 11:13:44 +01:00
Frederic Junod
daaaff5ac7 Remove unnecessary typecast
Remove typecast where typescript is able to correctly deduce the type.
2019-10-02 10:44:06 +02:00
mike-000
e28fa56edd Changes for the CircleStyle inconsistency seen in #9395
Change hit detection test to reflect fix for #9395 CircleStyle inconsistency

Update ol/style/Circle and ol/style/RegularShapen tests
Revise test for no fill
Add test for transparent fill

Update Upgrade notes
Changes to hit detection with unfilled styles
2019-09-26 14:27:31 +01:00
ahocevar
ebfb20440a Simplify events and store listeners only in one place 2019-09-04 16:48:43 +02:00
Frederic Junod
ad51c7c08f Use CanvasLineCap type instead of string 2019-07-05 11:11:35 +02:00
Frederic Junod
7a8a0c18ae Use CanvasLineJoin type instead of string 2019-07-05 11:07:10 +02:00
Frederic Junod
0d6368d4ec Remove underscore from protected function, fix indentation, remove typecast 2019-06-25 10:40:11 +02:00
ahocevar
b33ceaa400 More efficient default fill color 2019-03-19 13:57:10 +01:00
Frederic Junod
0ec769c234 Remove getChecksum functions 2018-12-14 13:00:35 +01:00
Frederic Junod
1bb1e3c542 Remove Atlas and AtlasManager 2018-12-14 13:00:35 +01:00
Frederic Junod
b3520f8217 Remove CANVAS_LINE_DASH from ol/has
Test if `context.setLineDash` is defined instead.
2018-12-07 13:15:23 +01:00
Frederic Junod
caaf8cb86f Simplify import path in ol/style/ 2018-11-05 16:26:45 +01:00
Kevin Schmidt
124fccf127 Fix style TypeScript errors 2018-09-17 12:38:00 -06:00
Frederic Junod
ea616e7751 Don't import ourselves 2018-09-06 09:05:32 +02:00
Tim Schaub
ccfacc5ee6 Transformed types
Using the [ts.js codemod](https://gist.github.com/tschaub/1ea498c9d1e5268cf36d212b3949be4e):

    jscodeshift --transform ts.js src
2018-09-05 08:05:29 -06:00
Marc Jansen
99245b47f7 Better type annotation 2018-09-03 21:17:56 +02:00
ahocevar
f382ddf230 Remove snapToPixel option and deprecate getters/setters 2018-08-09 18:16:58 +02:00
Tim Schaub
d12ef20b12 Use Array<Foo> instead of Array.<Foo> 2018-07-25 18:32:43 -07:00
ahocevar
bbe0a66d07 Set api annotation on classdesc, not constructor 2018-07-21 17:25:22 +02:00
Tim Schaub
b8c9125602 Remove lint 2018-07-18 10:35:54 -06:00
ahocevar
87a3510c83 Clean up super calls 2018-07-18 12:19:15 +02:00
Tim Schaub
3f4ba0af5f Call super in regular shape 2018-07-18 00:44:24 -06:00
Tim Schaub
9ce36da349 Remove @extends and @constructor annotations 2018-07-18 00:36:29 -06:00
Tim Schaub
b7b15eb7f0 Remove unused inherits 2018-07-18 00:13:43 -06:00
Tim Schaub
1a5cf52b61 Remove remaining use of inherits in src 2018-07-17 23:43:10 -06:00
Tim Schaub
f78d0d4cfa Manual class transform 2018-07-16 17:09:50 -06:00