ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
6,713 Commits 5 Branches 232 Tags
f4a4090814f240414548e8eda55070d16f3d3901
Commit Graph

63 Commits

Author SHA1 Message Date
ahocevar
b103d3b428 We don't want to re-select an already selected feature 2013-05-24 12:07:35 +02:00
ahocevar
8562582dd2 Avoiding duplicate events 2013-05-24 12:07:22 +02:00
iacovlev-pavel
7c5afe1acf Add OpenLayers/Control.js to "requires" 
Fix issue #969
 2013-05-13 13:01:21 +02:00
ahocevar
9d6ce21109 Raise layer that's being modified 2013-04-27 21:46:22 +02:00
ahocevar
e5dc583d52 Also trigger beforefeaturemodified event in non-standalone mode 
d2a32d5 accidently changed the number of assertions in the
test_selectFeature function, so the change in behavior that no
beforefeaturemodified event is called any more in non-standalone mode got
unnoticed: Before unhacking ModifyFeature, the SelectFeature control
called the beforeSelectFeature method directly. Now, without a built-in
SelectFeature control, we need to call it from the selectFeature method in
both standalone and non-standalone mode.
 2013-04-09 23:16:30 +02:00
ahocevar
6fca6aef60 Addressing @bartvde's review comments 2013-03-20 10:23:00 +01:00
ahocevar
d2a32d5421 Simplifying and unhacking the ModifyFeature control 
With two nested controls (DragFeature, SelectFeature), which - among
others - activated two OpenLayers.Handler.Feature instances, the
ModifyFeature control was fragile and hard to debug.

The issue that @iwillig, @bartvde and myself tried to track down was
that the two Feature handlers interfered with each other, making it hard
to select features on mobile devices, and causing points to jump during
dragging because of not updated last pixel positions.

With this refactoring, there are no more nested controls. All that's left
is a Drag handler. All tests pass. I had to remove one test that checked
for dragging of an unselected point while another was selected, because
now (and partially even before this change, thanks to the ugly drag
handler hack that is now removed) dragging a point will also select it,
saving the user an extra click.
 2013-03-19 23:00:10 +01:00
Marc Jansen
a34e627b75 Remove dangling space in license header. 2013-02-07 10:33:20 +01:00
Tim Schaub
bbc73a21d8 Update copyright date 2013-01-07 22:01:16 -05:00
Marc Jansen
1348f97546 Replace tabs with spaces where appropriate. 2012-09-11 21:51:18 +02:00
fastr
e8716847f8 Adding DocumentDrag to ModifyFeature 2012-08-25 23:37:39 +02:00
fastr
053dba59a1 Inserted documentDrag in ModifyFeature so that you can drag vertices over the viewport of the map in analogy to the DragFeature-Control. documentDrag is internaly passed to the DragFreature that's used by ModifyFeature. 2012-08-25 23:30:27 +02:00
Éric Lemoine
e0b93c2e45 The OpenLayers code is published under the 2-clause BSD license 2012-03-30 08:33:55 +02:00
Éric Lemoine
650df2a8f1 change copyright header in every OpenLayers js file 2012-03-29 22:14:56 +02:00
Xavier Mamano
bfb379f349 Fix some problems in the documentation. 2012-03-05 11:43:09 +01:00
Xavier Mamano
af8a483f10 "snappingOptions" option is not used neither in lib examples and evidence. 2012-03-04 17:01:06 +01:00
fredj
6daecd677d New createVertices option for Control.ModifyFeature 2012-02-09 14:12:52 +01:00
ahocevar
def2085915 vertexRenderIntent for all sketch modes. 
Fixed whitespace from original patch.
p=mosesonline, r=me (closes http://trac.openlayers.org/ticket/3581)
 2012-01-23 14:39:06 +01:00
Pierre GIRAUD
059a400ab3 unselectFeature should be API 2012-01-17 09:27:36 +01:00
tschaub
b844a3b11b Happy New Year! 
Updating copyright to 2012.
 2012-01-03 09:01:10 -07:00
bartvde
c587865bb1 deleting a vertex does not set feature.modified, this is a regression since in OL 2.10 a WFS transaction would include all fields, but 2.11 is smarter in the sense that it filters out fields that have not changed in the Transaction XML, which in this case, i.e. deleting a vertex, results in no geometry in the WFS transaction, r=tschaub (pullup #3463) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@12248 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2011-08-15 16:26:34 +00:00
ahocevar
2293987d57 adding a feature.modified property, making the ModifyFeature control set it and the WFST format check for it so only modified attributes and a modified geometry need to be included in an Update transaction. r=bartvde (closes #3400) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@12149 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2011-07-04 08:37:55 +00:00
Tim Schaub
995d612caa More robust array type check. p=mwootendev, r=me (closes #2959) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@12095 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2011-06-16 19:16:25 +00:00
ahocevar
b30d35c615 making ModifyFeature control in standalone mode trigger the beforefeaturemodified event. r=bartvde (closes #3009 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11146 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2011-02-18 15:25:41 +00:00
ahocevar
c8982cb99a give Layer.Vector a vertexremoved event, to be fired e.g. by the ModifyFeature control. r=bartvde (closes #3017) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11043 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2011-01-19 16:44:39 +00:00
Tim Schaub
ad54169479 Happy New Year. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@10995 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2011-01-03 15:39:40 +00:00
ahocevar
da8766d9d6 give ModifyFeature control a vertexRenderIntent property. r=tschaub (closes #2955) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@10938 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2010-12-01 19:40:17 +00:00
crschmidt
f0d474e50b Change license text to point to "OpenLayers contributors", referencing 
authors.txt file. In reality, MetaCarta does not own copyright to these files,
they merely have a right to distribute them under the license terms agreed to
by the contributors. At this point, there is no longer any reference to
MetaCarta as a copyright holder in the OpenLayers project, only to its
individual contributors via the authors.txt file.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@10706 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2010-09-01 03:06:31 +00:00
Éric Lemoine
d0a2edbebd correct minor typo in the API docs, no functional change 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@10383 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2010-06-08 19:04:16 +00:00
ahocevar
01d4330c81 In standalone mode, allow only dragging of sketch vertices or the point 
selected for modification. Thanks tschaub for the improved patch. 
r=tschaub (closes #2219)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@9613 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2009-08-05 23:33:26 +00:00
ahocevar
8fdd423104 provide a standalone mode for the ModifyFeature control. Thanks tschaub 
for the fix in deactivate() and the tests. r=tschaub (closes #2199)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@9591 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2009-07-27 18:00:36 +00:00
Tim Schaub
2ab6c404e1 Adding the ability to change the aspect ratio of features while resizing with the modify feature control. Thanks for the patch rdewit! r=me (closes #1975) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9150 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2009-03-31 21:36:11 +00:00
Éric Lemoine
f04f203499 ghost features stay displayed with select feature control, r=pgiraud (closes #1865) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8899 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2009-02-26 15:19:43 +00:00
Tim Schaub
41670499b1 Adding vertexmodified, sketchmodified, and sketchcomplete events to the vector layer. These are triggered by the DrawFeature and ModifyFeature controls and let listeners know about newly drawn features and modified features. r=ahocevar (closes #1904) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8835 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2009-02-05 17:38:20 +00:00
Tim Schaub
d5950d4b29 Draw and modify controls now set feature state. No longer do we need to check feature state in app code in cases where features are created or modified with these controls. r=elemoine,ahocevar (closes #1833) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8382 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-11-16 18:26:39 +00:00
Éric Lemoine
7c0fadd14a ModifyFeature makes SelectFeature control behave/become like ModifyFeature, patch=bjornharrtell,tschaub, r=tschaub,me (closes #1741) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8302 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-11-07 08:46:02 +00:00
crschmidt
09b4073636 * Fixes to the Keyboard Handler to make it work better -- 
* drop keypress event (not used, registers as keydown in IE< which results
      in double events) 
    * return evt instead of evt.keyCode || evt.charCode, so apps can do
      whatever they like best
 * adjust ModifyFeature to new API
 * Adjust KeyboardDefaults to new API, and include a new set of keyCodes
    in switch statement to catch more cases
 * Include keyboard defaults test in list-tests.

Patch from tcoulter, work from Pedro Simonetti (See #1108), Paul Spencer,
myself. r=pagameba,me (Closes #1292)   


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7644 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-07-31 17:45:16 +00:00
Tim Schaub
66a4c6fb0e Caching array length instead of accessing it with each iteration. r=crschmidt (closes #1636) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7627 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-07-31 04:44:25 +00:00
Tim Schaub
6897c8ed4d Adding a beforefeatureselected event to the vector layer events. If a listener returns false, the feature is not selected. The modify feature control now listens for beforefeatureselected and triggers beforefeaturemodified. If a listener returns false, feature modification never begins. r=elemione,ahocevar (closes #1427) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7616 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-07-30 22:03:40 +00:00
Éric Lemoine
c2c23cb3f3 modify feature control must use silent:true when removing/destroying vertices, p=me, r=crschmidt (closes #1562) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7614 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-07-30 20:26:13 +00:00
Éric Lemoine
34ff282397 ND changes in the modify feature control. Thanks ahocevar for catching the erroneous comment in handleKeypress. No fonctional change. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7213 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-05-17 20:11:45 +00:00
Éric Lemoine
9190e24bcd Cannot modify a feature (linestring) that have two points at the same position, r=me, thanks pvalsecc for the patch and the detailed justification of this patch. (closes #1533) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7061 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-05-05 06:55:07 +00:00
Tim Schaub
209f8f68f8 Fixing links in documentation. Other Natural Docs changes. (closes #1504) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6833 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-04-09 16:52:08 +00:00
ahocevar
7251cb438f fixed typo: replaced styleVirtual with virtualStyle, so it matches the API property. r=crschmidt (pullup #1495) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6802 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-04-07 08:07:25 +00:00
Paul Spencer
d15ab68360 quick lint before rc1, only some missing missing semi-colons. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6748 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-04-01 00:14:34 +00:00
Tim Schaub
6d59830d0e Documenting onModification* methods as deprecated in ModifyFeature control. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6490 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-03-11 16:02:39 +00:00
Frédéric Junod
8b91ee8d64 Send events when modifying features: 
'beforefeaturemodified' triggered when a feature is selected to be modified,
  'featuremodified' triggered when a feature has been modified,
  'afterfeaturemodified' triggered when a feature is finished being modified

r=tschaub (Closes #1358)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6413 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-29 06:50:39 +00:00
pgiraud
10ee48c84c fixes typo (Closes #1365) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6315 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-16 08:20:49 +00:00
ahocevar
c5dd8ada2c "users should be able to customize the select style per feature": Created a !StyleMap class which stores all styles that are needed for a layer. Controls that need to render features differently can now just give a render intent (e.g. "default", "select" or "temporary") to the layer's drawFeature method, instead of having extra style informations like Control.!SelectFeature.selectStyle. Existing application that set layer.style or feature.style are still supported, but both of these style properties are now null by default. r=crschmidt,elemoine,tschaub (closes #1120) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6240 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-12 23:05:47 +00:00
Tim Schaub
f27833f1db Trigger feature related events with feature information and layer related events with layer information. Also adding events.on and events.un convenience methods. r=crschmidt (closes #1343) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6149 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-08 23:31:27 +00:00