Commit Graph

84 Commits

Author SHA1 Message Date
Tim Schaub
c2148651ed Filling our log with cruft, adding meaningless conflicts for merges, and changing a comment style that ndocs could care less about, this commit changes Return to Returns (closes #945).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4110 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-29 18:44:10 +00:00
crschmidt
807449046b Commit fix for an off-by-two error on standards complaint HTML pages in IE, and
add an HTML example that can be used as an acceptance test. (Closes #863) 
Thanks pierre for the research and report!


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4098 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-29 04:03:13 +00:00
crschmidt
b9a1287a5f "Event object conflict: If you include OpenLayers.js AFTER including
prototype.js, this effectively replaces most of prototype's Event object with
the OpenLayers.Event object, which has undesirable results (i.e. calling
Event.observe is actually calling OpenLayers.Event.observe)." Fixed by
only creating Event is Event does not already exist. (Closes #880)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4040 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-25 07:39:28 +00:00
crschmidt
6194452b8a Since John already went ahead and committed the main change, I'm just going
to finish this one up. All commits are in comments, so a review doesn't seem
strictly neccesary. This closes #918 and fixes all the copyrights that I could 
find in the code.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3984 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-23 11:29:06 +00:00
euzuro
cf5a53959e ND Update: make array's say what they're made of, and a few other small bits, like mistyped and a couple missing <>s
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3829 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-31 20:02:03 +00:00
euzuro
8c552be94b as universally approved on discussions on dev list, replace new Array() with []. all tests pass ff & ie6
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3815 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-25 22:48:02 +00:00
euzuro
5f0bde51da as universally approved on discussions on dev list, replace new Object() with {}. all tests pass ff & ie6
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3814 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-25 22:39:28 +00:00
euzuro
fd4d2918f1 fix for #853 - remove JSDOC comments from CLASS_NAME variables
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3787 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-23 15:09:09 +00:00
Tim Schaub
cc1b0269c9 #823 New class style. Instead of OldStyle = Class.create(); OldStyle.prototype = Class.inherit(Parent, prototype), we now use NewStyle = OpenLayers.Class(Parent, prototype). New style classes allow for backwards compatibility [you can use OldStyle = Class.create(); Class.inherit(NewStyle, prototype)]. The Class.create and Class.inherit functions are deprecated. Backwards compatibility will be removed at 3.0. Thanks Erik for the careful review.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3767 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-16 20:25:11 +00:00
Tim Schaub
f1d9208abd replacing tabs with spaces
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3684 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-10 21:40:26 +00:00
euzuro
a14b5bdc7e patch for #809 - add the addEventType() function to the OpenLayers.Events objects so that subclasses can safely add new event types without modifying their parents' constant values
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3622 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-06 18:30:09 +00:00
euzuro
bee797430d update nd docs for Openlayers.Events
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3621 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-06 17:47:38 +00:00
euzuro
a74a9bd49f remove *private* statements from nd comments
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3620 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-06 17:38:20 +00:00
euzuro
23bc407f8b update nd for OpenLayer.Event object
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3599 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-05 20:02:29 +00:00
crschmidt
3948913bfc Merge all changes from the naturaldocs sandbox. This brings all the work that
has been done in the NaturalDocs branch back to trunk. Thanks to everyone who
helped out in making this happen. (I could list people, but the list would
be long, and I'm already mentally on vacation.)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3545 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-06-29 15:59:20 +00:00
euzuro
23131012dd fix for #624 - merge stop() and safeStopPropagation()
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2994 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 17:15:57 +00:00
euzuro
10b5c2df17 patch for #621 - assign items in the elements hash table a unique cacheID instead of relying on the element's actual 'id' property. thx for thorough review sde
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2993 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 16:54:14 +00:00
euzuro
d0115ccf26 patch for #625 - remove extraneous _observeAndCache() function which is only used once. it doesnt seem to conceptually abstract anything, so lets inline it
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2991 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 15:54:27 +00:00
euzuro
33cb7fd0d4 patch for #623 - remove unused pointerX() and pointerY() functions
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2990 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 15:38:16 +00:00
euzuro
9aa92d491c events.js cleanup: more ifs without brackets
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2989 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:42:21 +00:00
euzuro
7aac1c1cfe coding standards. if statement without brackets and multiple return
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2988 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:38:22 +00:00
euzuro
8440cbaf43 coding standards if statement should always be followed by braces. also, add comment
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2987 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:37:04 +00:00
euzuro
2734030a82 move unloadCache() down so that stopObserving and stopObservingElement() are next to eachother
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2986 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:31:45 +00:00
euzuro
2f8a093f83 move observe() function up to right before its private counterpart
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2985 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:27:39 +00:00
euzuro
ade794259f move observers definition to top of object definition for readability
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2984 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:26:39 +00:00
euzuro
8007b6719a events.js: style (never underestimate style)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2983 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 23:12:55 +00:00
euzuro
ed0fca9157 events cleanup: fix tabs
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2982 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 23:00:55 +00:00
euzuro
dfa4441646 step one of cleaning up events.js: jsdoc
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2981 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 22:49:13 +00:00
crschmidt
474064b4e5 Clean up all events, not just some of them. Cleans up possible memory leaks.
Closes #604, patch by Erik. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2947 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-31 19:47:05 +00:00
crschmidt
53b23bdf37 make stopObserving/stopObservingElement more resilient: can accept either
elements or ids. Closes #603 (and makes #604 work).


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2946 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-31 19:46:04 +00:00
euzuro
aa4cca057d patch for #585 - delete row from hash instead of nullifying it. thx tim for quick approval
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2929 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 21:17:12 +00:00
euzuro
f850939a3a fix for small bug in previous patch for #568 which was put in at r2913
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2914 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 21:53:27 +00:00
crschmidt
a07a4c309d Cleanup to Events.js. By Erik, in #568.
* code was only ever removing the first event listener from each element 
    on unload cache (for loop instead of while) 
  * code was frequently not removing observers because their associated 
    elements have already been removed 
These two are fixed by this patch. Combined with the previous commits to
setting events, this should fix the memory leaks demonstrated by the 'drip'
tool for IE.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2913 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 21:41:08 +00:00
euzuro
87977f7bfe final patch for #510 -- new datastructure suggested and implemented by james for the events entry cache. speeds up all event operations
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2896 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-26 17:33:35 +00:00
euzuro
d10b4a37df applying (yet another) patch for #510
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2873 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-24 01:34:58 +00:00
Schuyler Erle
f99d1ce7b0 Fix the event listener leak, which has been a serious problem when large numbers of markers etc. are created. Closes #510.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2867 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-23 14:22:38 +00:00
crschmidt
3ca974acec Merge vector-2.4 branch back to trunk.
svn merge sandbox/vector-2.4/@2307 sandbox/vector-2.4/@HEAD trunk/openlayers/


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2803 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-16 13:23:56 +00:00
Schuyler Erle
436d1b5d11 Update/enhance some module dependencies.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2543 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-08 20:14:34 +00:00
crschmidt
c66f1ce360 Create a function -- OpenLayers.Util.getElement -- which replaces "$". This
should be used in all library code. This patch replaces all uses of "$()" in
existing code. The primary reason for this is to avoid conflicts with libraries
(like Prototype) which might redefine this function differently.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2541 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-08 20:14:03 +00:00
Tim Schaub
c12a92f938 clone listeners array before calling callbacks - see #464
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2164 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-01-19 19:41:51 +00:00
crschmidt
2467940cd3 A fix for #440. Prevent people who somehow get a null element in the event
cache from shooting themselves in the foot: This doesn't seem to happen often,
but it has happened in internal code. I'm going to add more debugging info to 
#440 as we get it, but want to get this in to prevent people from shooting 
themselves in the foot in IE accidentally.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2024 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-12-07 21:18:24 +00:00
crschmidt
786c2a20fb Change files to point to repository-license. Part of build process will now
be to change the licensing terms in the final build.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@1721 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-10-24 18:16:39 +00:00
crschmidt
da1984d764 Almost impossible to debug. element.offsets is cached (3x speedup -- a change
made in the early days of openlayers) but the cache means that relative mouse
positions are off if your first mouse event over the map is *after* the page is
scrolled. This closes #333 , and fixes a long standing not-well understood bug.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@1692 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-10-07 19:26:31 +00:00
crschmidt
781fbf1822 Event.Stop caused us to lose the ability to click on our permalink.
We like clicking on our permalink. bring that functionality back. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@1632 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-10-06 03:19:01 +00:00
Schuyler Erle
67ced536c0 Merged r1559:r1587 from source:/sandbox/crschmidt/noprototype. OpenLayers is now Prototype-free(tm).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1588 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-10-05 14:50:47 +00:00
euzuro
88ff0bc9af give our events model the option of allowing events to fall through so that they can be picked up in lower layers. change the panzoombar and the mousetoolbar to use this new fallthrough option so that we aren't causing bugs when the drag zoom rectangle gets dropped over them, they dont freak out. next up i am going to re-fix the popup events code to use this feature.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1468 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-09-14 20:25:23 +00:00
euzuro
8305808bee only prevent event from falling through if there are actually listeners registered. this fixes #247
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1423 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-09-08 21:31:42 +00:00
Schuyler Erle
e8bd5086df If Events finds a listener on a DOM element, call Event.stop so we don't fall through to other DOMelements.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1408 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-09-06 04:36:38 +00:00
crschmidt
ecdb77fa9c getMousePosition did not take into account page scrolling. This closes #211 .
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1385 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-08-26 15:55:41 +00:00
euzuro
c1b8c8dd60 change the '@require:' to '@requires' so as to be compatible with JSDOC standards. put these directly inside the class definition comment block. update script to suggest this and update all source files to follow pattern. Caught a missing @requires in the EventPane.js file
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1206 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-08-14 23:05:05 +00:00