Commit Graph

72 Commits

Author SHA1 Message Date
Andreas Hocevar
e9e664f3c9 Add typed signature for Observable#un() 2021-07-10 11:28:50 +02:00
Simon Seyock
d914006d51 Add signatures for once. 2021-07-10 11:28:49 +02:00
Simon Seyock
1870a64984 Add CombinedOnSignature. 2021-07-10 11:28:49 +02:00
Simon Seyock
ba9bfca9d5 Geolocation, Overlay, View 2021-07-10 11:28:48 +02:00
Simon Seyock
c8f43050c4 Revert "Merge pull request #12416 from ahocevar/eventtype-generics"
This reverts commit b6c143deb2, reversing
changes made to 7777821df5.
2021-07-10 11:28:46 +02:00
Andreas Hocevar
79f5f46d27 Remove lint 2021-06-28 18:10:51 +02:00
Andreas Hocevar
b6c143deb2 Merge pull request #12416 from ahocevar/eventtype-generics
Use generics to limit event types in on(), once() and un()
2021-06-21 09:36:25 +02:00
Andreas Hocevar
4dd75d75e3 Merge pull request #12414 from ahocevar/change-event-type
Replace getChangeEventType() with add/removeChangeListener methods
2021-06-21 08:04:23 +02:00
Andreas Hocevar
018ad97f25 Use generics to limit event types in on(), once() and un() 2021-06-20 22:25:47 +02:00
Andreas Hocevar
343e0ffce9 Replace getChangeEventType() with add/removeChangeListener methods 2021-06-19 23:16:26 +02:00
Tim Schaub
f798902ecd Fix JSDoc generated links 2021-06-17 21:54:07 -06:00
Marc Jansen
df23c234dc Fix common misspellings
These were found with codespell.
2021-03-05 22:53:35 +01:00
Simon Seyock
8facb252f1 Replace google closure syntax = with brackets around name 2021-02-03 14:06:02 +01:00
davidiamaf
ce0d744a10 guard for null
against map.getPixelFromCoordinateInternal() returning null

Per https://github.com/openlayers/openlayers/issues/11478
2020-08-27 16:15:09 -04:00
Andreas Hocevar
2760b0dafb Merge pull request #10936 from ahocevar/css-optional
Set pointerEvents style programmatically instead of relying on ol.css
2020-04-18 17:31:36 +02:00
Edward Nash
b543e4dedd Correct notation for optional argument 2020-04-17 10:54:44 +02:00
Edward Nash
17a8017e1e Fix calling Overlay.panIntoView with no options
* API-doc said undefined is OK, code assumed an object
2020-04-17 07:26:28 +02:00
Andreas Hocevar
7f6258dd0d Set pointerEvents style programmatically instead of relying on ol.css 2020-04-16 17:34:40 +02:00
Andreas Hocevar
fee9340e24 Remove lint 2020-04-15 22:44:05 +02:00
Andreas Hocevar
b0f20d6bd6 Use imports for enum types 2020-04-15 10:53:23 +02:00
Tim Schaub
054af09032 Make code prettier
This updates ESLint and our shared eslint-config-openlayers to use Prettier.  Most formatting changes were automatically applied with this:

    npm run lint -- --fix

A few manual changes were required:

 * In `examples/offscreen-canvas.js`, the `//eslint-disable-line` comment needed to be moved to the appropriate line to disable the error about the `'worker-loader!./offscreen-canvas.worker.js'` import.
 * In `examples/webpack/exapmle-builder.js`, spaces could not be added after a couple `function`s for some reason.  While editing this, I reworked `ExampleBuilder` to be a class.
 * In `src/ol/format/WMSGetFeatureInfo.js`, the `// @ts-ignore` comment needed to be moved down one line so it applied to the `parsersNS` argument.
2020-04-06 12:54:09 -06:00
Edward Nash
2b863793d0 Perform auto-pan when adding an Overlay to a Map
* Auto-pan settings currently only activate when the position of the
   Overlay is set and the Overlay is already on a Map.

 * The consequence of this is that creating an Overlay with position
   set and then adding to a Map results in no auto-pan being performed -
   it is necessary to first create the Overlay, then add to a Map and
   finally set the position in order for the Map to auto-pan.

 * This commit changes this behaviour so that the auto-pan settings are
   also considered when the map property of the Overlay is set and not
   only when the position property is set, leading to a more intuitive
   behaviour.

 * Fixes Issue #10843
2020-04-01 06:50:01 +02:00
Andreas Hocevar
f66b44068c Merge pull request #10800 from ejn/overlay-pan-into-view-10741
Make Overlay.panIntoView an API method
2020-03-31 23:19:38 +02:00
Edward Nash
2537da690a Add check that Position is set in panIntoView()
* If panIntoView is an API method, it may now be called when the
   position of the overlay has not yet been set.

 * Adds a check for a set position to the panIntoView() method,
   and removes the now unneccessary check in handlePositionChanged()
2020-03-30 07:15:03 +02:00
Edward Nash
b1b01cf943 Allow pan options supplied as autoPan
* Follow the suggestion from @ahocevar to use the existing
   autoPan constructor option instead of creating a new autoPanOptions
   option

 * Internally also store the autoPanOptions in autoPan
2020-03-30 07:12:52 +02:00
horsenit
03ea8911f6 Fix type checking for IE9 style.msTransform 2020-03-27 03:03:21 -04:00
horsenit
83a5cd63c6 Speed up Overlay element positioning using CSS translate() 2020-03-27 02:26:01 -04:00
Edward Nash
859bf338a2 Use Object for options to Overlay panIntoView
* animation and margin encapsulated in a single object to allow
   easier extension in future

 * Constructor options extended to allow single object for
   autoPan; separate options still allowed but deprecated

 * Protected fields for animation and margin replaced with single
   field
2020-03-13 10:12:14 +01:00
Edward Nash
022caae848 Document default margin in Overlay.panIntoView 2020-03-12 09:37:40 +01:00
Edward Nash
092a199757 Make Overlay.panIntoView an API method
* Add parameters for custom animation parameters and margin

 * Add protected wrapper method for previous autoPan functionality

See #10741
2020-03-12 08:57:32 +01:00
Andreas Hocevar
ac50cc3460 New eslint config with no-multi-assign 2019-11-02 15:20:21 +01:00
Frederic Junod
ea88e6cbd4 Remove invalid undefined type in params 2019-09-27 11:01:50 +02:00
Tim Schaub
b1f0b6997b Additional changes to work with user projection 2019-09-24 19:58:53 +02:00
Tobias Kohr
d4c1589a01 Seperate internal and API methods for the map 2019-09-24 17:58:56 +02:00
Tim Schaub
c03c359a20 Separate internal and API methods for the view 2019-09-21 11:30:14 -06:00
ahocevar
ebfb20440a Simplify events and store listeners only in one place 2019-09-04 16:48:43 +02:00
Frederic Junod
9c52e0d6d9 Remove extra imports in jsdoc
The symbols are already imported (es6 import)
2018-09-19 14:52:58 +02:00
Tim Schaub
ccfacc5ee6 Transformed types
Using the [ts.js codemod](https://gist.github.com/tschaub/1ea498c9d1e5268cf36d212b3949be4e):

    jscodeshift --transform ts.js src
2018-09-05 08:05:29 -06:00
Matthias Schiffer
321166849b Consistently use lowercase HTML tag names
Unlike HTML, XHTML is case-sensitive.
2018-08-18 12:48:14 +02:00
Tim Schaub
d12ef20b12 Use Array<Foo> instead of Array.<Foo> 2018-07-25 18:32:43 -07:00
Tim Schaub
e5493d1288 Add ol/pixel module for Pixel type 2018-07-19 10:17:00 -06:00
ahocevar
0f6ee28c19 Use extends and super for Overlay 2018-07-17 14:15:33 +02:00
Frederic Junod
f2d0b11d24 Move jsdoc constructor comments 2018-07-17 09:59:00 +02:00
Tim Schaub
7b4a73f3b9 Automated class transform
npx lebab --replace src --transform class
2018-07-16 16:18:16 -06:00
Frederic Junod
8c4c70e9f0 Change 'Element' type to 'HTMLElement' 2018-06-29 09:31:59 +02:00
ahocevar
28409486a5 Make classes in ol/ available as named exports from ol 2018-06-21 18:08:17 +02:00
Frederic Junod
26b47b7e3c Fix class name property in Overlay documentation
Fixes #4872
2018-06-19 08:55:09 +02:00
ahocevar
59d904e509 Fix some types 2018-04-27 09:30:51 +02:00
ahocevar
440d1ad3e1 Shorter module paths for default exports 2018-04-25 17:25:39 +02:00
ahocevar
417dd85f83 Fix some jsdoc path types 2018-04-21 10:17:53 +02:00