Commit Graph

46 Commits

Author SHA1 Message Date
crschmidt
c66f1ce360 Create a function -- OpenLayers.Util.getElement -- which replaces "$". This
should be used in all library code. This patch replaces all uses of "$()" in
existing code. The primary reason for this is to avoid conflicts with libraries
(like Prototype) which might redefine this function differently.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2541 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-08 20:14:03 +00:00
Tim Schaub
c12a92f938 clone listeners array before calling callbacks - see #464
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2164 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-01-19 19:41:51 +00:00
crschmidt
2467940cd3 A fix for #440. Prevent people who somehow get a null element in the event
cache from shooting themselves in the foot: This doesn't seem to happen often,
but it has happened in internal code. I'm going to add more debugging info to 
#440 as we get it, but want to get this in to prevent people from shooting 
themselves in the foot in IE accidentally.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2024 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-12-07 21:18:24 +00:00
crschmidt
786c2a20fb Change files to point to repository-license. Part of build process will now
be to change the licensing terms in the final build.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@1721 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-10-24 18:16:39 +00:00
crschmidt
da1984d764 Almost impossible to debug. element.offsets is cached (3x speedup -- a change
made in the early days of openlayers) but the cache means that relative mouse
positions are off if your first mouse event over the map is *after* the page is
scrolled. This closes #333 , and fixes a long standing not-well understood bug.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@1692 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-10-07 19:26:31 +00:00
crschmidt
781fbf1822 Event.Stop caused us to lose the ability to click on our permalink.
We like clicking on our permalink. bring that functionality back. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@1632 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-10-06 03:19:01 +00:00
Schuyler Erle
67ced536c0 Merged r1559:r1587 from source:/sandbox/crschmidt/noprototype. OpenLayers is now Prototype-free(tm).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1588 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-10-05 14:50:47 +00:00
euzuro
88ff0bc9af give our events model the option of allowing events to fall through so that they can be picked up in lower layers. change the panzoombar and the mousetoolbar to use this new fallthrough option so that we aren't causing bugs when the drag zoom rectangle gets dropped over them, they dont freak out. next up i am going to re-fix the popup events code to use this feature.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1468 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-09-14 20:25:23 +00:00
euzuro
8305808bee only prevent event from falling through if there are actually listeners registered. this fixes #247
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1423 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-09-08 21:31:42 +00:00
Schuyler Erle
e8bd5086df If Events finds a listener on a DOM element, call Event.stop so we don't fall through to other DOMelements.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1408 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-09-06 04:36:38 +00:00
crschmidt
ecdb77fa9c getMousePosition did not take into account page scrolling. This closes #211 .
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1385 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-08-26 15:55:41 +00:00
euzuro
c1b8c8dd60 change the '@require:' to '@requires' so as to be compatible with JSDOC standards. put these directly inside the class definition comment block. update script to suggest this and update all source files to follow pattern. Caught a missing @requires in the EventPane.js file
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1206 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-08-14 23:05:05 +00:00
Schuyler Erle
1726680b10 Separated out attachToElement() so that a single Events object can capture browser events from more than one object. Intended for use by Layer.EventPane.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1192 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-08-11 17:57:41 +00:00
euzuro
f339e3a93d hash -> hashtable and Hash -> Object -- let there be no confusion, we are *not* using prototype
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1144 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-08-09 04:36:39 +00:00
euzuro
0332bd09ec event -> Event
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1142 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-08-09 04:21:29 +00:00
euzuro
4ba3a290b8 change these alerts so as not to confuse ourselves when grepping for alerts to remove debugging code. :-)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@876 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-07-04 14:02:02 +00:00
euzuro
076632122b update triggerEvent() so that it doesnt bomb if user tries to trigger a non-enabled event. Added thorough testing.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@875 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-07-04 13:54:04 +00:00
euzuro
56472f15a0 protect unregister() from someone trying to unregister an un-enabled event. total extreme case, but whatever. added test.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@873 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-07-04 13:23:11 +00:00
euzuro
83eb0e1b34 do not let users register on an event that has not been specifically enabled at initialize. add test.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@872 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-07-04 13:18:16 +00:00
euzuro
585ec9e192 fix remove() function and add test
git-svn-id: http://svn.openlayers.org/trunk/openlayers@871 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-07-04 13:13:41 +00:00
euzuro
abac8a5d44 fixed functionality of unregister() function, added ability to pass null value for obj. Added tests.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@870 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-07-04 12:57:34 +00:00
euzuro
7d6f4dea78 changing functionality of Events.register(). Now if a null callback is passed in, no action is taken. If a null *obj* is passed in, however, the obj used is this.object (the Events Object's related object). Added tests to make sure this works.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@869 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-07-04 12:44:29 +00:00
euzuro
e59c5e08f3 once property is set, use it instead of the argument.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@867 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-07-04 11:58:38 +00:00
euzuro
10cbef9274 since we can technically register events for any domelement, there is no reason this variable should be named 'div'. Change it to 'element' and update its use everywhere.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@866 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-07-04 11:57:18 +00:00
euzuro
994e00ad20 add more complete comment to register function, sort of explaining binding.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@865 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-07-04 11:42:20 +00:00
euzuro
5544bbf134 adding commenting/readability to initialize()
git-svn-id: http://svn.openlayers.org/trunk/openlayers@864 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-07-04 11:25:54 +00:00
euzuro
1301102b1a adding commenting/readability to triggerEvent()
git-svn-id: http://svn.openlayers.org/trunk/openlayers@863 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-07-04 11:18:06 +00:00
euzuro
9746ac23fe adding comments, coding standards, jsdoc
git-svn-id: http://svn.openlayers.org/trunk/openlayers@862 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-07-04 11:10:27 +00:00
euzuro
2bea4fed77 jsdoc
git-svn-id: http://svn.openlayers.org/trunk/openlayers@861 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-07-04 10:34:15 +00:00
Schuyler Erle
ead31f6dc6 Added license headers to all JS source files.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@657 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-06-21 15:22:48 +00:00
Schuyler Erle
55937eeb1f Refactored event handling to allow unregistration of event listeners.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@570 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-06-12 00:16:02 +00:00
crschmidt
c9e6fbe3fa r1114@creusa: crschmidt | 2006-06-05 09:56:11 -0400
Small change to events.js to set div on evt so that registered handlers can get ahold of it without using cross-browser stuff.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@508 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-06-05 13:49:56 +00:00
crschmidt
1f89f13fb5 Adding events to map while dragging in the zoombar, then removing them afterwards. This neccessitated adding a 'remove' to Events, to pop events off the end. No more problems with dragging off into the map accidentally.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@388 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-26 02:17:43 +00:00
crschmidt
213a1b02d1 A couple changes got rolled into r326 that weren't meant to: Rolling them back out.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@327 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-24 17:38:27 +00:00
crschmidt
c0ec7f9a00 Change @require to @require:
git-svn-id: http://svn.openlayers.org/trunk/openlayers@326 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-24 17:17:22 +00:00
Schuyler Erle
b4f7d528d0 Always disable dragstart in IE on Events objects, so that mousedown/move/up works normally.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@310 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-24 03:43:34 +00:00
crschmidt
be6ecf5dca Store div offsets in event div object, caching them until a updateSize call. This provides a significant performance gain in places where the div contains hundreds or thousands of markers, because as the div element gets bigger, determining its size through Prototype.element.page() becomes slower by a factor of up to 4 (determined through profiling with venkman).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@271 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-22 18:11:45 +00:00
crschmidt
0fd94a3f21 Fix typo.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@264 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-22 16:18:35 +00:00
Schuyler Erle
0cc4aa316d Set up a resize event listener to call map.updateSize() as necessary.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@262 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-22 14:08:15 +00:00
crschmidt
e843291bce fix failing test in test_Marker: Events.js should not loop through a null eventTypes var.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@137 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-18 12:29:27 +00:00
Schuyler Erle
ce6c4acd63 Made Events class more generic; the Events constructor now takes a list of supported application event types. Added tests for the Events class.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@61 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-16 21:48:56 +00:00
euzuro
d20e764172 JSAN commenting
git-svn-id: http://svn.openlayers.org/trunk/openlayers@36 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-16 17:05:43 +00:00
euzuro
3cb109fe70 if the triggerMapEvent takes a variable 'type', which is coming directly from evt.type, then we might as well keep things consistent and use it in our register function as well
git-svn-id: http://svn.openlayers.org/trunk/openlayers@35 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-16 17:04:52 +00:00
euzuro
a9b696d000 JSAN commenting
git-svn-id: http://svn.openlayers.org/trunk/openlayers@34 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-16 16:54:27 +00:00
crschmidt
f2fa6622f1 Change "OpenLayers.Point" to OpenLayers.Pixel, so there's no confusion between LatLon and Point (a problem that has
and still does afflict the Google Maps API).


git-svn-id: http://svn.openlayers.org/trunk/openlayers@19 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-12 22:59:47 +00:00
Schuyler Erle
04ba28f5a4 Revised directory structure (js/ -> lib/, test/ -> tests/) to match JSAN distribution standards, as documented at http://www.openjsan.org/documentation/dists.html.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-12 21:15:53 +00:00