Commit Graph

61 Commits

Author SHA1 Message Date
Maximilian Krög
1ae1ff26a0 Initialize variable before use in FullScreen control
isInFullscreen_ was not initialized in the constructor when setClassName_
is called.

- Only remove the unnecessary classes when state changes instead of removing
  all and then adding the necessary classes again
2022-03-04 20:08:02 +01:00
Alan Moffat
87d87a155a Ensure FullScreen button has classname set on render.
When the FullScreen icon is first rendered, the button within it is not having the inactive classname set. The class name is set on toggling fullscreen on/off - just not being set on render.
2022-03-04 11:13:02 +00:00
EvertEt
15de4bb5ab Improve some nullable map types
Closes #13326
2022-02-04 17:05:52 +01:00
Maximilian Krög
12de93b397 Fixed unusable overlay in fullscreen mode 2021-11-02 22:10:27 +01:00
Maximilian Krög
9a6bb4d751 Fix FullScreen state when changing target in fullscreen mode 2021-11-02 00:21:11 +01:00
Maximilian Krög
5149224354 Improve code and its formatting 2021-11-02 00:21:11 +01:00
Maximilian Krög
770f53b5e3 Make FullScreen control work in external window 2021-11-02 00:21:10 +01:00
Matthijs Bon
72cb135aff Update typeDefs for labelActive
Add description that 'span' element can be used and add HTMLElement as type
2021-10-12 11:29:35 +02:00
Matthijs Bon
4cbf04d029 Update typeDefs for Fullscreen Options
Remove line stating that a 'span' is also a valid inactiveClassName value.
2021-10-11 14:48:04 +02:00
Matthijs Bon
6bc8d0cd96 Fix typeDef for label
Allow string, Text and HTMLElement, instead of only string and HTMLElement
2021-10-11 10:11:44 +02:00
Matthijs Bon
d4bc7d3f39 Update typeDefs for Attribution and Control
For consistency with docs, update type for labels to {string|HTMLElement}
2021-10-11 10:05:47 +02:00
Simon Seyock
ce4f6ccb0d OnSignatures return more specific type 2021-09-10 16:11:38 +02:00
Andreas Hocevar
e9e664f3c9 Add typed signature for Observable#un() 2021-07-10 11:28:50 +02:00
Simon Seyock
d914006d51 Add signatures for once. 2021-07-10 11:28:49 +02:00
Simon Seyock
1870a64984 Add CombinedOnSignature. 2021-07-10 11:28:49 +02:00
Simon Seyock
e9a161740a controls and interactions. 2021-07-10 11:28:48 +02:00
Simon Seyock
c8f43050c4 Revert "Merge pull request #12416 from ahocevar/eventtype-generics"
This reverts commit b6c143deb2, reversing
changes made to 7777821df5.
2021-07-10 11:28:46 +02:00
Andreas Hocevar
018ad97f25 Use generics to limit event types in on(), once() and un() 2021-06-20 22:25:47 +02:00
Maximilian Krög
0d5d346bcd Update links to external resources 2021-02-08 19:40:05 +01:00
Simon Seyock
8facb252f1 Replace google closure syntax = with brackets around name 2021-02-03 14:06:02 +01:00
Mihai CAZACU
49f883664a fix comments 2020-08-06 21:30:10 +03:00
Mihai CAZACU
2a683a2672 format code 2020-08-06 21:27:13 +03:00
Mihai CAZACU
bd22d427ab add CSS class name support for full-screen button 2020-08-06 21:23:16 +03:00
Andreas Hocevar
e5167f4e12 Fix custom controls with user-provided element 2020-05-15 17:50:44 +02:00
Andreas Hocevar
2d38390e58 Do not rely on custom type overrides 2020-05-02 17:03:12 +02:00
Andreas Hocevar
7f6258dd0d Set pointerEvents style programmatically instead of relying on ol.css 2020-04-16 17:34:40 +02:00
Tim Schaub
054af09032 Make code prettier
This updates ESLint and our shared eslint-config-openlayers to use Prettier.  Most formatting changes were automatically applied with this:

    npm run lint -- --fix

A few manual changes were required:

 * In `examples/offscreen-canvas.js`, the `//eslint-disable-line` comment needed to be moved to the appropriate line to disable the error about the `'worker-loader!./offscreen-canvas.worker.js'` import.
 * In `examples/webpack/exapmle-builder.js`, spaces could not be added after a couple `function`s for some reason.  While editing this, I reworked `ExampleBuilder` to be a class.
 * In `src/ol/format/WMSGetFeatureInfo.js`, the `// @ts-ignore` comment needed to be moved down one line so it applied to the `parsersNS` argument.
2020-04-06 12:54:09 -06:00
Frederic Junod
706dd3c87c Remove all inheritDoc tags from src/ol/control 2020-04-03 07:52:51 +02:00
Frederic Junod
9a03ca8417 Dispatch enterfullscreen and leavefullscreen from the FullScreen control 2020-02-17 10:48:29 +01:00
ahocevar
ebfb20440a Simplify events and store listeners only in one place 2019-09-04 16:48:43 +02:00
Frederic Junod
e9ecea3bb7 Remove 'moz' prefix for the Full Screen API
Browser support: https://caniuse.com/#feat=fullscreen
2019-02-15 14:37:49 +01:00
ahocevar
9cfb46f7a4 Listen to all fullscreen event types 2018-12-20 08:39:24 +01:00
Frederic Junod
9ab201642c Simplify import path in ol/control/ 2018-11-05 16:26:45 +01:00
Antoine Abt
fc8ba24d3f Store button and correctly type it. 2018-10-23 11:02:43 +02:00
itjope
50f90cdf61 Preserve button class name list in full screen control on toggle 2018-10-12 11:37:43 +02:00
Frederic Junod
54cdaddf3a Don't use Chrome only ALLOW_KEYBOARD_INPUT param 2018-09-19 11:12:27 +02:00
Kevin Schmidt
4d26ab751d Add vendor-specific TS declarations for the Fullscreen API.
Fixes #8660.
2018-09-18 13:22:55 -06:00
Tim Schaub
ccfacc5ee6 Transformed types
Using the [ts.js codemod](https://gist.github.com/tschaub/1ea498c9d1e5268cf36d212b3949be4e):

    jscodeshift --transform ts.js src
2018-09-05 08:05:29 -06:00
Frederic Junod
2e60961700 Use 'HTMLElement' type instead of 'Element' in controls 2018-07-19 16:02:58 +02:00
Frederic Junod
f140ff368d Move jsdoc constructor comments for controls 2018-07-17 16:44:53 +02:00
ahocevar
b9f08c6a2a Use extends and super for control/FullScreen 2018-07-17 14:41:26 +02:00
Tim Schaub
7b4a73f3b9 Automated class transform
npx lebab --replace src --transform class
2018-07-16 16:18:16 -06:00
Frederic Junod
6da2e4cef4 More precise Event typing 2018-06-29 12:53:20 +02:00
ahocevar
28409486a5 Make classes in ol/ available as named exports from ol 2018-06-21 18:08:17 +02:00
ahocevar
440d1ad3e1 Shorter module paths for default exports 2018-04-25 17:25:39 +02:00
Frederic Junod
8a4d60192f Mark optional property with square brackets 2018-03-19 08:29:50 +01:00
Tim Schaub
2e0fd1c12d Module type for Control 2018-03-18 09:53:35 -06:00
Tim Schaub
5dcfa1137d Move FullScreenOptions to ol/control/FullScreen 2018-03-11 10:46:56 -06:00
Frederic Junod
2e34421c71 Use Element type instead of Node for an html element 2018-03-09 16:59:58 +01:00
Tim Schaub
2d46a15a3d Remove static methods from FullScreen 2018-02-18 22:38:05 -07:00