Commit Graph

51 Commits

Author SHA1 Message Date
Edward Nash
2b863793d0 Perform auto-pan when adding an Overlay to a Map
* Auto-pan settings currently only activate when the position of the
   Overlay is set and the Overlay is already on a Map.

 * The consequence of this is that creating an Overlay with position
   set and then adding to a Map results in no auto-pan being performed -
   it is necessary to first create the Overlay, then add to a Map and
   finally set the position in order for the Map to auto-pan.

 * This commit changes this behaviour so that the auto-pan settings are
   also considered when the map property of the Overlay is set and not
   only when the position property is set, leading to a more intuitive
   behaviour.

 * Fixes Issue #10843
2020-04-01 06:50:01 +02:00
Andreas Hocevar
f66b44068c Merge pull request #10800 from ejn/overlay-pan-into-view-10741
Make Overlay.panIntoView an API method
2020-03-31 23:19:38 +02:00
Edward Nash
2537da690a Add check that Position is set in panIntoView()
* If panIntoView is an API method, it may now be called when the
   position of the overlay has not yet been set.

 * Adds a check for a set position to the panIntoView() method,
   and removes the now unneccessary check in handlePositionChanged()
2020-03-30 07:15:03 +02:00
Edward Nash
b1b01cf943 Allow pan options supplied as autoPan
* Follow the suggestion from @ahocevar to use the existing
   autoPan constructor option instead of creating a new autoPanOptions
   option

 * Internally also store the autoPanOptions in autoPan
2020-03-30 07:12:52 +02:00
horsenit
03ea8911f6 Fix type checking for IE9 style.msTransform 2020-03-27 03:03:21 -04:00
horsenit
83a5cd63c6 Speed up Overlay element positioning using CSS translate() 2020-03-27 02:26:01 -04:00
Edward Nash
859bf338a2 Use Object for options to Overlay panIntoView
* animation and margin encapsulated in a single object to allow
   easier extension in future

 * Constructor options extended to allow single object for
   autoPan; separate options still allowed but deprecated

 * Protected fields for animation and margin replaced with single
   field
2020-03-13 10:12:14 +01:00
Edward Nash
022caae848 Document default margin in Overlay.panIntoView 2020-03-12 09:37:40 +01:00
Edward Nash
092a199757 Make Overlay.panIntoView an API method
* Add parameters for custom animation parameters and margin

 * Add protected wrapper method for previous autoPan functionality

See #10741
2020-03-12 08:57:32 +01:00
Andreas Hocevar
ac50cc3460 New eslint config with no-multi-assign 2019-11-02 15:20:21 +01:00
Frederic Junod
ea88e6cbd4 Remove invalid undefined type in params 2019-09-27 11:01:50 +02:00
Tim Schaub
b1f0b6997b Additional changes to work with user projection 2019-09-24 19:58:53 +02:00
Tobias Kohr
d4c1589a01 Seperate internal and API methods for the map 2019-09-24 17:58:56 +02:00
Tim Schaub
c03c359a20 Separate internal and API methods for the view 2019-09-21 11:30:14 -06:00
ahocevar
ebfb20440a Simplify events and store listeners only in one place 2019-09-04 16:48:43 +02:00
Frederic Junod
9c52e0d6d9 Remove extra imports in jsdoc
The symbols are already imported (es6 import)
2018-09-19 14:52:58 +02:00
Tim Schaub
ccfacc5ee6 Transformed types
Using the [ts.js codemod](https://gist.github.com/tschaub/1ea498c9d1e5268cf36d212b3949be4e):

    jscodeshift --transform ts.js src
2018-09-05 08:05:29 -06:00
Matthias Schiffer
321166849b Consistently use lowercase HTML tag names
Unlike HTML, XHTML is case-sensitive.
2018-08-18 12:48:14 +02:00
Tim Schaub
d12ef20b12 Use Array<Foo> instead of Array.<Foo> 2018-07-25 18:32:43 -07:00
Tim Schaub
e5493d1288 Add ol/pixel module for Pixel type 2018-07-19 10:17:00 -06:00
ahocevar
0f6ee28c19 Use extends and super for Overlay 2018-07-17 14:15:33 +02:00
Frederic Junod
f2d0b11d24 Move jsdoc constructor comments 2018-07-17 09:59:00 +02:00
Tim Schaub
7b4a73f3b9 Automated class transform
npx lebab --replace src --transform class
2018-07-16 16:18:16 -06:00
Frederic Junod
8c4c70e9f0 Change 'Element' type to 'HTMLElement' 2018-06-29 09:31:59 +02:00
ahocevar
28409486a5 Make classes in ol/ available as named exports from ol 2018-06-21 18:08:17 +02:00
Frederic Junod
26b47b7e3c Fix class name property in Overlay documentation
Fixes #4872
2018-06-19 08:55:09 +02:00
ahocevar
59d904e509 Fix some types 2018-04-27 09:30:51 +02:00
ahocevar
440d1ad3e1 Shorter module paths for default exports 2018-04-25 17:25:39 +02:00
ahocevar
417dd85f83 Fix some jsdoc path types 2018-04-21 10:17:53 +02:00
Frederic Junod
60ca330dce Rename constructor options typedef to 'Options' 2018-03-29 15:50:32 +02:00
Frederic Junod
f8d94bb998 Remove unnecessary public jsdoc annotation 2018-03-19 08:44:34 +01:00
Tim Schaub
25da233921 Adjust indent 2018-03-17 14:24:22 -06:00
Frederic Junod
87f09b34d3 Use 'module:ol/Overlay~OverlayPanOptions' instead of 'olx.OverlayPanOptions' 2018-03-13 16:13:43 +01:00
Frederic Junod
13da5ef01d Use 'module:ol/Overlay~OverlayOptions' instead of 'olx.OverlayOptions' 2018-03-13 16:11:56 +01:00
Tim Schaub
a69a1f3ff4 Coordinate type typo 2018-03-11 08:36:54 -06:00
Andreas Hocevar
95d6251dbb Get rid of olx.js and typedef.js typedefs for ol 2018-03-08 18:57:24 +01:00
Tim Schaub
4e6cf58de1 Remove static members from BaseObject 2018-02-25 08:49:28 -07:00
Frederic Junod
a8f4348add Fix parens grouping in typecasts 2018-02-15 08:44:35 +01:00
Tim Schaub
7e7631c42a Named exports from ol/events 2018-01-24 10:09:57 -07:00
Tim Schaub
ad62739a6e Use blocked scoped variables
In addition to using const and let, this also upgrades our linter config and removes lint (mostly whitespace).
2018-01-12 00:50:30 -07:00
Tim Schaub
24dd0ca924 Rename _ol_Object_ to BaseObject 2018-01-10 09:35:43 -07:00
Marc Jansen
a7c5897bdb Named exports from ol/css module 2017-12-19 11:38:56 +01:00
Frederic Junod
db69f0ae44 Rename _ol_Overlay_ to Overlay 2017-12-18 13:29:52 +01:00
Frederic Junod
8cae7abb3e Rename _ol_Overlay_.Property to Property 2017-12-18 13:29:52 +01:00
Frederic Junod
b1b9edb43d Rename _ol_OverlayPositioning_ to OverlayPositioning 2017-12-18 13:29:52 +01:00
Frederic Junod
3e262b4c6b Rename _ol_MapEventType_ to MapEventType 2017-12-18 10:50:52 +01:00
Frederic Junod
f6627c4d4e Named exports from ol/dom 2017-12-14 12:27:09 +01:00
Andreas Hocevar
c0c43bca84 Use named imports from extent 2017-12-13 14:05:42 +01:00
Tim Schaub
87295a74dd Use named exports from ol/index.js 2017-12-12 12:34:23 -07:00
Tim Schaub
7f47883c48 Transformed 2017-12-12 06:53:18 -07:00