ahocevar
9d6ce21109
Raise layer that's being modified
2013-04-27 21:46:22 +02:00
ahocevar
e5dc583d52
Also trigger beforefeaturemodified event in non-standalone mode
...
d2a32d5 accidently changed the number of assertions in the
test_selectFeature function, so the change in behavior that no
beforefeaturemodified event is called any more in non-standalone mode got
unnoticed: Before unhacking ModifyFeature, the SelectFeature control
called the beforeSelectFeature method directly. Now, without a built-in
SelectFeature control, we need to call it from the selectFeature method in
both standalone and non-standalone mode.
2013-04-09 23:16:30 +02:00
ahocevar
d2a32d5421
Simplifying and unhacking the ModifyFeature control
...
With two nested controls (DragFeature, SelectFeature), which - among
others - activated two OpenLayers.Handler.Feature instances, the
ModifyFeature control was fragile and hard to debug.
The issue that @iwillig, @bartvde and myself tried to track down was
that the two Feature handlers interfered with each other, making it hard
to select features on mobile devices, and causing points to jump during
dragging because of not updated last pixel positions.
With this refactoring, there are no more nested controls. All that's left
is a Drag handler. All tests pass. I had to remove one test that checked
for dragging of an unselected point while another was selected, because
now (and partially even before this change, thanks to the ugly drag
handler hack that is now removed) dragging a point will also select it,
saving the user an extra click.
2013-03-19 23:00:10 +01:00
fredj
6daecd677d
New createVertices option for Control.ModifyFeature
2012-02-09 14:12:52 +01:00
ahocevar
def2085915
vertexRenderIntent for all sketch modes.
...
Fixed whitespace from original patch.
p=mosesonline, r=me (closes http://trac.openlayers.org/ticket/3581 )
2012-01-23 14:39:06 +01:00
bartvde
c587865bb1
deleting a vertex does not set feature.modified, this is a regression since in OL 2.10 a WFS transaction would include all fields, but 2.11 is smarter in the sense that it filters out fields that have not changed in the Transaction XML, which in this case, i.e. deleting a vertex, results in no geometry in the WFS transaction, r=tschaub (pullup #3463 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@12248 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-08-15 16:26:34 +00:00
ahocevar
2293987d57
adding a feature.modified property, making the ModifyFeature control set it and the WFST format check for it so only modified attributes and a modified geometry need to be included in an Update transaction. r=bartvde ( closes #3400 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@12149 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-07-04 08:37:55 +00:00
pgiraud
f84f696e31
Adds the possibility to use a built version of OpenLayers for the tests, users simply have to add '?mode=build' in the run-tests.html url
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11162 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-21 10:10:25 +00:00
ahocevar
b30d35c615
making ModifyFeature control in standalone mode trigger the beforefeaturemodified event. r=bartvde ( closes #3009
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11146 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-18 15:25:41 +00:00
ahocevar
c8982cb99a
give Layer.Vector a vertexremoved event, to be fired e.g. by the ModifyFeature control. r=bartvde ( closes #3017 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11043 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-01-19 16:44:39 +00:00
ahocevar
da8766d9d6
give ModifyFeature control a vertexRenderIntent property. r=tschaub ( closes #2955 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@10938 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2010-12-01 19:40:17 +00:00
ahocevar
01d4330c81
In standalone mode, allow only dragging of sketch vertices or the point
...
selected for modification. Thanks tschaub for the improved patch.
r=tschaub (closes #2219 )
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9613 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-08-05 23:33:26 +00:00
ahocevar
8fdd423104
provide a standalone mode for the ModifyFeature control. Thanks tschaub
...
for the fix in deactivate() and the tests. r=tschaub (closes #2199 )
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9591 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-07-27 18:00:36 +00:00
ahocevar
976b4703b5
mocking up map in a different way so tests won't break with the new
...
class-based cursors.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9273 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-04-12 18:39:06 +00:00
Tim Schaub
2ab6c404e1
Adding the ability to change the aspect ratio of features while resizing with the modify feature control. Thanks for the patch rdewit! r=me ( closes #1975 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9150 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-03-31 21:36:11 +00:00
Tim Schaub
41670499b1
Adding vertexmodified, sketchmodified, and sketchcomplete events to the vector layer. These are triggered by the DrawFeature and ModifyFeature controls and let listeners know about newly drawn features and modified features. r=ahocevar ( closes #1904 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8835 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-02-05 17:38:20 +00:00
Tim Schaub
d5950d4b29
Draw and modify controls now set feature state. No longer do we need to check feature state in app code in cases where features are created or modified with these controls. r=elemoine,ahocevar ( closes #1833 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8382 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-16 18:26:39 +00:00
Éric Lemoine
7c0fadd14a
ModifyFeature makes SelectFeature control behave/become like ModifyFeature, patch=bjornharrtell,tschaub, r=tschaub,me ( closes #1741 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8302 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-07 08:46:02 +00:00
Tim Schaub
0d2760831d
Adding a test to show that we can stop feature modification from an event listener.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8282 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-05 17:44:51 +00:00
crschmidt
09b4073636
* Fixes to the Keyboard Handler to make it work better --
...
* drop keypress event (not used, registers as keydown in IE< which results
in double events)
* return evt instead of evt.keyCode || evt.charCode, so apps can do
whatever they like best
* adjust ModifyFeature to new API
* Adjust KeyboardDefaults to new API, and include a new set of keyCodes
in switch statement to catch more cases
* Include keyboard defaults test in list-tests.
Patch from tcoulter, work from Pedro Simonetti (See #1108 ), Paul Spencer,
myself. r=pagameba,me (Closes #1292 )
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7644 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-31 17:45:16 +00:00
Tim Schaub
6897c8ed4d
Adding a beforefeatureselected event to the vector layer events. If a listener returns false, the feature is not selected. The modify feature control now listens for beforefeatureselected and triggers beforefeaturemodified. If a listener returns false, feature modification never begins. r=elemione,ahocevar ( closes #1427 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7616 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 22:03:40 +00:00
Éric Lemoine
c2c23cb3f3
modify feature control must use silent:true when removing/destroying vertices, p=me, r=crschmidt ( closes #1562 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7614 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 20:26:13 +00:00
Éric Lemoine
bc56ec9afa
fix typo in modify feature test name (non-functional change)
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7162 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-05-13 20:48:24 +00:00
crschmidt
0244858054
bring back r6710 now that popup changes are in
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6719 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-31 05:03:49 +00:00
crschmidt
69ca5c7fdd
Revert r6710: The new popup coe is going to need to change tests, so this
...
needs to wait.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6711 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-31 02:12:03 +00:00
crschmidt
02bbd43687
Since we've now completed all the work that is including new tests in 2.6, move
...
tests around. (See #1387 )
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6710 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-31 01:57:38 +00:00