ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
2,509 Commits 5 Branches 232 Tags
9ce76eb21f16e9599f8b70e38cb1034e426abc22
Commit Graph

83 Commits

Author SHA1 Message Date
crschmidt
53b20137cb Finish pullups for RC2. 
#1498 Easily turning off/overriding default select and temporary intent
        styles
  #1501 GeoRSS format tests fail in Safari
  #1502 Events register method fails if listeners member is not an array
  #1503 panning off for odd-sized viewport
  #1504 doc review


git-svn-id: http://svn.openlayers.org/branches/openlayers/2.6@6835 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-04-09 17:58:44 +00:00
Éric Lemoine
ce321ccea3 dragging mode of modify feature control is broken. r=crschmidt,tschaub. (closes #1418) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6564 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-03-20 07:26:21 +00:00
crschmidt
2694905155 Fix mousewheeling on eventpane layers. r=tschaub (Closes #1438) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6556 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-03-19 20:53:59 +00:00
euzuro
bf97a6c0d2 be very very careful about how we deal with the wheel. only take action when over scrollable items or over the main map. all of this is explained in the ticket and patch it is really late and i dont feel like typing it again. basically, this puppy means that scrolling on controls or in popups will no longer zoom the map unwantedly. that is good. thank you cr5 and IRC for taking such care of me. (r=cr5) (Closes #1382) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6416 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-29 08:37:12 +00:00
Tim Schaub
323de7085b The click and hover handlers need to take care that the event they are handling doesn't get modified before the delayed listeners get called. Appears to only be a problem in IE. Thanks for the catch madair. r=crschmidt (closes #1393) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6414 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-29 07:30:34 +00:00
crschmidt
9bfd829512 Rollback patch from #1332, which broke feature creation. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6163 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-09 04:23:54 +00:00
crschmidt
60706fc3f9 Refactor Hanadler.Point cancel/finalize to just call a cleanup and pass a 
callback type, since otherwise they're the same thing. From sbenthall, r=me
(Closes #1332) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6154 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-09 00:49:38 +00:00
crschmidt
6f2a3598be Fix lots of EOL SSTyle line ending problems. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6131 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-08 19:51:55 +00:00
Tim Schaub
99f3fa0d26 By default, the click handler now has a zero pixelTolerance. This means we don't call click if the click includes a drag. Set pixelTolerance to null if you want click called with a drag. r=crschmidt (closes #1335) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6066 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-08 03:24:42 +00:00
crschmidt
ca5c08ee26 Fix typo in comments. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6011 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-06 23:52:39 +00:00
Frédéric Junod
911a2772a4 Opera version < 9.20 invert the wheelDelta value but version >= 9.20 don't. r=crschmidt (Closes #1193) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6004 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-06 15:34:16 +00:00
Éric Lemoine
cf87ffc26c Add properties stopClick, stopDown, and stopUp to the feature handler. If 
stopClick is true, clicks handled by the feature handler don't propagate to
other click listeners; otherwise handled clicks do propagate. The same kind of
rule applies to stopDown and stopUp. These properties default to true. Thanks
to Attila Csipa for expressing the need for this feature and cooking up the
first patch. r=tschaub. (closes #1266)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@5976 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-03 17:35:39 +00:00
Éric Lemoine
f9950ec389 This commit solves the following problem with the select feature control: if 
you create two select feature controls on the same vector layer, one with
hover:false that handles geometry type A only, and the other with hover:true
that handles geometry type B only, then if you click on a geometry of type A
and moves out of that geometry, the second control will unselect it. r=tschaub
(closes #1221)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@5975 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-03 17:20:39 +00:00
crschmidt
d597e4f9a9 Because onselectstart is null by default, our logic to set it and 
replace it was somewhat lacking. This changes the behavior such that 
using hte drag handler does not totally disable text selection in IE. 
Patch from Bart, r=me (Closes #906)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@5911 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-01-27 14:48:02 +00:00
Éric Lemoine
f053a4e0c8 Add hover handler. With this handler user-defined actions can be triggered as the mouse moves over the map and pauses. An example of use is send WMS/GetFeatureInfo requests. r=crschmidt,tschaub (closes #1255) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5746 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-01-15 12:54:47 +00:00
Tim Schaub
11c1ef3f68 The pixelTolerance check on the click handler only works if mousedown events get to the handler. This keeps the handler from failing in cases where mousedown is stopped and pixelTolerance is set. r=crschmidt (closes #1246) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5698 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-01-09 09:55:22 +00:00
Tim Schaub
5b31ee3c0a Giving the drag handler a stopDown property. Set this to true in the constructor options to let mousedown events propagate. r=crschmidt (closes #1247) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5697 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-01-09 09:50:21 +00:00
Éric Lemoine
21f2605b55 click handler's cachedEvent property isn't needed. r=tschaub. (closes #1252) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5676 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-01-07 23:49:59 +00:00
Tim Schaub
6791cf6086 Point, path, and poly handlers now clean up before calling callbacks. r=crschmidt (closes #1239) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5624 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-01-02 19:06:07 +00:00
crschmidt
09e0d3ec81 Update copyrights to 2008. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5614 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-01-01 08:14:55 +00:00
Tim Schaub
86116ddd73 Making feature handler call over and out callbacks just once per mouseover and mouseout (of a feature). r=elemoine (closes #1226) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5555 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-21 08:48:08 +00:00
Tim Schaub
33e313b059 Separating jsdoc style docs into their own block. The new NaturalDocs doesn't parse these mixed blocks, giving us no class descriptions with the two together. (closes #1229) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5553 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-21 08:28:09 +00:00
Tim Schaub
5babc73615 stop clicks on the point handler - this means no more clicks sneaking through while editing - if you wanted that behavior, speak up - r=crschmidt (closes #1020) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5523 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-20 03:02:54 +00:00
Éric Lemoine
6fb48c0cd7 Enables unselecting selected features by clicking outside any feature. This is the default mode of the modify feature control. If you want to use the old mode where a click on a selected feature unselects that feature, set the toggle option to true. If you really want the old mode and not have selected features be unselected when clicking outside any feature, set the clickout option to false. The patch also adds the properties toggleKey and multipleKey to the modify feature control. With these one can temporarily enable the toggle and multiple mode, respectively. See the select-feature.html example to see all this in action. Thanks to pvalsecc and tschaub for the great colloration on this. (closes #1137) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5506 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-19 11:09:44 +00:00
Éric Lemoine
dc2cc625f3 Do not call preFeatureInsert() and onFeatureInsert() callbacks when the modify feature control and the regular polygon handler internally adds point geometries to the layer. This is accomplished by adding an 'options' argument to the addFeatures() method in Layer.Vector. If that options argument has the silent property set to true, then the preFeatureInsert() and onFeatureInsert() callbacks aren't called. Thanks tschaub and fredj for your input. Thanks crschmidt for the final review. (closes #1148) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5470 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-17 14:36:39 +00:00
Tim Schaub
6ad22b8e6a adding a click handler for flexible cross-browser single and double click handling - add to a control and set click or dblclick callbacks - thanks for the review and pairing crschmidt (closes #1211) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5438 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-16 04:42:14 +00:00
crschmidt
7881c2099a When trying to deactivate a control from within that control's featureAdded 
event, a null exception is encountered. A null check fixes this bug. (Closes
#1143)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@5433 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-15 21:29:06 +00:00
crschmidt
5824170f10 Box Handler should use CSS to style its box. (Closes #1070) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5399 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-13 19:51:49 +00:00
Éric Lemoine
2f7fad80df Handler.Point doesn't render points if no default resolution props in map object. Thanks fredj for the review. (closes #1205) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5396 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-13 14:53:36 +00:00
Tim Schaub
ceecacfe3a adding irregular option to regular polygon control - now, go draw rectangles, and more - thanks for the review elem (closes #1098). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5200 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-11-15 23:37:36 +00:00
Tim Schaub
ba8354b593 Make the drag handler only call done if it actually dragged - thanks for the review Eric (closes #1118). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5097 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-11-01 20:53:06 +00:00
Éric Lemoine
756f6ca24d handlers have to check if layer exists before destroying it. Thanks pgiraud. (closes #1107) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5085 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-11-01 13:37:16 +00:00
Paul Spencer
3e9beffc99 large scale syntactic clean up adding missing semi-colons and curly braces around blocks. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5002 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-10-18 12:27:35 +00:00
crschmidt
ed3221441c Refactor SVN layout in compliance with RFC/LicenseChange. This hopefully 
completes an important blocker for moving forward with OSGeo incubation. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4985 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-10-17 02:21:22 +00:00
Tim Schaub
ad4044cd3b Make the drag handler tidy up after itself a bit more. This solves the click blocking after shift-drag issue (see #1003). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4400 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-19 21:01:04 +00:00
Tim Schaub
91fab27e7d Simplify click handling in the drag handler - this makes the sequence down, move, up a complete drag (see #982). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4354 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-17 19:25:26 +00:00
Tim Schaub
2337f9f2d8 Adding angle brackets to link class names in the docs (see #983). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4353 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-17 16:59:16 +00:00
Tim Schaub
2478677985 Deprecating all prototype extensions. This puts all OpenLayers functionality in the OpenLayers namespace. If you are using any of the Function, String, or Number prototype extensions, start using the functional equivalents in the OpenLayers namespace - the prototype extensions will be gone in 3.0 (closes #712). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4302 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-14 20:08:47 +00:00
crschmidt
d8ab004642 Remove class_name jsdoc for consistency, thanks fredj. (Closes #853) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4256 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-13 10:27:39 +00:00
crschmidt
024779d898 With review from elem and additional tests, add filter by geometry type 
to select feature control, with tests. (Closes #951)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4243 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-12 15:05:18 +00:00
Éric Lemoine
6f16455b1c select features on "click" as opposed to on "mousedown" (closes #891) 
thanks to all for the review and to crschmidt for updating the patch


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4241 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-12 14:25:34 +00:00
crschmidt
983618f2fa fix for 'map elements are selected in IE when using shift key' in drag 
handler from pierre.
Confirmed that this can be tested simply by using anything with a drag handler
in IE, so it will get caught in acceptance test. 
(Closes #792)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4230 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-12 04:18:59 +00:00
crschmidt
82c64254e5 Fix lacking code from #666-- I had originally wanted to add this, but couldn't 
craft a test which exposed the lack ... until i realized with pgiraud's help
that my test was backwards to begin with. (Closes #666)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4217 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-11 14:26:08 +00:00
Tim Schaub
35dae2bdb0 Adding a RegularPolygon handler for drawing squares, triangles, circles, etc. Demo in the regular-polygon.html example. Also adding a createRegularPolygon class method to the Polygon geometry class. Thanks to crschmidt for all the tests and help getting this in (closes #828). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4205 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-10 20:24:27 +00:00
Tim Schaub
cecf760f29 make the drag handler and drag feature control tidy up after themselves - as a bonus, give the drag feature control an onStart method. Thanks for the review crschmidt (closes #950). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4147 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-30 23:25:49 +00:00
Tim Schaub
c2148651ed Filling our log with cruft, adding meaningless conflicts for merges, and changing a comment style that ndocs could care less about, this commit changes Return to Returns (closes #945). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4110 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-29 18:44:10 +00:00
euzuro
b5ef77096c wiki/NaturalDocs says we should be using 'Return:' and not 'Returns:' so this patch is fixing that. Of course, in the process, I came across not a few instances where other ND related whitespace or typos were at odds with a peaceful, uniform OL codebase. No functional changes here, just makin' things pretty. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4109 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-29 18:08:32 +00:00
Tim Schaub
e5641c76e0 Fix deactivate and destroy methods on the keyboard handler. Add 28 tests for previously untested handler. Thanks to Erik for the quick review and comments - appreciated as always (closes #943). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4108 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-29 17:37:42 +00:00
Tim Schaub
eb65e9c2b3 natural docs comments for the keyboard handler 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4107 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-29 16:15:45 +00:00
crschmidt
46c5cd6812 Properly destroy OpenLayers.Handler.MouseWheel, patch from fredj. Added 
tests for it as well. (Closes #935)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4100 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-29 04:21:17 +00:00