ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
2,959 Commits 5 Branches 232 Tags
850d69a02fd66d5bbbd1e3e6f33312566dda8aad
Commit Graph

26 Commits

Author SHA1 Message Date
Tim Schaub
850d69a02f Take care not to handle features without a layer. These are typically destroyed features - but could be some other sort of miscreants. Thanks for the report igrcic. r=crschmidt (closes #1806). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8581 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2009-01-05 04:46:34 +00:00
Tim Schaub
b916be5489 The feature handler should not handle destroyed features. Or any features without a layer for that matter. r=elemoine (closes #1806) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8284 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-11-05 21:23:55 +00:00
ahocevar
2a521ffcb2 Made the Feature handler more robust to things that are related to changing layer order on the map, by registering an event handler that will bring the handler's layer back to the top of the layer stack in the DOM. Contains a manual test. r=elemoine (closes #1628) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7879 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-08-27 14:02:21 +00:00
crschmidt
72bf882b62 Controls should (by definition within OL) stop downs (if they care) and allow 
ups to propogate. The default behavior of the Feature handler broke this rule,
and as a result, some aspects of ragging a box control failed when letting
go over a feature. This corrects the behavior. r=ahocevar. (Closes #1293) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7873 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-08-26 23:35:31 +00:00
crschmidt
cdd4c864ea Flipped a return value here; this should be 'true', not 'false'. (See #1655) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7683 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-08-03 12:24:18 +00:00
crschmidt
693e6d07e3 Fix for Feature handler uses getFeatureFromEvent on mousemove even without 
hover callbacks; r=ahocevar (Closes #1655) 

This means that On the SelectFeature control hover can no longer be set on the
SelectFeature control after the control has been initialized: must be passed at
initialize time. Example has been updated. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7682 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-08-03 02:06:31 +00:00
Éric Lemoine
ce321ccea3 dragging mode of modify feature control is broken. r=crschmidt,tschaub. (closes #1418) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6564 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-03-20 07:26:21 +00:00
Éric Lemoine
cf87ffc26c Add properties stopClick, stopDown, and stopUp to the feature handler. If 
stopClick is true, clicks handled by the feature handler don't propagate to
other click listeners; otherwise handled clicks do propagate. The same kind of
rule applies to stopDown and stopUp. These properties default to true. Thanks
to Attila Csipa for expressing the need for this feature and cooking up the
first patch. r=tschaub. (closes #1266)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@5976 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-03 17:35:39 +00:00
Éric Lemoine
f9950ec389 This commit solves the following problem with the select feature control: if 
you create two select feature controls on the same vector layer, one with
hover:false that handles geometry type A only, and the other with hover:true
that handles geometry type B only, then if you click on a geometry of type A
and moves out of that geometry, the second control will unselect it. r=tschaub
(closes #1221)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@5975 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-03 17:20:39 +00:00
crschmidt
09e0d3ec81 Update copyrights to 2008. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5614 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-01-01 08:14:55 +00:00
Tim Schaub
86116ddd73 Making feature handler call over and out callbacks just once per mouseover and mouseout (of a feature). r=elemoine (closes #1226) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5555 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-21 08:48:08 +00:00
Tim Schaub
33e313b059 Separating jsdoc style docs into their own block. The new NaturalDocs doesn't parse these mixed blocks, giving us no class descriptions with the two together. (closes #1229) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5553 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-21 08:28:09 +00:00
Éric Lemoine
6fb48c0cd7 Enables unselecting selected features by clicking outside any feature. This is the default mode of the modify feature control. If you want to use the old mode where a click on a selected feature unselects that feature, set the toggle option to true. If you really want the old mode and not have selected features be unselected when clicking outside any feature, set the clickout option to false. The patch also adds the properties toggleKey and multipleKey to the modify feature control. With these one can temporarily enable the toggle and multiple mode, respectively. See the select-feature.html example to see all this in action. Thanks to pvalsecc and tschaub for the great colloration on this. (closes #1137) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5506 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-19 11:09:44 +00:00
crschmidt
ed3221441c Refactor SVN layout in compliance with RFC/LicenseChange. This hopefully 
completes an important blocker for moving forward with OSGeo incubation. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4985 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-10-17 02:21:22 +00:00
crschmidt
024779d898 With review from elem and additional tests, add filter by geometry type 
to select feature control, with tests. (Closes #951)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4243 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-12 15:05:18 +00:00
Éric Lemoine
6f16455b1c select features on "click" as opposed to on "mousedown" (closes #891) 
thanks to all for the review and to crschmidt for updating the patch


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4241 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-12 14:25:34 +00:00
Tim Schaub
c2148651ed Filling our log with cruft, adding meaningless conflicts for merges, and changing a comment style that ndocs could care less about, this commit changes Return to Returns (closes #945). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4110 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-29 18:44:10 +00:00
euzuro
b5ef77096c wiki/NaturalDocs says we should be using 'Return:' and not 'Returns:' so this patch is fixing that. Of course, in the process, I came across not a few instances where other ND related whitespace or typos were at odds with a peaceful, uniform OL codebase. No functional changes here, just makin' things pretty. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4109 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-29 18:08:32 +00:00
crschmidt
c2c821e4c2 DragFeature test Broken in IE6. The tests all passed because this only caused 
problems on destroy()/page unload, after all the tests had been run. Thanks 
for the review, tschaub. (Closes #923.)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4035 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-24 22:07:18 +00:00
crschmidt
6194452b8a Since John already went ahead and committed the main change, I'm just going 
to finish this one up. All commits are in comments, so a review doesn't seem
strictly neccesary. This closes #918 and fixes all the copyrights that I could 
find in the code.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3984 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-23 11:29:06 +00:00
euzuro
cf5a53959e ND Update: make array's say what they're made of, and a few other small bits, like mistyped and a couple missing <>s 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3829 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-31 20:02:03 +00:00
euzuro
fd4d2918f1 fix for #853 - remove JSDOC comments from CLASS_NAME variables 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3787 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-23 15:09:09 +00:00
Tim Schaub
cc1b0269c9 #823 New class style. Instead of OldStyle = Class.create(); OldStyle.prototype = Class.inherit(Parent, prototype), we now use NewStyle = OpenLayers.Class(Parent, prototype). New style classes allow for backwards compatibility [you can use OldStyle = Class.create(); Class.inherit(NewStyle, prototype)]. The Class.create and Class.inherit functions are deprecated. Backwards compatibility will be removed at 3.0. Thanks Erik for the careful review. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3767 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-16 20:25:11 +00:00
crschmidt
3948913bfc Merge all changes from the naturaldocs sandbox. This brings all the work that 
has been done in the NaturalDocs branch back to trunk. Thanks to everyone who
helped out in making this happen. (I could list people, but the list would
be long, and I'm already mentally on vacation.)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3545 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-06-29 15:59:20 +00:00
Tim Schaub
645bff1286 #628 - a feature has a geometry - a geometry doesn't have a feature - features are rendered, selected, moved, modified, etc - down in the renderer, expando properties on nodes are limited to _featureId, _style, and _options - this removes expandos that created circular references back through the map and to other dom elements - when the renderer is involved in selecting features, it returns a featureId (instead of a geometry or feature) and the layer is responsible for fetching the appropriate feature 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3043 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-04-10 16:07:56 +00:00
Tim Schaub
0c8dcabce8 replacing the select handler with a feature handler - with support for up, down, over, out, and move callbacks associated with mouse events on a feature - the select-feature.html example shows the use of a control that activates the feature handler - see #544 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2843 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-03-21 23:30:20 +00:00