Commit Graph

304 Commits

Author SHA1 Message Date
Éric Lemoine
7c0fadd14a ModifyFeature makes SelectFeature control behave/become like ModifyFeature, patch=bjornharrtell,tschaub, r=tschaub,me (closes #1741)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8302 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-07 08:46:02 +00:00
Tim Schaub
b916be5489 The feature handler should not handle destroyed features. Or any features without a layer for that matter. r=elemoine (closes #1806)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8284 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-05 21:23:55 +00:00
Tim Schaub
0d2760831d Adding a test to show that we can stop feature modification from an event listener.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8282 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-05 17:44:51 +00:00
euzuro
01682a6da7 Fixing erroneously set default for right-click handlers. Thanks to senior schmidt for pointing out this oversight on my part, and for the quick reviw. (Pullup #1735)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8021 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-09-16 16:23:43 +00:00
euzuro
0fbc6c2500 Fix for Permalink's override-able createParams() function, which was designed to allow for input parameter values for center, zoom, and layers... but was actually only using the center value... zoom and layers were being taken from the map and the input parameters ignored. Big thanks to our anonymous poster for spotting this. r=ahocevar (Pullup #1489)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7986 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-09-09 15:53:09 +00:00
ahocevar
8f1b84a8e1 To test real-life conditions, we cannot just use a bogus function to deactivate the control. (closes #1710)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7893 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-29 09:27:29 +00:00
ahocevar
59826983c6 made permalink control more configurable by adding an argParserClass property and separating the logic for generating the key-value pairs from the div and link generation. Original patch by tcoulter. r=euzuro,me (closes #1489)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7881 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-27 19:33:49 +00:00
Frédéric Junod
f086ba17b4 keep the cursor style to 'move' if the cursor is above a feature. r=elemoine (closes #1673)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7713 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-08 13:34:59 +00:00
crschmidt
e7ebdc8aa0 Non unique HTMLElement in Control, fix put together by sbenthall.
Tests pass, etc. (Closes #1396) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7666 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-01 18:21:56 +00:00
crschmidt
09b4073636 * Fixes to the Keyboard Handler to make it work better --
* drop keypress event (not used, registers as keydown in IE< which results
      in double events) 
    * return evt instead of evt.keyCode || evt.charCode, so apps can do
      whatever they like best
 * adjust ModifyFeature to new API
 * Adjust KeyboardDefaults to new API, and include a new set of keyCodes
    in switch statement to catch more cases
 * Include keyboard defaults test in list-tests.

Patch from tcoulter, work from Pedro Simonetti (See #1108), Paul Spencer,
myself. r=pagameba,me (Closes #1292)   


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7644 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-31 17:45:16 +00:00
Tim Schaub
6897c8ed4d Adding a beforefeatureselected event to the vector layer events. If a listener returns false, the feature is not selected. The modify feature control now listens for beforefeatureselected and triggers beforefeaturemodified. If a listener returns false, feature modification never begins. r=elemione,ahocevar (closes #1427)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7616 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 22:03:40 +00:00
Éric Lemoine
c2c23cb3f3 modify feature control must use silent:true when removing/destroying vertices, p=me, r=crschmidt (closes #1562)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7614 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 20:26:13 +00:00
Tim Schaub
9d72a9bdce more less troublesome ie naming
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7604 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 04:10:50 +00:00
Tim Schaub
15a787c5ba test name for ie better
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7603 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 04:08:19 +00:00
Tim Schaub
309877a48c Adding a featureadded event to the draw feature control event types. First tests ever for the draw feature control. Thanks sbenthall for the patch. r=me (closes #1508)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7601 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 03:41:22 +00:00
ahocevar
d41b6afec4 set center and baselayer in test_box, so we have the correct environment to do the actual test.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7598 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 01:19:21 +00:00
crschmidt
8c59d55658 Redraw control.panel when toggle controls are activated. Patch by
sbenthall (yay), r=me, (Closes #895) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7597 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 00:40:32 +00:00
Tim Schaub
27ce7fe099 Removing phantom array.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7595 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 00:35:13 +00:00
Tim Schaub
a88ad8dc50 Adding a box property to the SelectFeature control for selecting all features within a box. p=pgiraud, r=me,crschmidt (closes #1071)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7589 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-29 18:20:19 +00:00
pgiraud
4340867918 add a map getUnits method, r=ahocevar (Closes 1591)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7374 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-06-18 08:57:02 +00:00
Éric Lemoine
e02e7504c5 MousePosition: numDigits inconsistency, reported by kthy, patch by kthy, additional test by me, r=me (closes #1544)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7163 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-05-13 20:52:01 +00:00
Éric Lemoine
bc56ec9afa fix typo in modify feature test name (non-functional change)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7162 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-05-13 20:48:24 +00:00
crschmidt
1b269f06f8 2.6 accidentally broke behavior when clicking on the panzoombar. Thanks to Linda Rawson's report of this issue, this is now fixed, by moving the Math.floor call to a different part of the code. r=euzuro (Pullup #1486)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6799 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-04-07 04:08:33 +00:00
euzuro
3e348f450e fix up tests, remove _01_. (Closes #1387)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6724 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-31 05:31:28 +00:00
crschmidt
ce1e4d81ea Another bad location
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6722 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-31 05:14:16 +00:00
crschmidt
0244858054 bring back r6710 now that popup changes are in
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6719 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-31 05:03:49 +00:00
crschmidt
69ca5c7fdd Revert r6710: The new popup coe is going to need to change tests, so this
needs to wait.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6711 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-31 02:12:03 +00:00
crschmidt
02bbd43687 Since we've now completed all the work that is including new tests in 2.6, move
tests around. (See #1387) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6710 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-31 01:57:38 +00:00
euzuro
136a37bf2f replacing tabs with spaces. no functional diffs here.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6673 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-29 00:38:47 +00:00
Paul Spencer
19da92a321 Re #1451. Re #1456. Change the way ScaleLine respectZoom is tested to test if the maxWidth of the control is respected at all zoom levels with two separate map units and with a custom maxWidth value.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6580 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-24 13:17:34 +00:00
crschmidt
0da40191ec Rolling back patch from #751: this broke IE when used (destroy tries to
destroy slider even though it was never created). Thanks to the tests we
caught it, but this patch needs reworking.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6516 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-13 13:44:09 +00:00
crschmidt
9b1cf1ef01 showPan & showZoomBar options in control PanZoomBar, to turn off the
various chunks. In the future, we'll use this to have a single control 
integrating panzoom and panzoombar, but not quite yet. Revamped patch 
from kkempfer (thx!) with tests. r=me (Closes #754)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6514 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-13 04:20:53 +00:00
crschmidt
d0b4a17116 Add improved navigation control support for disabling zooming with the
mousewheel. Original from sbenthall (yay), example and more code from me, tests
from elem. r=elemoine.  (Closes #1339)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6462 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-07 23:04:32 +00:00
Frédéric Junod
8b91ee8d64 Send events when modifying features:
'beforefeaturemodified' triggered when a feature is selected to be modified,
  'featuremodified' triggered when a feature has been modified,
  'afterfeaturemodified' triggered when a feature is finished being modified

r=tschaub (Closes #1358)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6413 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-29 06:50:39 +00:00
ahocevar
c5dd8ada2c "users should be able to customize the select style per feature": Created a !StyleMap class which stores all styles that are needed for a layer. Controls that need to render features differently can now just give a render intent (e.g. "default", "select" or "temporary") to the layer's drawFeature method, instead of having extra style informations like Control.!SelectFeature.selectStyle. Existing application that set layer.style or feature.style are still supported, but both of these style properties are now null by default. r=crschmidt,elemoine,tschaub (closes #1120)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6240 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-12 23:05:47 +00:00
Tim Schaub
db77398339 Thanks Ian Mayo for this nice ScaleLine control. Give your maps a dualie scale line control customizable with CSS. r=crschmidt (closes #1089)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6177 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-09 19:39:12 +00:00
Tim Schaub
bf224d699d Giving all controls an events instance. You can now listen for activate and deactivate on any control. Panel controls do this to know when they should redraw. Navigation history control demonstrates the effect of this change. r=elemoine (closes #1346)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6167 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-09 16:46:02 +00:00
Tim Schaub
c52ed952d8 Add navigation history control. This control creates two obligate controls: next and previous. Calling trigger on the next and previous controls steps through the navigation history. r=crschmidt,ahocevar,pgiraud (closes #1240)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6157 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-09 01:27:45 +00:00
Tim Schaub
f27833f1db Trigger feature related events with feature information and layer related events with layer information. Also adding events.on and events.un convenience methods. r=crschmidt (closes #1343)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6149 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-08 23:31:27 +00:00
crschmidt
bb26a2601d Add support for animated panning, with most of the work done by Pierre, thx pierre! panTo method now animates when moving. (Closes #110)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6111 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-08 16:28:11 +00:00
Tim Schaub
49e0bff93d For controls with multiple handlers, we now tack them on to a handlers object. The base destroy takes care of the handlers. r=crschmidt,uz/2 (closes #1338)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6106 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-08 15:52:03 +00:00
Tim Schaub
8d5d8f6d94 Just because I had it open and was looking at 952, I'm shortening test names. (see #952)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6006 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-06 19:46:22 +00:00
euzuro
672d3c4eed give the navigation control a proper destroy and also give it a test file while we're at it. (Closes #1289)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5990 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-05 06:34:20 +00:00
Éric Lemoine
3acc19ae3d The modify feature control destroys the vertex that was dragged in the drag
complete callback. Thus, the drag feature control won't detect a mouse-out on
that vertex and won't deactivate its drag handler. This causes errors because
the drag feature control has a feature to drag but that feature is destroyed
(feature.geometry is null). To prevent this, we make resetVertices explicitely
call outFeature on the drag feature control if the control has a feature to
drag. tschaub did most of the investigation on the problem. r=tschaub,me
(closes #1235)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@5974 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-03 17:10:03 +00:00
Tim Schaub
9bb51fb088 Taming the select feature control a bit. Previously, onUnselect was called twice for every unselection. r=elemoine (closes #1234)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5959 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-01 16:42:33 +00:00
crschmidt
ea5e96df85 Add support to set the 'title' property of a control such that it will
be displayed when hovering over the control in a control.panel via its 
panel_div. r=me (Closes #822)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@5910 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-27 14:44:16 +00:00
ahocevar
45d5fdfd06 SelectFeature and OpenLayers.Feature.Vector.style["select"]: changed Control.SelectFeature to inherit properties that are not set in selectStyle from feature.style. r=tschaub (closes #1260)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5896 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-25 23:13:57 +00:00
crschmidt
81505f54b0 Add generic 'button' control. r=tschaub. (Closes #872)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5870 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-24 03:16:42 +00:00
Tim Schaub
9193ef67d5 Gutting the OverviewMap control to give it an update. Now uses a click handler and a drag handler instead of its own event handling code. In addition, the control now has a minRecSize property. When the extent rectangle is smaller than the specified size, its style is switched. By default, we provide a rectangle replacement graphic. This can be customized with CSS. Finally, I'm tucking in one non-API property. The dragging arg sent to map.setCenter is now stored at map.dragging. This gives easy reference to dragging state where a reference to the navigation control and its drag handler is not convenient. r=pspencer (closes #1244)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5674 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-07 20:54:28 +00:00
Tim Schaub
d7cd93abf3 If your browser doesn't support the script tag, you have no business running these tests.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5658 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-06 22:10:28 +00:00