Commit Graph

374 Commits

Author SHA1 Message Date
Frédéric Junod
f086ba17b4 keep the cursor style to 'move' if the cursor is above a feature. r=elemoine (closes #1673)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7713 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-08 13:34:59 +00:00
crschmidt
693e6d07e3 Fix for Feature handler uses getFeatureFromEvent on mousemove even without
hover callbacks; r=ahocevar (Closes #1655) 

This means that On the SelectFeature control hover can no longer be set on the
SelectFeature control after the control has been initialized: must be passed at
initialize time. Example has been updated. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7682 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-03 02:06:31 +00:00
crschmidt
64fc4fcb1b Patch from funky_c to move all alert()s in the library to a single
OpenLayers.Console.userError function. This allows for easy overriding of this
function for people who need to report errors at an application level (or
hiding these errors entirely), with the same default behavior as previous
releases. Patch from funky_c, r=me, (Closes #1651)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7675 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-01 22:21:50 +00:00
crschmidt
e7ebdc8aa0 Non unique HTMLElement in Control, fix put together by sbenthall.
Tests pass, etc. (Closes #1396) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7666 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-01 18:21:56 +00:00
crschmidt
09b4073636 * Fixes to the Keyboard Handler to make it work better --
* drop keypress event (not used, registers as keydown in IE< which results
      in double events) 
    * return evt instead of evt.keyCode || evt.charCode, so apps can do
      whatever they like best
 * adjust ModifyFeature to new API
 * Adjust KeyboardDefaults to new API, and include a new set of keyCodes
    in switch statement to catch more cases
 * Include keyboard defaults test in list-tests.

Patch from tcoulter, work from Pedro Simonetti (See #1108), Paul Spencer,
myself. r=pagameba,me (Closes #1292)   


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7644 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-31 17:45:16 +00:00
Tim Schaub
66a4c6fb0e Caching array length instead of accessing it with each iteration. r=crschmidt (closes #1636)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7627 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-31 04:44:25 +00:00
Tim Schaub
6897c8ed4d Adding a beforefeatureselected event to the vector layer events. If a listener returns false, the feature is not selected. The modify feature control now listens for beforefeatureselected and triggers beforefeaturemodified. If a listener returns false, feature modification never begins. r=elemione,ahocevar (closes #1427)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7616 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 22:03:40 +00:00
crschmidt
61c528f3af Change getMousePosition to only be called automatically *if* the 'includeXY'
flag on the Events object is set to true. This ends up meaning that we save a
lot of unneccesary getMousePosition calls because (for example) the layer
doesn't need to include the .xy property. In addition, we add in speed
improvements via caching to the getMousePosition, courtesy the work from
pgiraud (which was worked on further by tcoulter) -- this results in
significantly improved getMousePosition performance improvements in 'real life'
situations that are more like the cases that people use OpenLayers, with a
higher number of containing divs (and also clearly demonstrate a gain in
performance even in the simple case.)

The end result is: 
 * In typical map movement over the map, (n / n+1) fewer calls to
   getMousePosition, where n is the number of active layers when dragging over
   the map.
 * In the simple case, 40% faster getMousePosition performance -- and in 
   more complex cases, significantly more performance improvements.

To drop the former improvement, which may affect some applications (as
described in the includeXY documentation) simply set:

  OpenLayers.Events.prototype.includeXY = true;

This will restore the 'every element has an xy property always' behavior
that was the case beore this patch. 

r=me,tschaub, work by pgiraud related to (See #1509), and (Closes #1459)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7615 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 21:23:19 +00:00
Éric Lemoine
c2c23cb3f3 modify feature control must use silent:true when removing/destroying vertices, p=me, r=crschmidt (closes #1562)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7614 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 20:26:13 +00:00
euzuro
eb417ff61c adding types to properties from the mousing improvements patch. No functional change, only documentation. (See #1509)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7612 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 18:40:23 +00:00
crschmidt
bc06972aea patch for improved mousedragging. We were able to test this on my eeepc
and get a very obvious speedup in performance. This adds a configurable
'interval' to the dragpan control (and an interval to the 'drag' control,
defaulting to 0px). Patch put together by tcoulter. (Closes #1509) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7608 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 16:27:48 +00:00
Tim Schaub
309877a48c Adding a featureadded event to the draw feature control event types. First tests ever for the draw feature control. Thanks sbenthall for the patch. r=me (closes #1508)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7601 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 03:41:22 +00:00
crschmidt
8c59d55658 Redraw control.panel when toggle controls are activated. Patch by
sbenthall (yay), r=me, (Closes #895) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7597 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 00:40:32 +00:00
Tim Schaub
a88ad8dc50 Adding a box property to the SelectFeature control for selecting all features within a box. p=pgiraud, r=me,crschmidt (closes #1071)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7589 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-29 18:20:19 +00:00
Frédéric Junod
f8bf59445c Use css sprites technique to simplify the NavigationHistory controls. r=tschaub. (Closes #1555)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7422 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-06-23 06:56:58 +00:00
crschmidt
6135c8daab several minor coding standards changes. no functional change.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7396 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-06-20 11:56:17 +00:00
crschmidt
c2b892acb9 Committed in wrong directory; this was meant to go to the sandbox. Reverting with
'svn merge -r 7381:7380 .'


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7382 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-06-19 18:45:22 +00:00
crschmidt
b78e26e9f0 break out post-rendering into seperate function to be defined in page. This
removes the tie between the LayerSwitcher and Ext that I had in my first
commit. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7381 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-06-19 18:44:25 +00:00
pgiraud
4340867918 add a map getUnits method, r=ahocevar (Closes 1591)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7374 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-06-18 08:57:02 +00:00
Tim Schaub
a98aacedd2 Adding px units where appropriate in style properties. Thanks Wally Atkins for the original patch. r=me (closes #1582)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7341 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-06-10 20:39:03 +00:00
Schuyler Erle
cd5c316eba Permalink requires ArgParser. Arg!
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7290 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-05-30 09:16:39 +00:00
Éric Lemoine
34ff282397 ND changes in the modify feature control. Thanks ahocevar for catching the erroneous comment in handleKeypress. No fonctional change.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7213 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-05-17 20:11:45 +00:00
Éric Lemoine
e02e7504c5 MousePosition: numDigits inconsistency, reported by kthy, patch by kthy, additional test by me, r=me (closes #1544)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7163 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-05-13 20:52:01 +00:00
Éric Lemoine
9190e24bcd Cannot modify a feature (linestring) that have two points at the same position, r=me, thanks pvalsecc for the patch and the detailed justification of this patch. (closes #1533)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7061 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-05-05 06:55:07 +00:00
Tim Schaub
209f8f68f8 Fixing links in documentation. Other Natural Docs changes. (closes #1504)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6833 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-04-09 16:52:08 +00:00
Paul Spencer
d7bbcab4df spelling mistake in comment.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6810 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-04-07 18:38:13 +00:00
ahocevar
7251cb438f fixed typo: replaced styleVirtual with virtualStyle, so it matches the API property. r=crschmidt (pullup #1495)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6802 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-04-07 08:07:25 +00:00
crschmidt
1b269f06f8 2.6 accidentally broke behavior when clicking on the panzoombar. Thanks to Linda Rawson's report of this issue, this is now fixed, by moving the Math.floor call to a different part of the code. r=euzuro (Pullup #1486)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6799 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-04-07 04:08:33 +00:00
Paul Spencer
d15ab68360 quick lint before rc1, only some missing missing semi-colons.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6748 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-04-01 00:14:34 +00:00
crschmidt
f3d81983dd Add 'allowSelection' option to controls, to determine whether they allow
selection. Use CSS ClassName in FF, and onselectstart attribute in IE, to
control selection. Fix inappropriate overriding of className in some Control
subclasses in order to let this work. Prevents accidental selection of controls
in IE and FF. r=euzuro. (Closes #1378)  


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6727 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-31 05:55:12 +00:00
Tim Schaub
66e89b9bf0 Making the feature handler a dependency of the SelectFeature control.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6577 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-21 18:55:26 +00:00
Paul Spencer
8b759ab1d6 Closes #1451: change test to be (hopefully) map unit independent. r=crschmidt.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6557 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-19 21:09:53 +00:00
crschmidt
0da40191ec Rolling back patch from #751: this broke IE when used (destroy tries to
destroy slider even though it was never created). Thanks to the tests we
caught it, but this patch needs reworking.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6516 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-13 13:44:09 +00:00
crschmidt
9b1cf1ef01 showPan & showZoomBar options in control PanZoomBar, to turn off the
various chunks. In the future, we'll use this to have a single control 
integrating panzoom and panzoombar, but not quite yet. Revamped patch 
from kkempfer (thx!) with tests. r=me (Closes #754)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6514 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-13 04:20:53 +00:00
Tim Schaub
d12fd7c04c Smooth GDragging at last. Thanks to overstdr for digging up the getDragObject method. With v2.93 and later we no longer get flickers on panning. Non-API smooth dragging is no longer supported. r=crschmidt,me (closes #1402)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6492 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-11 18:32:17 +00:00
Tim Schaub
6d59830d0e Documenting onModification* methods as deprecated in ModifyFeature control.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6490 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-11 16:02:39 +00:00
crschmidt
d0b4a17116 Add improved navigation control support for disabling zooming with the
mousewheel. Original from sbenthall (yay), example and more code from me, tests
from elem. r=elemoine.  (Closes #1339)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6462 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-07 23:04:32 +00:00
Tim Schaub
0a8aa16f78 Control panels should deactivate all non-toggle type controls before activating a new control. r=me (closes #1414)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6443 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-06 05:22:18 +00:00
ahocevar
d9cef80589 typo in ZoomBox. Thanks avlee for spotting this and the patch. r=me (closes #1413)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6432 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-04 10:19:24 +00:00
Frédéric Junod
88b42f0e46 Separating jsdoc declarations. (See #1229)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6431 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-04 10:11:32 +00:00
Tim Schaub
6adeb7c304 ND typo
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6427 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-03 07:06:27 +00:00
Frédéric Junod
279af295f1 Add missing ND comments. (non-functional changes)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6418 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-29 14:16:10 +00:00
Frédéric Junod
8b91ee8d64 Send events when modifying features:
'beforefeaturemodified' triggered when a feature is selected to be modified,
  'featuremodified' triggered when a feature has been modified,
  'afterfeaturemodified' triggered when a feature is finished being modified

r=tschaub (Closes #1358)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6413 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-29 06:50:39 +00:00
Tim Schaub
6ff86dc756 Checking for properties directly on the prototype since it has been extended already. r=crschmidt (closes #1405)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6410 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-29 05:59:43 +00:00
Tim Schaub
697da4900d Adding support for fractional zoom to the pan zoom bar. Setting map.fractionalZoom to true allows you to access a continuous range of resolutions with the pan zoom bar. r=crschmidt,me (closes #1288)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6331 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-20 23:44:34 +00:00
ahocevar
c3c34751bd Click on overview map raises error in IE. r=tschaub (closes #1371)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6330 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-20 23:40:18 +00:00
pgiraud
10ee48c84c fixes typo (Closes #1365)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6315 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-16 08:20:49 +00:00
Tim Schaub
fa55f54e32 Adding framework for internationalization support. The new OpenLayers.Lang.translate method takes a key and looks for a value in a dictionary based on the current language setting. Set a new language code with OpenLayers.Lang.setCode. Get the current code with OpenLayers.Lang.getCode. Thanks to Mike Adair for the lead on this one. r=ahocevar,me (closes #109)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6313 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-15 21:15:48 +00:00
ahocevar
c5dd8ada2c "users should be able to customize the select style per feature": Created a !StyleMap class which stores all styles that are needed for a layer. Controls that need to render features differently can now just give a render intent (e.g. "default", "select" or "temporary") to the layer's drawFeature method, instead of having extra style informations like Control.!SelectFeature.selectStyle. Existing application that set layer.style or feature.style are still supported, but both of these style properties are now null by default. r=crschmidt,elemoine,tschaub (closes #1120)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6240 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-12 23:05:47 +00:00
Frédéric Junod
da706ed568 fix ND start tag. (non-functional change)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6196 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-11 08:08:11 +00:00