Commit Graph

125 Commits

Author SHA1 Message Date
Frédéric Junod
4d3a1eebf7 coding style: add braces around test, use {} instead of new Array(), remove unused variable
git-svn-id: http://svn.openlayers.org/trunk/openlayers@10473 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2010-07-09 11:53:36 +00:00
Frédéric Junod
ae472b69a2 syntax error. r=me
git-svn-id: http://svn.openlayers.org/trunk/openlayers@10424 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2010-06-22 14:30:45 +00:00
Frédéric Junod
a8af8bceb5 Handler.RegularPolygon.clear: check if this.layer is set. r=bartvde (closes #2701)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@10423 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2010-06-22 14:10:43 +00:00
Frédéric Junod
5f6a2209ba Handler.Box.destroy: destroy the dragHandler. r=bartvde (closes #2697)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@10422 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2010-06-22 14:07:32 +00:00
Tim Schaub
3de62b703a Adding multi property to the DrawFeature control. If true, geometries will be cast to multi-part counterparts before features are added to the target layer. r=ahocevar (closes #2542)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@10142 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2010-03-23 17:49:13 +00:00
Frédéric Junod
6223d7fd82 Add a cumulative mode in MouseWheel handler. r=ahocevar (closes #2450)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@10002 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2010-02-01 08:42:17 +00:00
ahocevar
ebc5d7c021 added option to the MouseWheel handler to trigger up/down events only
when wheel is released. r=elemoine (closes #2345)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@9799 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-11-16 10:38:26 +00:00
ahocevar
c9df8f4d43 Added documentDrag option to the DragPan control and Drag handler.
When set to true, this allow pan-dragging while outside the map. 
Thanks vmx for the initial patches. r=vmx, bartvde (closes #39)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@9791 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-11-10 11:14:28 +00:00
ahocevar
ee737577f7 2170_anonfuncs.diff: created functions returning true and false instead of using anonymous functions all over. p=rcoup, r=me (see #2170)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9759 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-10-24 09:23:24 +00:00
Tim Schaub
dfcf68007e Adding a 'sketchstarted' event on the vector layer. This event is triggered at the start of each new sketch. r=ahocevar (closes #1945)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9269 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-04-12 15:36:15 +00:00
Tim Schaub
119f9bc635 Whitespace change only.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9264 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-04-10 16:34:09 +00:00
Tim Schaub
dd556be0be Correct spelling for sketch.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9261 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-04-10 15:27:08 +00:00
Tim Schaub
1fd32e0ff8 Allowing users to better customize cursors for controls. Thanks to bartvde for the original patch and inspiration to get it done. Thanks ahocevar for the IE fix. r=ahocevar (closes #1484)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9258 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-04-09 21:59:53 +00:00
Tim Schaub
f2f118ad90 Reverting unintentional changes in r9234. Meant to just change the controls example.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9235 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-04-07 20:43:27 +00:00
Tim Schaub
e72da4f74e Removing use of deprecated control.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9234 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-04-07 20:38:11 +00:00
Tim Schaub
ed5420b678 Adding a persist option to the measure control. This passes the same to the sketch handler. The cancel method on the control calls the same on the handler. Patch from dwins. Tests from me. r=me (closes #2029)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9225 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-04-07 02:03:57 +00:00
Éric Lemoine
bcf29b8a65 SelectFeature should allow panning the map when over features, without activating click method at the end of drag, r=tschaub (closes #1824)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9194 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-04-06 11:46:15 +00:00
euzuro
b625337018 clear timer for rightclicks so that we don't fire single right click event after double rightclick event. thanks for the excellent find and fix, itbeyond. r=me (Closes #1995)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9175 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-04-03 01:34:58 +00:00
Tim Schaub
f4bae0a011 Adding support for a modify callback in the sketch handlers. This lets controls know about each sketch modification as a sketch is being drawn. Also a bit of a refactor of the sketch handlers to share sketch geometry parts. r=ahocevar (closes #1903)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8831 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-02-04 22:45:16 +00:00
Éric Lemoine
1f6b239c80 fix Handler.Feature API doc, the handler received a single OpenLayers.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8684 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-01-16 07:17:05 +00:00
Éric Lemoine
68ad14a047 Handler.RegularPolygon doesn't always call the "done" callback, r=tschaub (closes #1857)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8616 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-01-09 09:12:37 +00:00
Tim Schaub
850d69a02f Take care not to handle features without a layer. These are typically destroyed features - but could be some other sort of miscreants. Thanks for the report igrcic. r=crschmidt (closes #1806).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8581 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-01-05 04:46:34 +00:00
Éric Lemoine
67f51ad972 it was reported on the mailing list that the hover handler doc isn't sufficient, fix that, thanks for reporting this Mika, no functional change
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8484 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-12-10 20:04:29 +00:00
ahocevar
59bf4105bd added ND comments, removed unused arguments from getBoxCharacteristics. Non-functional change.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8444 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-12-04 21:28:57 +00:00
Éric Lemoine
8b2f674ec9 change method name from "downFeature" to "down" in the ND of the "down" method, no functional change
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8415 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-25 08:04:51 +00:00
Tim Schaub
b916be5489 The feature handler should not handle destroyed features. Or any features without a layer for that matter. r=elemoine (closes #1806)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8284 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-05 21:23:55 +00:00
euzuro
84b65e5f8f fix propogate/propagate typo in click handler. thanks to chris r. for finding this, elemoine for the review. (Closes #1359)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8207 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-10-27 19:00:08 +00:00
Paul Spencer
8114c092b7 apply missing semicolons from r7975 (in 2.7 branch) to trunk
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7979 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-09-08 17:43:34 +00:00
euzuro
c7b8a5bce6 Sketch handler updates. Patch by tschaub, review elemoine (Closes #1698)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7964 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-09-05 15:06:04 +00:00
ahocevar
2a521ffcb2 Made the Feature handler more robust to things that are related to changing layer order on the map, by registering an event handler that will bring the handler's layer back to the top of the layer stack in the DOM. Contains a manual test. r=elemoine (closes #1628)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7879 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-27 14:02:21 +00:00
crschmidt
72bf882b62 Controls should (by definition within OL) stop downs (if they care) and allow
ups to propogate. The default behavior of the Feature handler broke this rule,
and as a result, some aspects of ragging a box control failed when letting
go over a feature. This corrects the behavior. r=ahocevar. (Closes #1293) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7873 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-26 23:35:31 +00:00
euzuro
17160f49e0 Add support in OL for right-click capturing, including dbl-right-clicks (for zooming out in navigation control). Thanks to David Martin for this nice patch and the great 8 foot austrian for his review (Closes #1359)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7872 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-26 23:27:04 +00:00
ahocevar
4fcd61f276 Clear point bounds after changing coordinates. Prevents strange behaviour of IE when doing getBounds(). r=elemoine (closes #1690)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7859 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-26 07:39:21 +00:00
crschmidt
cdd4c864ea Flipped a return value here; this should be 'true', not 'false'. (See #1655)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7683 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-03 12:24:18 +00:00
crschmidt
693e6d07e3 Fix for Feature handler uses getFeatureFromEvent on mousemove even without
hover callbacks; r=ahocevar (Closes #1655) 

This means that On the SelectFeature control hover can no longer be set on the
SelectFeature control after the control has been initialized: must be passed at
initialize time. Example has been updated. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7682 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-03 02:06:31 +00:00
ahocevar
5191dac459 Take css borders into account when drawing the box. This has to be done for every browser, except IE in quirks mode. r=crschmidt (closes 1593)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7649 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-31 21:21:10 +00:00
crschmidt
09b4073636 * Fixes to the Keyboard Handler to make it work better --
* drop keypress event (not used, registers as keydown in IE< which results
      in double events) 
    * return evt instead of evt.keyCode || evt.charCode, so apps can do
      whatever they like best
 * adjust ModifyFeature to new API
 * Adjust KeyboardDefaults to new API, and include a new set of keyCodes
    in switch statement to catch more cases
 * Include keyboard defaults test in list-tests.

Patch from tcoulter, work from Pedro Simonetti (See #1108), Paul Spencer,
myself. r=pagameba,me (Closes #1292)   


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7644 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-31 17:45:16 +00:00
Tim Schaub
66a4c6fb0e Caching array length instead of accessing it with each iteration. r=crschmidt (closes #1636)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7627 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-31 04:44:25 +00:00
euzuro
eb417ff61c adding types to properties from the mousing improvements patch. No functional change, only documentation. (See #1509)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7612 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 18:40:23 +00:00
crschmidt
bc06972aea patch for improved mousedragging. We were able to test this on my eeepc
and get a very obvious speedup in performance. This adds a configurable
'interval' to the dragpan control (and an interval to the 'drag' control,
defaulting to 0px). Patch put together by tcoulter. (Closes #1509) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7608 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 16:27:48 +00:00
Éric Lemoine
6c07bc7ff1 new RegularPolygon features can be invisible, p=me, r=crschmidt (closes #1577)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7588 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-29 18:13:08 +00:00
ahocevar
9724b0a214 "Draw bug in OpenLayers.Handler.Box with firefox". Now always set style.left and style.top, so lost events won't result in an incorrect box any more. r=me (closes #1579)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7375 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-06-18 09:33:55 +00:00
Tim Schaub
209f8f68f8 Fixing links in documentation. Other Natural Docs changes. (closes #1504)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6833 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-04-09 16:52:08 +00:00
Éric Lemoine
ce321ccea3 dragging mode of modify feature control is broken. r=crschmidt,tschaub. (closes #1418)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6564 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-20 07:26:21 +00:00
crschmidt
2694905155 Fix mousewheeling on eventpane layers. r=tschaub (Closes #1438)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6556 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-19 20:53:59 +00:00
euzuro
bf97a6c0d2 be very very careful about how we deal with the wheel. only take action when over scrollable items or over the main map. all of this is explained in the ticket and patch it is really late and i dont feel like typing it again. basically, this puppy means that scrolling on controls or in popups will no longer zoom the map unwantedly. that is good. thank you cr5 and IRC for taking such care of me. (r=cr5) (Closes #1382)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6416 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-29 08:37:12 +00:00
Tim Schaub
323de7085b The click and hover handlers need to take care that the event they are handling doesn't get modified before the delayed listeners get called. Appears to only be a problem in IE. Thanks for the catch madair. r=crschmidt (closes #1393)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6414 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-29 07:30:34 +00:00
crschmidt
9bfd829512 Rollback patch from #1332, which broke feature creation.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6163 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-09 04:23:54 +00:00
crschmidt
60706fc3f9 Refactor Hanadler.Point cancel/finalize to just call a cleanup and pass a
callback type, since otherwise they're the same thing. From sbenthall, r=me
(Closes #1332) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6154 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-09 00:49:38 +00:00
crschmidt
6f2a3598be Fix lots of EOL SSTyle line ending problems.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6131 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-08 19:51:55 +00:00