Commit Graph

336 Commits

Author SHA1 Message Date
ahocevar d2a32d5421 Simplifying and unhacking the ModifyFeature control
With two nested controls (DragFeature, SelectFeature), which - among
others - activated two OpenLayers.Handler.Feature instances, the
ModifyFeature control was fragile and hard to debug.

The issue that @iwillig, @bartvde and myself tried to track down was
that the two Feature handlers interfered with each other, making it hard
to select features on mobile devices, and causing points to jump during
dragging because of not updated last pixel positions.

With this refactoring, there are no more nested controls. All that's left
is a Drag handler. All tests pass. I had to remove one test that checked
for dragging of an unselected point while another was selected, because
now (and partially even before this change, thanks to the ugly drag
handler hack that is now removed) dragging a point will also select it,
saving the user an extra click.
2013-03-19 23:00:10 +01:00
Tim Schaub 30c82bad45 For pixel bounds, the bottom is a larger value than the top
This still doesn't address the broken ZoomBox test (see #800), it fails in the same way with or without this change.
2013-02-14 14:25:01 -07:00
ahocevar ba0ba64c74 Updating PinchZoom tests (see #800)
With the map's applyTransform method, the control does not need and have
its own applyTransform and center management any more.
2013-02-14 22:13:07 +01:00
Tim Schaub e9eefc7a33 Fewer failing tests
There are still tests failing, but this change addresses some of the new failures after 4b163e0482 (which is an awesome improvement despite the test failures :).
2013-02-14 12:29:03 -07:00
Marc Jansen 4d7eaf4939 Merge pull request #866 from marcjansen/866
LayerSwitcher generate bad ID when layername has spaces in it. (r=@ahocevar)
2013-02-14 07:01:32 -08:00
Marc Jansen 465498b83a Use blank.gif as WMS-mockup URL in test. 2013-02-14 09:13:01 +01:00
Marc Jansen 73c5dbd8dc Only valid characters in generated ids. 2013-02-14 07:14:13 +01:00
ahocevar 9b7e35d1dd Merge branch 'master' of github.com:openlayers/openlayers into transform
Conflicts:
	theme/default/style.css
2013-01-09 14:31:52 +01:00
ahocevar 4b2e80fa36 Merge pull request #805 from mosesonline/unselectAllFix
unselectAll on removing layer fix
2012-12-24 06:17:04 -08:00
ahocevar 21448d2fd5 Adding animated zooming 2012-12-23 18:47:03 +01:00
ahocevar 3d79001a92 Updating and adding tests 2012-12-23 18:34:53 +01:00
mosesonline 0263b2b5e1 [Change] renamed test and added print of error 2012-12-18 09:47:33 +01:00
mosesonline 7aed43185b [BugFix] Added tests for handle destroyed layer in SelectFeature. 2012-12-18 09:43:22 +01:00
Pierre GIRAUD 06597f1897 Missing var 2012-12-17 13:23:10 +01:00
Pierre GIRAUD 00c3ca47c0 Adding test for new preserveCenter option 2012-12-17 11:56:33 +01:00
ahocevar 6607bcc0bb Do not cache data from aborted tile loads
This also results in a simplified cache method that can more easily be
overridden for use with other storage providers.
2012-10-12 14:06:08 +02:00
Marc Jansen 1063a4cd19 Make it possible to change the filter in handlers
Trigger the 'select'-event earlier, this way any handlers for the event can
change both the filter and the resulting SLD inside the callback.
2012-09-06 13:29:59 +02:00
ahocevar f0ad48597f No more percentage based positioning.
Client zoom now supports both over- and undersampling.
2012-08-21 13:57:11 +02:00
Marc Jansen df19317c95 Merge branch 'master' of https://github.com/openlayers/openlayers
Conflicts:
	tests/list-tests.html
2012-08-17 22:46:06 +02:00
ahocevar 78d07c8d8a Merge pull request #524 from ahocevar/panzoombar
Zoom level restriction improvements. r=@bartvde
2012-06-22 16:59:13 -07:00
Marc Jansen b86394b79b Merge branch 'control-inheritance' of https://github.com/marcjansen/openlayers 2012-06-20 18:08:01 +02:00
ahocevar fe31af5c80 Adding unit tests. 2012-06-13 23:14:34 +02:00
Tim Schaub 704f36639b Merge pull request #529 from adv-isu/ControlSplitDeactivateFix
OpenLayers.Control.Split.deactivate event unregistration fix.
2012-06-13 09:11:45 -07:00
ahocevar 8ad7ad326a Review comments from @bartvde. 2012-06-11 19:22:05 +02:00
ahocevar 958544f2a7 New zoomOnClick option for ZoomBox control.
This change also finally adds tests for the ZoomBox control.
2012-06-11 19:07:17 +02:00
Marc Jansen 0c87de44b4 Merge branch 'control-inheritance' of https://github.com/marcjansen/openlayers into control-inheritance
Conflicts:
	tests/Control/ZoomOut.html
	tests/Control/ZoomToMaxExtent.html
2012-06-08 09:44:36 +02:00
Andrew Vardeman f64912c09d use two different layers for Split tool's layer and the source layer so as to properly check for event unregistration 2012-06-04 17:25:54 -05:00
Éric Lemoine e3d1d3ea62 more tests for SelectControl.unselectAll 2012-05-31 18:27:55 +02:00
Éric Lemoine e603b06715 make SelectControl.unselectAll safer 2012-05-31 18:27:54 +02:00
Frederic Junod c696b34a84 Add new maximizeTitle and minimizeTitle options to Control.OverviewMap 2012-05-29 09:04:00 +02:00
Marc Jansen a87f5ac16a Merge branch 'master' of https://github.com/openlayers/openlayers into control-inheritance 2012-05-15 08:34:53 +02:00
John Lien ab87c33670 Applied patch from ticket #3381 to Permalink tests and updated Permalink
control to pass tests by maintaining anchors.

All tests continue to pass.
2012-04-22 14:48:12 -04:00
Marc Jansen 4cd34bc851 Added tests for OpenLayers.Control.Pan. 2012-04-17 21:31:12 +02:00
Marc Jansen 53ed973eec Added tests for OpenLayers.Control.Pan. 2012-04-17 21:24:54 +02:00
Marc Jansen d08fb575b1 The changed controls should also check whether they have correctly
inherited the property 'type' of the new parent class.
2012-04-17 20:21:06 +02:00
Marc Jansen d5bdadc18e Removed erroneously commited alert-statements in tests. 2012-04-17 20:06:40 +02:00
Marc Jansen 4af41b41f5 Added tests for ZoomIn control. 2012-04-17 20:04:49 +02:00
Marc Jansen a5c5fd8d3e Added tests for the 'type' property which is now inherited from the
parent class.
2012-04-17 08:20:09 +02:00
Marc Jansen c40bdc90e9 Added tests for ZoomOut control. 2012-04-17 08:11:08 +02:00
Marc Jansen 84e5c47caa Add tests for the ZoomToMaxExtent control. 2012-04-13 09:58:59 +02:00
Paul Spencer 30af95d034 a working test thanks to Marc. 2012-03-30 07:59:22 -04:00
Paul Spencer d4e6253447 indent 4. 2012-03-29 07:32:25 -04:00
Paul Spencer 9e31fb6e9a Update OverviewMap to test if calling minimizeControl or maximizeControl causes an exception. 2012-03-28 14:06:51 -04:00
ahocevar 8d42f33a28 Fixing typo which causes CacheRead to fail when CacheWrite is active 2012-03-21 23:21:24 +01:00
Frederic Junod 46309b5265 Fix proj4js script.src 2012-03-15 17:13:10 +01:00
Antoine Abt bed3edeb46 Merge pull request #281 from ejn/master
Improve iconOn/iconOff class name matching in Panel.js; add unit tests
2012-03-13 00:37:54 -07:00
ahocevar 6b5dba3f93 Merge pull request #301 from ahocevar/offline
Adding CacheRead and CacheWrite controls. r=@elemoine,@fredj
2012-03-12 08:29:00 -07:00
Tim Schaub 1a444589e0 Merge pull request #274 from tschaub/utfgrid
UTFGrid Tile, Layer, and Control.  This adds support for responsive handling of interactions with large numbers of features represented by UTFGrids.
2012-03-09 08:49:30 -08:00
ahocevar f18ac9911b Adding CacheRead and CacheWrite controls.
These controls read from and write to the browser's offline storage. Example with a seeding tool included.
2012-03-08 14:18:44 +01:00
Éric Lemoine 877f4b4cc6 make the PanZoom tests pass in IE 9+, by not running tests that rely on document.createEvent in this browser too, no functional change (refs #277) 2012-03-07 22:01:39 +01:00