ffab22ba19
2.6 introduced a regression that maps could not be created when the Object
...
prototype is extended. Although OpenLayers is not designed to work when this
fundamental violation of Javascript is in place, we can at least not fail
so miserably in this case: this gets us back to a similar level of
functionality as we had in 2.5. This was brought up by a user working on
a viamichelin layer, which apparently extends the object prototype (bad!),
and fixed in conjuction with tschaub. r=pgiraud,tschaub (Pullup #1502 )
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6832 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-04-09 16:06:23 +00:00
894c457fdd
Adding eventListeners property to layer, control, and map. Setting this property at construction registers the given listeners based on event type key. r=elemoine ( closes #1404 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6435 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-05 00:07:46 +00:00
32d541641d
fix typos and missing documentation in ND comments. (non-functional changes)
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6200 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-11 09:54:21 +00:00
f27833f1db
Trigger feature related events with feature information and layer related events with layer information. Also adding events.on and events.un convenience methods. r=crschmidt ( closes #1343 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6149 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-08 23:31:27 +00:00
92b4894e33
"Tests Broken on IE6". This adds an additional check that prevents IE6 from complaining about undefined properties. r=crschmidt ( closes #1322 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6021 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-07 19:46:04 +00:00
09e0d3ec81
Update copyrights to 2008.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5614 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-01 08:14:55 +00:00
33e313b059
Separating jsdoc style docs into their own block. The new NaturalDocs doesn't parse these mixed blocks, giving us no class descriptions with the two together. ( closes #1229 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5553 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-21 08:28:09 +00:00
3e652566e8
triggerEvent can now be called with additional arguments for the listeners - this means instead of getting news like 'hey, someone won the lottery' listeners now get news like 'hey, you won the lottery' - in addition, the triggerer gets back the return from the listener, so if a listener wants to say 'dont tell anyone else' the triggerer gets that message - thanks for the reviews ( closes #1189 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5398 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-13 17:30:52 +00:00
a13cacdde9
protect stopObserving() from trying to remove nonexistant events. thx for review, cr5 ( Closes #1151 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5241 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-11-21 18:50:55 +00:00
3e9beffc99
large scale syntactic clean up adding missing semi-colons and curly braces around blocks.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5002 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-10-18 12:27:35 +00:00
ed3221441c
Refactor SVN layout in compliance with RFC/LicenseChange. This hopefully
...
completes an important blocker for moving forward with OSGeo incubation.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4985 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-10-17 02:21:22 +00:00
2478677985
Deprecating all prototype extensions. This puts all OpenLayers functionality in the OpenLayers namespace. If you are using any of the Function, String, or Number prototype extensions, start using the functional equivalents in the OpenLayers namespace - the prototype extensions will be gone in 3.0 ( closes #712 ).
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4302 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-14 20:08:47 +00:00
9724bbaeee
Here we have finally solved the smashing of the Event object problem. Once and forall. God save the queen when 3.0 comes we're getting rid of this sloppiness. See r4040 for more info on why we've done all this. ( Closes #880 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4271 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-13 23:17:44 +00:00
c2148651ed
Filling our log with cruft, adding meaningless conflicts for merges, and changing a comment style that ndocs could care less about, this commit changes Return to Returns ( closes #945 ).
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4110 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-29 18:44:10 +00:00
807449046b
Commit fix for an off-by-two error on standards complaint HTML pages in IE, and
...
add an HTML example that can be used as an acceptance test. (Closes #863 )
Thanks pierre for the research and report!
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4098 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-29 04:03:13 +00:00
b9a1287a5f
"Event object conflict: If you include OpenLayers.js AFTER including
...
prototype.js, this effectively replaces most of prototype's Event object with
the OpenLayers.Event object, which has undesirable results (i.e. calling
Event.observe is actually calling OpenLayers.Event.observe)." Fixed by
only creating Event is Event does not already exist. (Closes #880 )
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4040 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-25 07:39:28 +00:00
6194452b8a
Since John already went ahead and committed the main change, I'm just going
...
to finish this one up. All commits are in comments, so a review doesn't seem
strictly neccesary. This closes #918 and fixes all the copyrights that I could
find in the code.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3984 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-23 11:29:06 +00:00
cf5a53959e
ND Update: make array's say what they're made of, and a few other small bits, like mistyped and a couple missing <>s
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3829 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-31 20:02:03 +00:00
8c552be94b
as universally approved on discussions on dev list, replace new Array() with []. all tests pass ff & ie6
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3815 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-25 22:48:02 +00:00
5f0bde51da
as universally approved on discussions on dev list, replace new Object() with {}. all tests pass ff & ie6
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3814 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-25 22:39:28 +00:00
fd4d2918f1
fix for #853 - remove JSDOC comments from CLASS_NAME variables
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3787 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-23 15:09:09 +00:00
cc1b0269c9
#823 New class style. Instead of OldStyle = Class.create(); OldStyle.prototype = Class.inherit(Parent, prototype), we now use NewStyle = OpenLayers.Class(Parent, prototype). New style classes allow for backwards compatibility [you can use OldStyle = Class.create(); Class.inherit(NewStyle, prototype)]. The Class.create and Class.inherit functions are deprecated. Backwards compatibility will be removed at 3.0. Thanks Erik for the careful review.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3767 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-16 20:25:11 +00:00
f1d9208abd
replacing tabs with spaces
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3684 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-10 21:40:26 +00:00
a14b5bdc7e
patch for #809 - add the addEventType() function to the OpenLayers.Events objects so that subclasses can safely add new event types without modifying their parents' constant values
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3622 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-06 18:30:09 +00:00
bee797430d
update nd docs for Openlayers.Events
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3621 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-06 17:47:38 +00:00
a74a9bd49f
remove *private* statements from nd comments
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3620 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-06 17:38:20 +00:00
23bc407f8b
update nd for OpenLayer.Event object
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3599 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-05 20:02:29 +00:00
3948913bfc
Merge all changes from the naturaldocs sandbox. This brings all the work that
...
has been done in the NaturalDocs branch back to trunk. Thanks to everyone who
helped out in making this happen. (I could list people, but the list would
be long, and I'm already mentally on vacation.)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3545 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-06-29 15:59:20 +00:00
23131012dd
fix for #624 - merge stop() and safeStopPropagation()
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2994 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 17:15:57 +00:00
10b5c2df17
patch for #621 - assign items in the elements hash table a unique cacheID instead of relying on the element's actual 'id' property. thx for thorough review sde
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2993 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 16:54:14 +00:00
d0115ccf26
patch for #625 - remove extraneous _observeAndCache() function which is only used once. it doesnt seem to conceptually abstract anything, so lets inline it
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2991 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 15:54:27 +00:00
33cb7fd0d4
patch for #623 - remove unused pointerX() and pointerY() functions
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2990 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 15:38:16 +00:00
9aa92d491c
events.js cleanup: more ifs without brackets
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2989 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:42:21 +00:00
7aac1c1cfe
coding standards. if statement without brackets and multiple return
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2988 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:38:22 +00:00
8440cbaf43
coding standards if statement should always be followed by braces. also, add comment
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2987 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:37:04 +00:00
2734030a82
move unloadCache() down so that stopObserving and stopObservingElement() are next to eachother
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2986 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:31:45 +00:00
2f8a093f83
move observe() function up to right before its private counterpart
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2985 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:27:39 +00:00
ade794259f
move observers definition to top of object definition for readability
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2984 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:26:39 +00:00
8007b6719a
events.js: style (never underestimate style)
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2983 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 23:12:55 +00:00
ed0fca9157
events cleanup: fix tabs
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2982 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 23:00:55 +00:00
dfa4441646
step one of cleaning up events.js: jsdoc
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2981 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 22:49:13 +00:00
474064b4e5
Clean up all events, not just some of them. Cleans up possible memory leaks.
...
Closes #604 , patch by Erik.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2947 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-31 19:47:05 +00:00
53b23bdf37
make stopObserving/stopObservingElement more resilient: can accept either
...
elements or ids. Closes #603 (and makes #604 work).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2946 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-31 19:46:04 +00:00
aa4cca057d
patch for #585 - delete row from hash instead of nullifying it. thx tim for quick approval
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2929 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 21:17:12 +00:00
f850939a3a
fix for small bug in previous patch for #568 which was put in at r2913
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2914 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 21:53:27 +00:00
a07a4c309d
Cleanup to Events.js. By Erik, in #568 .
...
* code was only ever removing the first event listener from each element
on unload cache (for loop instead of while)
* code was frequently not removing observers because their associated
elements have already been removed
These two are fixed by this patch. Combined with the previous commits to
setting events, this should fix the memory leaks demonstrated by the 'drip'
tool for IE.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2913 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 21:41:08 +00:00
87977f7bfe
final patch for #510 -- new datastructure suggested and implemented by james for the events entry cache. speeds up all event operations
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2896 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-26 17:33:35 +00:00
d10b4a37df
applying (yet another) patch for #510
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2873 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-24 01:34:58 +00:00
f99d1ce7b0
Fix the event listener leak, which has been a serious problem when large numbers of markers etc. are created. Closes #510 .
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2867 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-23 14:22:38 +00:00
3ca974acec
Merge vector-2.4 branch back to trunk.
...
svn merge sandbox/vector-2.4/@2307 sandbox/vector-2.4/@HEAD trunk/openlayers/
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2803 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-16 13:23:56 +00:00
crschmidt
Tim Schaub
Frédéric Junod
ahocevar
euzuro
Paul Spencer
Schuyler Erle