ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
3,013 Commits 5 Branches 232 Tags
31dd2e65bdc01235fe8c0b50437413d95435391c
Commit Graph

107 Commits

Author SHA1 Message Date
Tim Schaub
f4bae0a011 Adding support for a modify callback in the sketch handlers. This lets controls know about each sketch modification as a sketch is being drawn. Also a bit of a refactor of the sketch handlers to share sketch geometry parts. r=ahocevar (closes #1903) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8831 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2009-02-04 22:45:16 +00:00
Éric Lemoine
1f6b239c80 fix Handler.Feature API doc, the handler received a single OpenLayers. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8684 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2009-01-16 07:17:05 +00:00
Éric Lemoine
68ad14a047 Handler.RegularPolygon doesn't always call the "done" callback, r=tschaub (closes #1857) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8616 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2009-01-09 09:12:37 +00:00
Tim Schaub
850d69a02f Take care not to handle features without a layer. These are typically destroyed features - but could be some other sort of miscreants. Thanks for the report igrcic. r=crschmidt (closes #1806). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8581 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2009-01-05 04:46:34 +00:00
Éric Lemoine
67f51ad972 it was reported on the mailing list that the hover handler doc isn't sufficient, fix that, thanks for reporting this Mika, no functional change 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8484 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-12-10 20:04:29 +00:00
ahocevar
59bf4105bd added ND comments, removed unused arguments from getBoxCharacteristics. Non-functional change. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8444 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-12-04 21:28:57 +00:00
Éric Lemoine
8b2f674ec9 change method name from "downFeature" to "down" in the ND of the "down" method, no functional change 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8415 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-11-25 08:04:51 +00:00
Tim Schaub
b916be5489 The feature handler should not handle destroyed features. Or any features without a layer for that matter. r=elemoine (closes #1806) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8284 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-11-05 21:23:55 +00:00
euzuro
84b65e5f8f fix propogate/propagate typo in click handler. thanks to chris r. for finding this, elemoine for the review. (Closes #1359) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8207 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-10-27 19:00:08 +00:00
Paul Spencer
8114c092b7 apply missing semicolons from r7975 (in 2.7 branch) to trunk 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7979 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-09-08 17:43:34 +00:00
euzuro
c7b8a5bce6 Sketch handler updates. Patch by tschaub, review elemoine (Closes #1698) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7964 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-09-05 15:06:04 +00:00
ahocevar
2a521ffcb2 Made the Feature handler more robust to things that are related to changing layer order on the map, by registering an event handler that will bring the handler's layer back to the top of the layer stack in the DOM. Contains a manual test. r=elemoine (closes #1628) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7879 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-08-27 14:02:21 +00:00
crschmidt
72bf882b62 Controls should (by definition within OL) stop downs (if they care) and allow 
ups to propogate. The default behavior of the Feature handler broke this rule,
and as a result, some aspects of ragging a box control failed when letting
go over a feature. This corrects the behavior. r=ahocevar. (Closes #1293) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7873 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-08-26 23:35:31 +00:00
euzuro
17160f49e0 Add support in OL for right-click capturing, including dbl-right-clicks (for zooming out in navigation control). Thanks to David Martin for this nice patch and the great 8 foot austrian for his review (Closes #1359) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7872 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-08-26 23:27:04 +00:00
ahocevar
4fcd61f276 Clear point bounds after changing coordinates. Prevents strange behaviour of IE when doing getBounds(). r=elemoine (closes #1690) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7859 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-08-26 07:39:21 +00:00
crschmidt
cdd4c864ea Flipped a return value here; this should be 'true', not 'false'. (See #1655) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7683 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-08-03 12:24:18 +00:00
crschmidt
693e6d07e3 Fix for Feature handler uses getFeatureFromEvent on mousemove even without 
hover callbacks; r=ahocevar (Closes #1655) 

This means that On the SelectFeature control hover can no longer be set on the
SelectFeature control after the control has been initialized: must be passed at
initialize time. Example has been updated. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7682 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-08-03 02:06:31 +00:00
ahocevar
5191dac459 Take css borders into account when drawing the box. This has to be done for every browser, except IE in quirks mode. r=crschmidt (closes 1593) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7649 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-07-31 21:21:10 +00:00
crschmidt
09b4073636 * Fixes to the Keyboard Handler to make it work better -- 
* drop keypress event (not used, registers as keydown in IE< which results
      in double events) 
    * return evt instead of evt.keyCode || evt.charCode, so apps can do
      whatever they like best
 * adjust ModifyFeature to new API
 * Adjust KeyboardDefaults to new API, and include a new set of keyCodes
    in switch statement to catch more cases
 * Include keyboard defaults test in list-tests.

Patch from tcoulter, work from Pedro Simonetti (See #1108), Paul Spencer,
myself. r=pagameba,me (Closes #1292)   


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7644 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-07-31 17:45:16 +00:00
Tim Schaub
66a4c6fb0e Caching array length instead of accessing it with each iteration. r=crschmidt (closes #1636) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7627 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-07-31 04:44:25 +00:00
euzuro
eb417ff61c adding types to properties from the mousing improvements patch. No functional change, only documentation. (See #1509) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7612 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-07-30 18:40:23 +00:00
crschmidt
bc06972aea patch for improved mousedragging. We were able to test this on my eeepc 
and get a very obvious speedup in performance. This adds a configurable
'interval' to the dragpan control (and an interval to the 'drag' control,
defaulting to 0px). Patch put together by tcoulter. (Closes #1509) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7608 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-07-30 16:27:48 +00:00
Éric Lemoine
6c07bc7ff1 new RegularPolygon features can be invisible, p=me, r=crschmidt (closes #1577) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7588 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-07-29 18:13:08 +00:00
ahocevar
9724b0a214 "Draw bug in OpenLayers.Handler.Box with firefox". Now always set style.left and style.top, so lost events won't result in an incorrect box any more. r=me (closes #1579) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7375 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-06-18 09:33:55 +00:00
Tim Schaub
209f8f68f8 Fixing links in documentation. Other Natural Docs changes. (closes #1504) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6833 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-04-09 16:52:08 +00:00
Éric Lemoine
ce321ccea3 dragging mode of modify feature control is broken. r=crschmidt,tschaub. (closes #1418) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6564 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-03-20 07:26:21 +00:00
crschmidt
2694905155 Fix mousewheeling on eventpane layers. r=tschaub (Closes #1438) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6556 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-03-19 20:53:59 +00:00
euzuro
bf97a6c0d2 be very very careful about how we deal with the wheel. only take action when over scrollable items or over the main map. all of this is explained in the ticket and patch it is really late and i dont feel like typing it again. basically, this puppy means that scrolling on controls or in popups will no longer zoom the map unwantedly. that is good. thank you cr5 and IRC for taking such care of me. (r=cr5) (Closes #1382) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6416 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-29 08:37:12 +00:00
Tim Schaub
323de7085b The click and hover handlers need to take care that the event they are handling doesn't get modified before the delayed listeners get called. Appears to only be a problem in IE. Thanks for the catch madair. r=crschmidt (closes #1393) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6414 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-29 07:30:34 +00:00
crschmidt
9bfd829512 Rollback patch from #1332, which broke feature creation. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6163 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-09 04:23:54 +00:00
crschmidt
60706fc3f9 Refactor Hanadler.Point cancel/finalize to just call a cleanup and pass a 
callback type, since otherwise they're the same thing. From sbenthall, r=me
(Closes #1332) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6154 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-09 00:49:38 +00:00
crschmidt
6f2a3598be Fix lots of EOL SSTyle line ending problems. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6131 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-08 19:51:55 +00:00
Tim Schaub
99f3fa0d26 By default, the click handler now has a zero pixelTolerance. This means we don't call click if the click includes a drag. Set pixelTolerance to null if you want click called with a drag. r=crschmidt (closes #1335) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6066 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-08 03:24:42 +00:00
crschmidt
ca5c08ee26 Fix typo in comments. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6011 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-06 23:52:39 +00:00
Frédéric Junod
911a2772a4 Opera version < 9.20 invert the wheelDelta value but version >= 9.20 don't. r=crschmidt (Closes #1193) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6004 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-06 15:34:16 +00:00
Éric Lemoine
cf87ffc26c Add properties stopClick, stopDown, and stopUp to the feature handler. If 
stopClick is true, clicks handled by the feature handler don't propagate to
other click listeners; otherwise handled clicks do propagate. The same kind of
rule applies to stopDown and stopUp. These properties default to true. Thanks
to Attila Csipa for expressing the need for this feature and cooking up the
first patch. r=tschaub. (closes #1266)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@5976 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-03 17:35:39 +00:00
Éric Lemoine
f9950ec389 This commit solves the following problem with the select feature control: if 
you create two select feature controls on the same vector layer, one with
hover:false that handles geometry type A only, and the other with hover:true
that handles geometry type B only, then if you click on a geometry of type A
and moves out of that geometry, the second control will unselect it. r=tschaub
(closes #1221)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@5975 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-03 17:20:39 +00:00
crschmidt
d597e4f9a9 Because onselectstart is null by default, our logic to set it and 
replace it was somewhat lacking. This changes the behavior such that 
using hte drag handler does not totally disable text selection in IE. 
Patch from Bart, r=me (Closes #906)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@5911 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-01-27 14:48:02 +00:00
Éric Lemoine
f053a4e0c8 Add hover handler. With this handler user-defined actions can be triggered as the mouse moves over the map and pauses. An example of use is send WMS/GetFeatureInfo requests. r=crschmidt,tschaub (closes #1255) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5746 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-01-15 12:54:47 +00:00
Tim Schaub
11c1ef3f68 The pixelTolerance check on the click handler only works if mousedown events get to the handler. This keeps the handler from failing in cases where mousedown is stopped and pixelTolerance is set. r=crschmidt (closes #1246) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5698 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-01-09 09:55:22 +00:00
Tim Schaub
5b31ee3c0a Giving the drag handler a stopDown property. Set this to true in the constructor options to let mousedown events propagate. r=crschmidt (closes #1247) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5697 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-01-09 09:50:21 +00:00
Éric Lemoine
21f2605b55 click handler's cachedEvent property isn't needed. r=tschaub. (closes #1252) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5676 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-01-07 23:49:59 +00:00
Tim Schaub
6791cf6086 Point, path, and poly handlers now clean up before calling callbacks. r=crschmidt (closes #1239) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5624 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-01-02 19:06:07 +00:00
crschmidt
09e0d3ec81 Update copyrights to 2008. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5614 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-01-01 08:14:55 +00:00
Tim Schaub
86116ddd73 Making feature handler call over and out callbacks just once per mouseover and mouseout (of a feature). r=elemoine (closes #1226) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5555 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-21 08:48:08 +00:00
Tim Schaub
33e313b059 Separating jsdoc style docs into their own block. The new NaturalDocs doesn't parse these mixed blocks, giving us no class descriptions with the two together. (closes #1229) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5553 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-21 08:28:09 +00:00
Tim Schaub
5babc73615 stop clicks on the point handler - this means no more clicks sneaking through while editing - if you wanted that behavior, speak up - r=crschmidt (closes #1020) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5523 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-20 03:02:54 +00:00
Éric Lemoine
6fb48c0cd7 Enables unselecting selected features by clicking outside any feature. This is the default mode of the modify feature control. If you want to use the old mode where a click on a selected feature unselects that feature, set the toggle option to true. If you really want the old mode and not have selected features be unselected when clicking outside any feature, set the clickout option to false. The patch also adds the properties toggleKey and multipleKey to the modify feature control. With these one can temporarily enable the toggle and multiple mode, respectively. See the select-feature.html example to see all this in action. Thanks to pvalsecc and tschaub for the great colloration on this. (closes #1137) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5506 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-19 11:09:44 +00:00
Éric Lemoine
dc2cc625f3 Do not call preFeatureInsert() and onFeatureInsert() callbacks when the modify feature control and the regular polygon handler internally adds point geometries to the layer. This is accomplished by adding an 'options' argument to the addFeatures() method in Layer.Vector. If that options argument has the silent property set to true, then the preFeatureInsert() and onFeatureInsert() callbacks aren't called. Thanks tschaub and fredj for your input. Thanks crschmidt for the final review. (closes #1148) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5470 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-17 14:36:39 +00:00
Tim Schaub
6ad22b8e6a adding a click handler for flexible cross-browser single and double click handling - add to a control and set click or dblclick callbacks - thanks for the review and pairing crschmidt (closes #1211) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5438 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-16 04:42:14 +00:00