Commit Graph

111 Commits

Author SHA1 Message Date
Frederic Junod
7408100c27 Allow the value to be changed while iterating over the rtree 2014-06-19 09:24:48 +02:00
Frederic Junod
e9e62bcf98 Better ol.structs.RBush#forEach documentation 2014-06-11 13:45:18 +02:00
Tim Schaub
e4e3b2229a Defines in ol namespace defined in ol.js 2014-04-30 08:54:30 -06:00
Andreas Hocevar
c17ac0cae3 Greatly simplify and document the usage of JSDoc
This commit simplifies the exports.js plugin so it only relies
on the stability notes to generate the documentation, which
completely decouples it from the exportable API.

As a rule of thumb, whenever something has an 'api' annotation,
it should also have a 'stability' annotation. A more verbose
documentation of ol3 specific annotation usage is available in
the new 'apidoc/readme.md' file.

This commit also modifies all source files to implement these
usage suggestions.
2014-04-29 09:53:06 -06:00
Tom Payne
e5ee44f8ad Rename ol.structs.RBush#getAllInExtent to getInExtent 2014-03-06 14:30:56 +01:00
Tom Payne
286284b0c4 Move remove from ol.structs.RBush to ol.structs.RBushNode 2014-02-06 12:48:52 +01:00
Tom Payne
7f64a09e3c Return, and check, boolean value from ol.structs.RBush#remove indicating whether value was removed 2014-02-06 12:48:51 +01:00
Tom Payne
09326519d3 Replace faulty iterative ol.structs.RBush#remove with less faulty recursive version 2014-02-06 12:48:51 +01:00
Frederic Junod
ce721bc42f Assert that an element is removed in ol.structs.RBush#remove_ 2014-02-06 12:48:51 +01:00
Tom Payne
52740a3904 Reuse extent object in ol.structs.RBush#update 2014-01-20 18:16:49 +01:00
Tom Payne
4a18554353 Use opt_this instead of opt_obj in ol.structs.RBush 2014-01-15 15:09:18 +01:00
Tom Payne
fdea683242 Use opt_this instead of opt_obj in ol.structs.LRUCache 2014-01-15 15:09:07 +01:00
Tom Payne
d132d22f4d Use opt_this instead of opt_obj in ol.structs.IntegerSet 2014-01-15 15:08:52 +01:00
Tom Payne
15395476a3 Use opt_this instead of opt_obj in ol.structs.Buffer 2014-01-15 15:08:39 +01:00
Frederic Junod
9f79d33486 Create 'type' annotation for 'const' variables
From https://developers.google.com/closure/compiler/docs/js-for-compiler:
  "The type declaration and additional comment are optional. If you
  provide a type declaration, put the declaration on a separate line."
2014-01-09 09:53:20 +01:00
Tom Payne
c599ceb43d Merge pull request #1458 from Intermedix/bug-insert-valueExtent
Fix bug in ol.structs.RBush#update
2014-01-04 05:46:41 -08:00
Austin Hyde
6ea1482ecf Fix issue with valueExtent_ being cleared while updating extents, but never being repopulated 2014-01-03 15:54:26 -05:00
Tom Payne
46267a9059 Use toString() instead of + '' 2014-01-03 14:55:02 +01:00
Tom Payne
484c5b2fe3 Fix bug in ol.structs.RBush#clear 2013-12-19 14:22:44 +01:00
ahocevar
a4083f544e Merge pull request #1373 from ahocevar/rbush-fail
ol.structs.RBush#remove() is unreliable
2013-12-16 05:02:49 -08:00
ahocevar
8bfa0f7ae9 Truthy check is enough 2013-12-16 13:53:55 +01:00
Tom Payne
fad3251545 Add ol.structs.RBush#getExtent 2013-12-16 13:02:51 +01:00
Tom Payne
fbc23499e4 Add @struct annotation for simple classes 2013-12-13 18:59:26 +01:00
ahocevar
d3cc822f98 Do not ascend when node has more siblings 2013-12-13 17:30:28 +01:00
Tom Payne
7b7ebb8609 Add missing "new"s in ol.structs.RBush 2013-12-12 13:01:25 +01:00
Tom Payne
2be40a1ae6 Add ol.structs.RBush#isEmpty 2013-12-04 15:05:43 +01:00
ahocevar
d4bdac715b Get rid of ol.structs.RTree 2013-11-28 16:17:17 +01:00
Tim Schaub
1877f92d46 Add forEach method to rtree, use it in feature cache
This saves having to create feature lookup objects and iterate through lookup properties multiple times.
2013-11-27 12:22:33 -07:00
Tom Payne
5d3a5ae68e Fix infinite loop bug in ol.structs.RBush 2013-11-27 15:10:18 +01:00
Tom Payne
f847b37261 Rename ol.structs.RBush#allInExtent to getAllInExtent 2013-11-27 15:10:18 +01:00
Tom Payne
828456d18e Rename ol.structs.RBush#all to getAll 2013-11-27 15:10:18 +01:00
Tom Payne
978041b68c Only activate ol.structs.RBush conflict checks when goog.DEBUG is true 2013-11-27 15:10:18 +01:00
Tom Payne
665781ee03 Throw an exception if an ol.structs.RBush is modified while reading 2013-11-27 15:10:17 +01:00
ahocevar
96c6cd0ab0 Documenting limitations of forEach and forEachInExtent
Because the tree's structure changes when nodes are inserted,
updated or deleted, no modifications are allowed in a forEach
loop.
2013-11-27 14:21:56 +01:00
Tom Payne
92469901f7 Clone extents in ol.structs.RBush to prevent modification 2013-11-26 12:03:00 -07:00
Tom Payne
880f098f0f Add ol.structs.RBush#update 2013-11-26 12:02:59 -07:00
Tom Payne
7ec456fa70 Add FIXME 2013-11-26 12:02:59 -07:00
Tom Payne
1293294d40 Implement ol.structs.RBush#remove_ 2013-11-26 12:02:59 -07:00
Tom Payne
b865a7c0e1 Don't check for under-full nodes when validating ol.structs.RBush
Removal can lead to under-full nodes.
2013-11-26 12:02:59 -07:00
Tom Payne
a76eba34e8 Add ol.structs.RBush#assertValid 2013-11-26 12:02:59 -07:00
Tom Payne
e823e7fde3 Add ol.structs.RBush 2013-11-26 12:02:59 -07:00
Tom Payne
353555f740 Use templates in ol.structs.PriorityQueue 2013-11-19 21:19:22 +01:00
Tom Payne
9d92b9ee37 Use templates in ol.structs.LRUCache 2013-11-19 21:19:22 +01:00
ahocevar
292b851a74 Adding ModifyFeature interaction
This is a first draft. The way geometry changes are handled for
now is a bit clumsy. Both updating the feature cache RTree and
making the layer aware of feature and geometry changes could be
handled in a smarter way if these changes would be made through
the layer instead of directly on the geometry or feature.
2013-11-13 00:44:36 +01:00
Frederic Junod
01cc19af80 More precise {function} jsdoc definition 2013-11-07 16:03:19 +01:00
Frederic Junod
3efc810ca9 Quote values in apidoc 2013-10-29 11:01:49 +01:00
Paul Spencer
bada596b45 Add default stability level to docs of exported things. 2013-10-24 18:20:24 -04:00
Tim Schaub
e806f51b3d Changing extent structure back to single array: [minX, minY, maxX, maxY]
This means we'll have to have a new structure and new methods for 3D envelopes.
2013-09-15 00:31:32 -06:00
Tim Schaub
6955499534 Update rtree to use new extent structure 2013-09-14 21:11:52 -06:00
Tom Payne
0467222e46 Fix various type errors in ol.structs.RTree 2013-07-22 17:42:47 +02:00