Commit Graph

397 Commits

Author SHA1 Message Date
Éric Lemoine f04f203499 ghost features stay displayed with select feature control, r=pgiraud (closes #1865)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8899 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-02-26 15:19:43 +00:00
Tim Schaub 3eddc6cc44 Passing the temporary rendering intent to the temporary sketch layer. Related Point.js changes in r8831. r=elemoine (closes #1634)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8890 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-02-25 14:38:26 +00:00
Tim Schaub dd70dceef9 Correcting what was a mistake in r8805. Original patch was good. The autoPan property should default to false. Apologies for the failing tests. r=crschmidt (closes #1770)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8841 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-02-05 22:45:52 +00:00
Tim Schaub 41670499b1 Adding vertexmodified, sketchmodified, and sketchcomplete events to the vector layer. These are triggered by the DrawFeature and ModifyFeature controls and let listeners know about newly drawn features and modified features. r=ahocevar (closes #1904)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8835 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-02-05 17:38:20 +00:00
Tim Schaub 742b066aa7 Add an autoPan property to the overview map. Set this to true if you want the extent marker to return to the center of the overview map after you drag it. Thanks for the patch jachym. r=me (closes #1770)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8805 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-02-03 00:52:07 +00:00
Éric Lemoine f4e616342c minor doc error & enhancement in Control.MousePostion, p=aabt, r=me (closes #1872)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8494 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-12-12 08:37:48 +00:00
Éric Lemoine 887ad9677c PanZoomBar: slider can still get out of panzoombar area, all unit tests pass, p=bartvde, r=me (closes #1864)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8424 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-12-03 08:27:01 +00:00
Tim Schaub d5950d4b29 Draw and modify controls now set feature state. No longer do we need to check feature state in app code in cases where features are created or modified with these controls. r=elemoine,ahocevar (closes #1833)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8382 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-16 18:26:39 +00:00
crschmidt 93d8fa3a9a Add more comments to NavToolbar.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8321 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-11 12:12:15 +00:00
Éric Lemoine 7c0fadd14a ModifyFeature makes SelectFeature control behave/become like ModifyFeature, patch=bjornharrtell,tschaub, r=tschaub,me (closes #1741)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8302 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-07 08:46:02 +00:00
crschmidt d9adcf5a4e Support changing the modification key used to draw the zoomBox, from Jachym
with minor modifications. (Closes #1769)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@8285 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-05 21:53:34 +00:00
crschmidt 7c7809466a Fix a typo in documentation pointed out by MonkZ on IRC.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8194 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-10-24 22:17:46 +00:00
crschmidt cb1150ca88 add 'deprecated' comment to docs
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8151 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-10-20 17:06:50 +00:00
Frédéric Junod 6b6f207ae7 Add copyright headers and 'Inherits from'. Comments only modification.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8037 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-09-19 06:00:17 +00:00
Frédéric Junod 032c6c22ad fix typo in comment
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8032 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-09-18 13:25:36 +00:00
euzuro 01682a6da7 Fixing erroneously set default for right-click handlers. Thanks to senior schmidt for pointing out this oversight on my part, and for the quick reviw. (Pullup #1735)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8021 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-09-16 16:23:43 +00:00
euzuro 0fbc6c2500 Fix for Permalink's override-able createParams() function, which was designed to allow for input parameter values for center, zoom, and layers... but was actually only using the center value... zoom and layers were being taken from the map and the input parameters ignored. Big thanks to our anonymous poster for spotting this. r=ahocevar (Pullup #1489)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7986 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-09-09 15:53:09 +00:00
euzuro f935c599d1 Added a control for drawing geometries and returning basic metrics (length / area). Patch by tschaub, review by elemoine. (Closes #1241)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7965 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-09-05 15:07:59 +00:00
euzuro 4ae2e45083 Fixing example to only do the conditional inclusion on ie6 and below and adding some explanatory comments in the example file and also in the actual controls themselves. No functional change to library (only to example file)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7956 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-09-04 22:05:05 +00:00
euzuro 5084ea6a91 Add new ZoomPanel and PanPanel, a step towards a more easily customizable look for OpenLayers. Work on this ticket was done by a slew of contributors, and reviews as well. Thanks especially to tschaub for the ie6 trick and concomittant non-alpha images. (Closes #1400).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7950 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-09-04 19:21:59 +00:00
ahocevar 59826983c6 made permalink control more configurable by adding an argParserClass property and separating the logic for generating the key-value pairs from the div and link generation. Original patch by tcoulter. r=euzuro,me (closes #1489)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7881 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-27 19:33:49 +00:00
euzuro 17160f49e0 Add support in OL for right-click capturing, including dbl-right-clicks (for zooming out in navigation control). Thanks to David Martin for this nice patch and the great 8 foot austrian for his review (Closes #1359)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7872 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-26 23:27:04 +00:00
ahocevar 00192b64ab Added support for different projections for main map and overview map. Patch by bartvde. Modifications to the original patch:
* caclulation of resolution factor no longer depends on proj4js,
 * created a member variable for the resolution factor and moved the calculation of the resolution factor to createMap(),
 * created acceptance test (tests/manual/overviewmap-projection.html).
r=me (closes #1620)

git-svn-id: http://svn.openlayers.org/trunk/openlayers@7864 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-26 14:54:48 +00:00
Frédéric Junod f086ba17b4 keep the cursor style to 'move' if the cursor is above a feature. r=elemoine (closes #1673)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7713 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-08 13:34:59 +00:00
crschmidt 693e6d07e3 Fix for Feature handler uses getFeatureFromEvent on mousemove even without
hover callbacks; r=ahocevar (Closes #1655) 

This means that On the SelectFeature control hover can no longer be set on the
SelectFeature control after the control has been initialized: must be passed at
initialize time. Example has been updated. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7682 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-03 02:06:31 +00:00
crschmidt 64fc4fcb1b Patch from funky_c to move all alert()s in the library to a single
OpenLayers.Console.userError function. This allows for easy overriding of this
function for people who need to report errors at an application level (or
hiding these errors entirely), with the same default behavior as previous
releases. Patch from funky_c, r=me, (Closes #1651)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7675 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-01 22:21:50 +00:00
crschmidt e7ebdc8aa0 Non unique HTMLElement in Control, fix put together by sbenthall.
Tests pass, etc. (Closes #1396) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7666 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-01 18:21:56 +00:00
crschmidt 09b4073636 * Fixes to the Keyboard Handler to make it work better --
* drop keypress event (not used, registers as keydown in IE< which results
      in double events) 
    * return evt instead of evt.keyCode || evt.charCode, so apps can do
      whatever they like best
 * adjust ModifyFeature to new API
 * Adjust KeyboardDefaults to new API, and include a new set of keyCodes
    in switch statement to catch more cases
 * Include keyboard defaults test in list-tests.

Patch from tcoulter, work from Pedro Simonetti (See #1108), Paul Spencer,
myself. r=pagameba,me (Closes #1292)   


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7644 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-31 17:45:16 +00:00
Tim Schaub 66a4c6fb0e Caching array length instead of accessing it with each iteration. r=crschmidt (closes #1636)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7627 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-31 04:44:25 +00:00
Tim Schaub 6897c8ed4d Adding a beforefeatureselected event to the vector layer events. If a listener returns false, the feature is not selected. The modify feature control now listens for beforefeatureselected and triggers beforefeaturemodified. If a listener returns false, feature modification never begins. r=elemione,ahocevar (closes #1427)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7616 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 22:03:40 +00:00
crschmidt 61c528f3af Change getMousePosition to only be called automatically *if* the 'includeXY'
flag on the Events object is set to true. This ends up meaning that we save a
lot of unneccesary getMousePosition calls because (for example) the layer
doesn't need to include the .xy property. In addition, we add in speed
improvements via caching to the getMousePosition, courtesy the work from
pgiraud (which was worked on further by tcoulter) -- this results in
significantly improved getMousePosition performance improvements in 'real life'
situations that are more like the cases that people use OpenLayers, with a
higher number of containing divs (and also clearly demonstrate a gain in
performance even in the simple case.)

The end result is: 
 * In typical map movement over the map, (n / n+1) fewer calls to
   getMousePosition, where n is the number of active layers when dragging over
   the map.
 * In the simple case, 40% faster getMousePosition performance -- and in 
   more complex cases, significantly more performance improvements.

To drop the former improvement, which may affect some applications (as
described in the includeXY documentation) simply set:

  OpenLayers.Events.prototype.includeXY = true;

This will restore the 'every element has an xy property always' behavior
that was the case beore this patch. 

r=me,tschaub, work by pgiraud related to (See #1509), and (Closes #1459)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7615 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 21:23:19 +00:00
Éric Lemoine c2c23cb3f3 modify feature control must use silent:true when removing/destroying vertices, p=me, r=crschmidt (closes #1562)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7614 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 20:26:13 +00:00
euzuro eb417ff61c adding types to properties from the mousing improvements patch. No functional change, only documentation. (See #1509)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7612 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 18:40:23 +00:00
crschmidt bc06972aea patch for improved mousedragging. We were able to test this on my eeepc
and get a very obvious speedup in performance. This adds a configurable
'interval' to the dragpan control (and an interval to the 'drag' control,
defaulting to 0px). Patch put together by tcoulter. (Closes #1509) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7608 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 16:27:48 +00:00
Tim Schaub 309877a48c Adding a featureadded event to the draw feature control event types. First tests ever for the draw feature control. Thanks sbenthall for the patch. r=me (closes #1508)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7601 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 03:41:22 +00:00
crschmidt 8c59d55658 Redraw control.panel when toggle controls are activated. Patch by
sbenthall (yay), r=me, (Closes #895) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7597 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-30 00:40:32 +00:00
Tim Schaub a88ad8dc50 Adding a box property to the SelectFeature control for selecting all features within a box. p=pgiraud, r=me,crschmidt (closes #1071)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7589 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-29 18:20:19 +00:00
Frédéric Junod f8bf59445c Use css sprites technique to simplify the NavigationHistory controls. r=tschaub. (Closes #1555)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7422 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-06-23 06:56:58 +00:00
crschmidt 6135c8daab several minor coding standards changes. no functional change.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7396 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-06-20 11:56:17 +00:00
crschmidt c2b892acb9 Committed in wrong directory; this was meant to go to the sandbox. Reverting with
'svn merge -r 7381:7380 .'


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7382 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-06-19 18:45:22 +00:00
crschmidt b78e26e9f0 break out post-rendering into seperate function to be defined in page. This
removes the tie between the LayerSwitcher and Ext that I had in my first
commit. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7381 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-06-19 18:44:25 +00:00
pgiraud 4340867918 add a map getUnits method, r=ahocevar (Closes 1591)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7374 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-06-18 08:57:02 +00:00
Tim Schaub a98aacedd2 Adding px units where appropriate in style properties. Thanks Wally Atkins for the original patch. r=me (closes #1582)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7341 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-06-10 20:39:03 +00:00
Schuyler Erle cd5c316eba Permalink requires ArgParser. Arg!
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7290 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-05-30 09:16:39 +00:00
Éric Lemoine 34ff282397 ND changes in the modify feature control. Thanks ahocevar for catching the erroneous comment in handleKeypress. No fonctional change.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7213 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-05-17 20:11:45 +00:00
Éric Lemoine e02e7504c5 MousePosition: numDigits inconsistency, reported by kthy, patch by kthy, additional test by me, r=me (closes #1544)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7163 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-05-13 20:52:01 +00:00
Éric Lemoine 9190e24bcd Cannot modify a feature (linestring) that have two points at the same position, r=me, thanks pvalsecc for the patch and the detailed justification of this patch. (closes #1533)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7061 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-05-05 06:55:07 +00:00
Tim Schaub 209f8f68f8 Fixing links in documentation. Other Natural Docs changes. (closes #1504)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6833 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-04-09 16:52:08 +00:00
Paul Spencer d7bbcab4df spelling mistake in comment.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6810 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-04-07 18:38:13 +00:00
ahocevar 7251cb438f fixed typo: replaced styleVirtual with virtualStyle, so it matches the API property. r=crschmidt (pullup #1495)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6802 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-04-07 08:07:25 +00:00