ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
2,906 Commits 5 Branches 232 Tags
07ff407da56d2a366f5631d0818ad62f19c97dfa
Commit Graph

103 Commits

Author SHA1 Message Date
euzuro
17160f49e0 Add support in OL for right-click capturing, including dbl-right-clicks (for zooming out in navigation control). Thanks to David Martin for this nice patch and the great 8 foot austrian for his review (Closes #1359) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7872 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-08-26 23:27:04 +00:00
Tim Schaub
66a4c6fb0e Caching array length instead of accessing it with each iteration. r=crschmidt (closes #1636) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7627 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-07-31 04:44:25 +00:00
crschmidt
61c528f3af Change getMousePosition to only be called automatically *if* the 'includeXY' 
flag on the Events object is set to true. This ends up meaning that we save a
lot of unneccesary getMousePosition calls because (for example) the layer
doesn't need to include the .xy property. In addition, we add in speed
improvements via caching to the getMousePosition, courtesy the work from
pgiraud (which was worked on further by tcoulter) -- this results in
significantly improved getMousePosition performance improvements in 'real life'
situations that are more like the cases that people use OpenLayers, with a
higher number of containing divs (and also clearly demonstrate a gain in
performance even in the simple case.)

The end result is: 
 * In typical map movement over the map, (n / n+1) fewer calls to
   getMousePosition, where n is the number of active layers when dragging over
   the map.
 * In the simple case, 40% faster getMousePosition performance -- and in 
   more complex cases, significantly more performance improvements.

To drop the former improvement, which may affect some applications (as
described in the includeXY documentation) simply set:

  OpenLayers.Events.prototype.includeXY = true;

This will restore the 'every element has an xy property always' behavior
that was the case beore this patch. 

r=me,tschaub, work by pgiraud related to (See #1509), and (Closes #1459)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7615 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-07-30 21:23:19 +00:00
euzuro
5ac8bd6a89 fix broken register() on events r=tschaub (Closes #1502) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7610 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-07-30 17:10:04 +00:00
euzuro
6f2818252c reverting accidental commit from r7584 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7585 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-07-29 14:57:01 +00:00
euzuro
2fb730674a patch to make sure main openlayers map div has neither padding nor margin. done via css thanks to tim's fabulous new class manip patch. r=cr5 (Closes #1179) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7584 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-07-29 14:52:48 +00:00
crschmidt
ffab22ba19 2.6 introduced a regression that maps could not be created when the Object 
prototype is extended. Although OpenLayers is not designed to work when this
fundamental violation of Javascript is in place, we can at least not fail
so miserably in this case: this gets us back to a similar level of 
functionality as we had in 2.5. This was brought up by a user working on 
a viamichelin layer, which apparently extends the object prototype (bad!),
and fixed in conjuction with tschaub. r=pgiraud,tschaub (Pullup #1502)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6832 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-04-09 16:06:23 +00:00
Tim Schaub
894c457fdd Adding eventListeners property to layer, control, and map. Setting this property at construction registers the given listeners based on event type key. r=elemoine (closes #1404) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6435 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-03-05 00:07:46 +00:00
Frédéric Junod
32d541641d fix typos and missing documentation in ND comments. (non-functional changes) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6200 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-11 09:54:21 +00:00
Tim Schaub
f27833f1db Trigger feature related events with feature information and layer related events with layer information. Also adding events.on and events.un convenience methods. r=crschmidt (closes #1343) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6149 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-08 23:31:27 +00:00
ahocevar
92b4894e33 "Tests Broken on IE6". This adds an additional check that prevents IE6 from complaining about undefined properties. r=crschmidt (closes #1322) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6021 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-02-07 19:46:04 +00:00
crschmidt
09e0d3ec81 Update copyrights to 2008. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5614 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2008-01-01 08:14:55 +00:00
Tim Schaub
33e313b059 Separating jsdoc style docs into their own block. The new NaturalDocs doesn't parse these mixed blocks, giving us no class descriptions with the two together. (closes #1229) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5553 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-21 08:28:09 +00:00
Tim Schaub
3e652566e8 triggerEvent can now be called with additional arguments for the listeners - this means instead of getting news like 'hey, someone won the lottery' listeners now get news like 'hey, you won the lottery' - in addition, the triggerer gets back the return from the listener, so if a listener wants to say 'dont tell anyone else' the triggerer gets that message - thanks for the reviews (closes #1189) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5398 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-13 17:30:52 +00:00
euzuro
a13cacdde9 protect stopObserving() from trying to remove nonexistant events. thx for review, cr5 (Closes #1151) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5241 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-11-21 18:50:55 +00:00
Paul Spencer
3e9beffc99 large scale syntactic clean up adding missing semi-colons and curly braces around blocks. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5002 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-10-18 12:27:35 +00:00
crschmidt
ed3221441c Refactor SVN layout in compliance with RFC/LicenseChange. This hopefully 
completes an important blocker for moving forward with OSGeo incubation. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4985 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-10-17 02:21:22 +00:00
Tim Schaub
2478677985 Deprecating all prototype extensions. This puts all OpenLayers functionality in the OpenLayers namespace. If you are using any of the Function, String, or Number prototype extensions, start using the functional equivalents in the OpenLayers namespace - the prototype extensions will be gone in 3.0 (closes #712). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4302 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-14 20:08:47 +00:00
euzuro
9724bbaeee Here we have finally solved the smashing of the Event object problem. Once and forall. God save the queen when 3.0 comes we're getting rid of this sloppiness. See r4040 for more info on why we've done all this. (Closes #880) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4271 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-13 23:17:44 +00:00
Tim Schaub
c2148651ed Filling our log with cruft, adding meaningless conflicts for merges, and changing a comment style that ndocs could care less about, this commit changes Return to Returns (closes #945). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4110 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-29 18:44:10 +00:00
crschmidt
807449046b Commit fix for an off-by-two error on standards complaint HTML pages in IE, and 
add an HTML example that can be used as an acceptance test. (Closes #863) 
Thanks pierre for the research and report!


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4098 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-29 04:03:13 +00:00
crschmidt
b9a1287a5f "Event object conflict: If you include OpenLayers.js AFTER including 
prototype.js, this effectively replaces most of prototype's Event object with
the OpenLayers.Event object, which has undesirable results (i.e. calling
Event.observe is actually calling OpenLayers.Event.observe)." Fixed by
only creating Event is Event does not already exist. (Closes #880)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4040 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-25 07:39:28 +00:00
crschmidt
6194452b8a Since John already went ahead and committed the main change, I'm just going 
to finish this one up. All commits are in comments, so a review doesn't seem
strictly neccesary. This closes #918 and fixes all the copyrights that I could 
find in the code.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3984 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-23 11:29:06 +00:00
euzuro
cf5a53959e ND Update: make array's say what they're made of, and a few other small bits, like mistyped and a couple missing <>s 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3829 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-31 20:02:03 +00:00
euzuro
8c552be94b as universally approved on discussions on dev list, replace new Array() with []. all tests pass ff & ie6 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3815 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-25 22:48:02 +00:00
euzuro
5f0bde51da as universally approved on discussions on dev list, replace new Object() with {}. all tests pass ff & ie6 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3814 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-25 22:39:28 +00:00
euzuro
fd4d2918f1 fix for #853 - remove JSDOC comments from CLASS_NAME variables 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3787 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-23 15:09:09 +00:00
Tim Schaub
cc1b0269c9 #823 New class style. Instead of OldStyle = Class.create(); OldStyle.prototype = Class.inherit(Parent, prototype), we now use NewStyle = OpenLayers.Class(Parent, prototype). New style classes allow for backwards compatibility [you can use OldStyle = Class.create(); Class.inherit(NewStyle, prototype)]. The Class.create and Class.inherit functions are deprecated. Backwards compatibility will be removed at 3.0. Thanks Erik for the careful review. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3767 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-16 20:25:11 +00:00
Tim Schaub
f1d9208abd replacing tabs with spaces 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3684 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-10 21:40:26 +00:00
euzuro
a14b5bdc7e patch for #809 - add the addEventType() function to the OpenLayers.Events objects so that subclasses can safely add new event types without modifying their parents' constant values 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3622 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-06 18:30:09 +00:00
euzuro
bee797430d update nd docs for Openlayers.Events 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3621 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-06 17:47:38 +00:00
euzuro
a74a9bd49f remove *private* statements from nd comments 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3620 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-06 17:38:20 +00:00
euzuro
23bc407f8b update nd for OpenLayer.Event object 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3599 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-05 20:02:29 +00:00
crschmidt
3948913bfc Merge all changes from the naturaldocs sandbox. This brings all the work that 
has been done in the NaturalDocs branch back to trunk. Thanks to everyone who
helped out in making this happen. (I could list people, but the list would
be long, and I'm already mentally on vacation.)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3545 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-06-29 15:59:20 +00:00
euzuro
23131012dd fix for #624 - merge stop() and safeStopPropagation() 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2994 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-04-03 17:15:57 +00:00
euzuro
10b5c2df17 patch for #621 - assign items in the elements hash table a unique cacheID instead of relying on the element's actual 'id' property. thx for thorough review sde 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2993 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-04-03 16:54:14 +00:00
euzuro
d0115ccf26 patch for #625 - remove extraneous _observeAndCache() function which is only used once. it doesnt seem to conceptually abstract anything, so lets inline it 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2991 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-04-03 15:54:27 +00:00
euzuro
33cb7fd0d4 patch for #623 - remove unused pointerX() and pointerY() functions 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2990 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-04-03 15:38:16 +00:00
euzuro
9aa92d491c events.js cleanup: more ifs without brackets 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2989 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-04-03 01:42:21 +00:00
euzuro
7aac1c1cfe coding standards. if statement without brackets and multiple return 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2988 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-04-03 01:38:22 +00:00
euzuro
8440cbaf43 coding standards if statement should always be followed by braces. also, add comment 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2987 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-04-03 01:37:04 +00:00
euzuro
2734030a82 move unloadCache() down so that stopObserving and stopObservingElement() are next to eachother 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2986 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-04-03 01:31:45 +00:00
euzuro
2f8a093f83 move observe() function up to right before its private counterpart 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2985 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-04-03 01:27:39 +00:00
euzuro
ade794259f move observers definition to top of object definition for readability 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2984 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-04-03 01:26:39 +00:00
euzuro
8007b6719a events.js: style (never underestimate style) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2983 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-04-02 23:12:55 +00:00
euzuro
ed0fca9157 events cleanup: fix tabs 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2982 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-04-02 23:00:55 +00:00
euzuro
dfa4441646 step one of cleaning up events.js: jsdoc 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2981 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-04-02 22:49:13 +00:00
crschmidt
474064b4e5 Clean up all events, not just some of them. Cleans up possible memory leaks. 
Closes #604, patch by Erik. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2947 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-03-31 19:47:05 +00:00
crschmidt
53b23bdf37 make stopObserving/stopObservingElement more resilient: can accept either 
elements or ids. Closes #603 (and makes #604 work).


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2946 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-03-31 19:46:04 +00:00
euzuro
aa4cca057d patch for #585 - delete row from hash instead of nullifying it. thx tim for quick approval 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2929 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-03-29 21:17:12 +00:00