Commit Graph

30 Commits

Author SHA1 Message Date
crschmidt
04f911085d Last patch from #581 , use stopObservingElement, not stopObserving.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2927 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 18:02:43 +00:00
crschmidt
8d725697ba Erik and I discussed this, and the destroy() here actually does the wrong thing.
the innerHTML still prevents the memory leak, but unregistering in this way
doesn't do the right thing. remove it. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2926 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 17:21:27 +00:00
crschmidt
6c67b3a0e3 By setting the innerHTML of the icon, we tell browsers they can clean up the
memory associated with those images. This completes #581, and reduces the 
memory used by applications where adding and removing of many markers 
is used.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2925 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 16:25:52 +00:00
crschmidt
dcd550ff31 Give icons a less generic ID, for helpful debuggin in the future.
(Part of #581)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2924 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 16:24:09 +00:00
Schuyler Erle
619ae89ef4 Don't automatically display Icons when moveTo() is called with a non-null pixel location. Fixes #553. Thanks Ali Lucio for finding this bug.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2916 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 22:29:43 +00:00
crschmidt
786c2a20fb Change files to point to repository-license. Part of build process will now
be to change the licensing terms in the final build.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@1721 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-10-24 18:16:39 +00:00
Schuyler Erle
3be99e67e6 Convert all classes to use new-style class definitions. All tests pass.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1651 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-10-06 15:57:33 +00:00
Schuyler Erle
67ced536c0 Merged r1559:r1587 from source:/sandbox/crschmidt/noprototype. OpenLayers is now Prototype-free(tm).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1588 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-10-05 14:50:47 +00:00
euzuro
91505ff5d6 make default behaviour for an icon with no specified offset or calcuateOffset() function be to have a standard calculateOffset() function setting the offset point at the center of the icon
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1553 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-10-03 20:51:39 +00:00
euzuro
348b0b388d allow for setting opacity of alpha image divs. also give both Icon and Marker setOpacity() functions. added tests and modified examples/markers.html to show how to do it.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1541 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-10-03 17:36:03 +00:00
euzuro
c1b8c8dd60 change the '@require:' to '@requires' so as to be compatible with JSDOC standards. put these directly inside the class definition comment block. update script to suggest this and update all source files to follow pattern. Caught a missing @requires in the EventPane.js file
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1206 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-08-14 23:05:05 +00:00
euzuro
f3a072b151 new layerswitcher, improved google layer, boxes layer, grid fix
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1096 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-08-08 18:20:24 +00:00
euzuro
718d84d6d2 when cloning an icon, set the calculateOffset() function too, if it exists.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@877 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-07-04 15:30:11 +00:00
euzuro
ff0e83d0a0 bringing all changes from sandbox/euzuro/LayersReworking down into the trunk. this is a merge of r656:HEAD http://svn.openlayers.org/sandbox/euzuro/LayersReworking
git-svn-id: http://svn.openlayers.org/trunk/openlayers@806 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-06-27 23:16:26 +00:00
Schuyler Erle
ead31f6dc6 Added license headers to all JS source files.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@657 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-06-21 15:22:48 +00:00
euzuro
b73c7bbaed give Icon a destroy(). this fixes issue introduced in r520
git-svn-id: http://svn.openlayers.org/trunk/openlayers@523 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-06-05 18:14:30 +00:00
euzuro
e2782f1ad5 Make a default icon sized 20x20. If anyone can think of a better default size, feel free to change this.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@454 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-29 18:19:17 +00:00
euzuro
51aaf18b59 implement dynamic offset (pass in calculateOffset() function) and implement dynamic alpha-safe sizing. I realize some tests still fail. I have to run out for some errands, will be back in 3-4 hours to fix this (namely text layer still has issues. fear not, i will fix these)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@450 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-29 13:54:38 +00:00
euzuro
bf5b1f3171 move 'image' member from marker down to Icon.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@446 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-29 11:59:14 +00:00
euzuro
8d13a79340 reset default Icon offset to 0,0
git-svn-id: http://svn.openlayers.org/trunk/openlayers@439 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-29 09:43:31 +00:00
crschmidt
1408a26b58 Our default marker is designed to be positioned above and centered on a point. Change it so that Icon.js does this by default.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@423 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-27 13:10:41 +00:00
euzuro
cd07fd2a93 make Icon's default offset 0,0. nullify a few more tests... :-)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@414 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-27 00:35:01 +00:00
euzuro
93f9f38b35 need to make sure a size has been declared before trying to set the offset. thank you automated testing for finding this one.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@130 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-18 05:25:09 +00:00
euzuro
bb55859445 remove unused diff and diffABS functions from OpenLayers.Pixel
git-svn-id: http://svn.openlayers.org/trunk/openlayers@129 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-18 05:19:51 +00:00
euzuro
6b43a2d977 JSDOC / coding standards for OpenLayers.Icon
git-svn-id: http://svn.openlayers.org/trunk/openlayers@128 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-18 05:09:39 +00:00
euzuro
2086a1ad95 add 'offset' member to OpenLayers.Icon - and then use it in OpenLayers.Marker
git-svn-id: http://svn.openlayers.org/trunk/openlayers@127 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-18 05:04:06 +00:00
crschmidt
4eec3dae7a Add new tests for Icon cloning. Modify Icon.js to correct incorrect case in constructor call in clone().
git-svn-id: http://svn.openlayers.org/trunk/openlayers@109 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-17 17:32:03 +00:00
crschmidt
04ca5d3695 Create a clone method for Icon.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@108 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-17 17:25:27 +00:00
crschmidt
66edc6dcb7 Fill out more of Icon and Marker classes. In the XP world, supposedly we test first -- and I actually did in this case. Kind of a nifty trick: you work out what the function is supposed to do solely from the tests you want to write, and then you go and actually write the code that does it.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@87 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-17 12:16:23 +00:00
crschmidt
70d425580c Add empty class definitions for Icon, Marker to be filled in as part of bugs #5 and #6 respectively
git-svn-id: http://svn.openlayers.org/trunk/openlayers@85 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-05-17 03:50:53 +00:00