ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add method for retrieving ol.Overlay by id

Browse Source
This commit is contained in:
jonataswalker
2015-10-14 16:01:48 -03:00
parent d29e5eaef1
commit fce065e185
5 changed files with 30 additions and 117 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
test/spec/ol/map.test.js
View File

@@ -346,80 +346,36 @@ describe('ol.Map', function() {
it('returns an overlay by id', function() {
overlay = new ol.Overlay({
element: overlay_target,
position: [0, 0]
});
overlay.setId('foo');
map.addOverlay(overlay);
expect(map.getOverlayById('foo')).to.be(overlay);
});
it('returns an overlay by id (set after add)', function() {
overlay = new ol.Overlay({
id: 'foo',
element: overlay_target,
position: [0, 0]
});
map.addOverlay(overlay);
expect(map.getOverlayById('foo')).to.be(null);
overlay.setId('foo');
expect(map.getOverlayById('foo')).to.be(overlay);
});
it('returns null when no overlay is found', function() {
overlay = new ol.Overlay({
id: 'foo',
element: overlay_target,
position: [0, 0]
});
overlay.setId('foo');
map.addOverlay(overlay);
expect(map.getOverlayById('bar')).to.be(null);
});
it('returns null after removing overlay', function() {
overlay = new ol.Overlay({
id: 'foo',
element: overlay_target,
position: [0, 0]
});
overlay.setId('foo');
map.addOverlay(overlay);
expect(map.getOverlayById('foo')).to.be(overlay);
map.removeOverlay(overlay);
expect(map.getOverlayById('foo')).to.be(null);
});
it('returns correct overlay after add/remove/add', function() {
expect(map.getOverlayById('foo')).to.be(null);
var first = new ol.Overlay({
element: overlay_target,
position: [0, 0]
});
first.setId('foo');
map.addOverlay(first);
expect(map.getOverlayById('foo')).to.be(first);
map.removeOverlay(first);
expect(map.getOverlayById('foo')).to.be(null);
var second = new ol.Overlay({
element: overlay_target,
position: [0, 0]
});
second.setId('foo');
map.addOverlay(second);
expect(map.getOverlayById('foo')).to.be(second);
});
it('returns correct overlay after add/change', function() {
expect(map.getOverlayById('foo')).to.be(null);
overlay = new ol.Overlay({
element: overlay_target,
position: [0, 0]
});
overlay.setId('foo');
map.addOverlay(overlay);
expect(map.getOverlayById('foo')).to.be(overlay);
overlay.setId('bar');
expect(map.getOverlayById('foo')).to.be(null);
expect(map.getOverlayById('bar')).to.be(overlay);
});
});
});

29
test/spec/ol/overlay.test.js
View File

@@ -41,34 +41,33 @@ describe('ol.Overlay', function() {
});
describe('#setId()', function() {
describe('#getId()', function() {
var overlay, target;
beforeEach(function() {
target = document.createElement('div');
overlay = new ol.Overlay({
element: target,
position: [0, 0]
});
map.addOverlay(overlay);
});
afterEach(function() {
map.removeOverlay(overlay);
});
it('sets the overlay identifier', function() {
it('returns the overlay identifier', function() {
overlay = new ol.Overlay({
element: target,
position: [0, 0]
});
map.addOverlay(overlay);
expect(overlay.getId()).to.be(undefined);
overlay.setId('foo');
map.removeOverlay(overlay);
overlay = new ol.Overlay({
id: 'foo',
element: target,
position: [0, 0]
});
map.addOverlay(overlay);
expect(overlay.getId()).to.be('foo');
});
it('accepts a string or number', function() {
overlay.setId('foo');
expect(overlay.getId()).to.be('foo');
overlay.setId(2);
expect(overlay.getId()).to.be(2);
});
});
});