From b3127f86be6653f9175ba7ddd989b5cc08ce9400 Mon Sep 17 00:00:00 2001
From: Florent gravin <florent.gravin@camptocamp.com>
Date: Tue, 18 Sep 2018 13:28:58 +0200
Subject: [PATCH 01/11] Fix cast for Geometry type

---
 src/ol/Feature.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/ol/Feature.js b/src/ol/Feature.js
index 8cab579b20..db419cf62a 100644
--- a/src/ol/Feature.js
+++ b/src/ol/Feature.js
@@ -101,8 +101,8 @@ class Feature extends BaseObject {
     if (opt_geometryOrProperties !== undefined) {
       if (opt_geometryOrProperties instanceof Geometry ||
           !opt_geometryOrProperties) {
-        /** @type {?Geometry} */
-        const geometry = opt_geometryOrProperties;
+
+        const geometry = /** @type {?Geometry} */ (opt_geometryOrProperties);
         this.setGeometry(geometry);
       } else {
         /** @type {Object<string, *>} */

From 109f16f71793b6248f15f9effff62c71a3a3f315 Mon Sep 17 00:00:00 2001
From: Florent gravin <florent.gravin@camptocamp.com>
Date: Tue, 18 Sep 2018 13:44:24 +0200
Subject: [PATCH 02/11] Use Geometry instead of
 import(./geom/Geometry.js).default

---
 src/ol/Feature.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/ol/Feature.js b/src/ol/Feature.js
index db419cf62a..fe5c1be24d 100644
--- a/src/ol/Feature.js
+++ b/src/ol/Feature.js
@@ -54,7 +54,7 @@ import Style from './style/Style.js';
  */
 class Feature extends BaseObject {
   /**
-   * @param {import("./geom/Geometry.js").default|Object<string, *>=} opt_geometryOrProperties
+   * @param {Geometry|Object<string, *>=} opt_geometryOrProperties
    *     You may pass a Geometry object directly, or an object literal containing
    *     properties. If you pass an object literal, you may include a Geometry
    *     associated with a `geometry` key.
@@ -136,13 +136,13 @@ class Feature extends BaseObject {
    * Get the feature's default geometry.  A feature may have any number of named
    * geometries.  The "default" geometry (the one that is rendered by default) is
    * set when calling {@link module:ol/Feature~Feature#setGeometry}.
-   * @return {import("./geom/Geometry.js").default|undefined} The default geometry for the feature.
+   * @return {Geometry|undefined} The default geometry for the feature.
    * @api
    * @observable
    */
   getGeometry() {
     return (
-      /** @type {import("./geom/Geometry.js").default|undefined} */ (this.get(this.geometryName_))
+      /** @type {Geometry|undefined} */ (this.get(this.geometryName_))
     );
   }
 
@@ -214,7 +214,7 @@ class Feature extends BaseObject {
   /**
    * Set the default geometry for the feature.  This will update the property
    * with the name returned by {@link module:ol/Feature~Feature#getGeometryName}.
-   * @param {import("./geom/Geometry.js").default|undefined} geometry The new geometry.
+   * @param {Geometry|undefined} geometry The new geometry.
    * @api
    * @observable
    */

From 7f32ba42168fa4ea9f2e3883b2f945e33600ff2c Mon Sep 17 00:00:00 2001
From: Florent gravin <florent.gravin@camptocamp.com>
Date: Tue, 18 Sep 2018 13:44:52 +0200
Subject: [PATCH 03/11] Use Style instead of import(./style/Style.js).default

---
 src/ol/Feature.js | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/ol/Feature.js b/src/ol/Feature.js
index fe5c1be24d..3a3d4cf014 100644
--- a/src/ol/Feature.js
+++ b/src/ol/Feature.js
@@ -78,7 +78,7 @@ class Feature extends BaseObject {
     /**
      * User provided style.
      * @private
-     * @type {import("./style/Style.js").default|Array<import("./style/Style.js").default>|import("./style/Style.js").StyleFunction}
+     * @type {Style|Array<Style>|import("./style/Style.js").StyleFunction}
      */
     this.style_ = null;
 
@@ -171,7 +171,7 @@ class Feature extends BaseObject {
   /**
    * Get the feature's style. Will return what was provided to the
    * {@link module:ol/Feature~Feature#setStyle} method.
-   * @return {import("./style/Style.js").default|Array<import("./style/Style.js").default>|import("./style/Style.js").StyleFunction} The feature style.
+   * @return {Style|Array<Style>|import("./style/Style.js").StyleFunction} The feature style.
    * @api
    */
   getStyle() {
@@ -226,7 +226,7 @@ class Feature extends BaseObject {
    * Set the style for the feature.  This can be a single style object, an array
    * of styles, or a function that takes a resolution and returns an array of
    * styles. If it is `null` the feature has no style (a `null` style).
-   * @param {import("./style/Style.js").default|Array<import("./style/Style.js").default>|import("./style/Style.js").StyleFunction} style Style for this feature.
+   * @param {Style|Array<Style>|import("./style/Style.js").StyleFunction} style Style for this feature.
    * @api
    * @fires module:ol/events/Event~Event#event:change
    */
@@ -272,9 +272,9 @@ class Feature extends BaseObject {
 
 /**
  * Convert the provided object into a feature style function.  Functions passed
- * through unchanged.  Arrays of import("./style/Style.js").default or single style objects wrapped
+ * through unchanged.  Arrays of Style or single style objects wrapped
  * in a new feature style function.
- * @param {import("./style/Style.js").StyleFunction|!Array<import("./style/Style.js").default>|!import("./style/Style.js").default} obj
+ * @param {import("./style/Style.js").StyleFunction|!Array<Style>|!Style} obj
  *     A feature style function, a single style, or an array of styles.
  * @return {import("./style/Style.js").StyleFunction} A style function.
  */
@@ -283,7 +283,7 @@ export function createStyleFunction(obj) {
     return obj;
   } else {
     /**
-     * @type {Array<import("./style/Style.js").default>}
+     * @type {Array<Style>}
      */
     let styles;
     if (Array.isArray(obj)) {

From bd655b325dc9f123081a7ca9ce3d2bdbc7beafcd Mon Sep 17 00:00:00 2001
From: Florent gravin <florent.gravin@camptocamp.com>
Date: Tue, 18 Sep 2018 14:04:53 +0200
Subject: [PATCH 04/11] Implement Geometry containsXY with correct signature

---
 src/ol/geom/Geometry.js | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/src/ol/geom/Geometry.js b/src/ol/geom/Geometry.js
index 887602fba3..88c1ab702e 100644
--- a/src/ol/geom/Geometry.js
+++ b/src/ol/geom/Geometry.js
@@ -247,12 +247,20 @@ class Geometry extends BaseObject {
           0, 0);
         transform2D(inCoordinates, 0, inCoordinates.length, stride,
           tmpTransform, outCoordinates);
-        return getTransform(source, destination)(inCoordinates, outCoordinates, stride);
+        return getTransform(sourceProj, destination)(inCoordinates, outCoordinates, stride);
       } :
-      getTransform(source, destination);
+      getTransform(sourceProj, destination);
     this.applyTransform(transformFn);
     return this;
   }
+
+  /**
+   * @param {number} x X.
+   * @param {number} y Y.
+   * @return {boolean} Contains (x, y).
+   */
+  containsXY = function(x, y) { return false};
+
 }
 
 

From cd169ede0d311a42c192ce979e4a84c59b6c0e17 Mon Sep 17 00:00:00 2001
From: Florent gravin <florent.gravin@camptocamp.com>
Date: Tue, 18 Sep 2018 14:05:29 +0200
Subject: [PATCH 05/11] Correct cast of Projection in Geometry.transform

---
 src/ol/geom/Geometry.js | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/ol/geom/Geometry.js b/src/ol/geom/Geometry.js
index 88c1ab702e..8c5cd360a9 100644
--- a/src/ol/geom/Geometry.js
+++ b/src/ol/geom/Geometry.js
@@ -235,11 +235,12 @@ class Geometry extends BaseObject {
    * @api
    */
   transform(source, destination) {
-    source = getProjection(source);
-    const transformFn = source.getUnits() == Units.TILE_PIXELS ?
+    /** @type {import("../proj/Projection.js").default} */
+    const sourceProj =  getProjection(source);
+    const transformFn = sourceProj.getUnits() == Units.TILE_PIXELS ?
       function(inCoordinates, outCoordinates, stride) {
-        const pixelExtent = source.getExtent();
-        const projectedExtent = source.getWorldExtent();
+        const pixelExtent = sourceProj.getExtent();
+        const projectedExtent = sourceProj.getWorldExtent();
         const scale = getHeight(projectedExtent) / getHeight(pixelExtent);
         composeTransform(tmpTransform,
           projectedExtent[0], projectedExtent[3],

From d062904cc1c55be9328c876626a326b51bd31a07 Mon Sep 17 00:00:00 2001
From: Florent gravin <florent.gravin@camptocamp.com>
Date: Tue, 18 Sep 2018 14:13:50 +0200
Subject: [PATCH 06/11] Correct ol event type propagation in Geolocation
 positionError

---
 src/ol/Geolocation.js | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/ol/Geolocation.js b/src/ol/Geolocation.js
index f58127ddb3..2cac07da18 100644
--- a/src/ol/Geolocation.js
+++ b/src/ol/Geolocation.js
@@ -174,9 +174,12 @@ class Geolocation extends BaseObject {
    * @param {PositionError} error error object.
    */
   positionError_(error) {
-    error.type = EventType.ERROR;
+    const event = {
+      type: EventType.ERROR,
+      target: undefined
+    };
     this.setTracking(false);
-    this.dispatchEvent(/** @type {{type: string, target: undefined}} */ (error));
+    this.dispatchEvent(event);
   }
 
   /**

From e740e7577a70ee3eb0f090e1816ffdda76e5e722 Mon Sep 17 00:00:00 2001
From: Florent gravin <florent.gravin@camptocamp.com>
Date: Tue, 18 Sep 2018 14:57:59 +0200
Subject: [PATCH 07/11] Secure type of HTMLImageElement in ImageTile

---
 src/ol/ImageTile.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/ol/ImageTile.js b/src/ol/ImageTile.js
index dcf604787c..bb172b07e6 100644
--- a/src/ol/ImageTile.js
+++ b/src/ol/ImageTile.js
@@ -114,7 +114,8 @@ class ImageTile extends Tile {
    * @private
    */
   handleImageLoad_() {
-    if (this.image_.naturalWidth && this.image_.naturalHeight) {
+    if (this.image_ instanceof HTMLImageElement &&
+      this.image_.naturalWidth && this.image_.naturalHeight) {
       this.state = TileState.LOADED;
     } else {
       this.state = TileState.EMPTY;

From f3fb88905ec5249db89df855da19fe57173bc717 Mon Sep 17 00:00:00 2001
From: Florent gravin <florent.gravin@camptocamp.com>
Date: Tue, 18 Sep 2018 14:58:20 +0200
Subject: [PATCH 08/11] Use window.setTimeout for correct type checking

---
 src/ol/MapBrowserEventHandler.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ol/MapBrowserEventHandler.js b/src/ol/MapBrowserEventHandler.js
index 4659e66579..b056157ee7 100644
--- a/src/ol/MapBrowserEventHandler.js
+++ b/src/ol/MapBrowserEventHandler.js
@@ -127,7 +127,7 @@ class MapBrowserEventHandler extends EventTarget {
       this.dispatchEvent(newEvent);
     } else {
       // click
-      this.clickTimeoutId_ = setTimeout(function() {
+      this.clickTimeoutId_ = window.setTimeout(function() {
         this.clickTimeoutId_ = 0;
         const newEvent = new MapBrowserPointerEvent(
           MapBrowserEventType.SINGLECLICK, this.map_, pointerEvent);

From 25ade660175f8f685f557080bf7036fe17d347bb Mon Sep 17 00:00:00 2001
From: Florent gravin <florent.gravin@camptocamp.com>
Date: Tue, 18 Sep 2018 15:06:12 +0200
Subject: [PATCH 09/11] Fix type conflict between Event and events/Event.js

---
 src/ol/pointer/PointerEvent.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/ol/pointer/PointerEvent.js b/src/ol/pointer/PointerEvent.js
index 11dce303c8..f5c4f15949 100644
--- a/src/ol/pointer/PointerEvent.js
+++ b/src/ol/pointer/PointerEvent.js
@@ -32,7 +32,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-import Event from '../events/Event.js';
+import _Event from '../events/Event.js';
 
 
 /**
@@ -42,7 +42,7 @@ import Event from '../events/Event.js';
 let HAS_BUTTONS = false;
 
 
-class PointerEvent extends Event {
+class PointerEvent extends _Event {
 
   /**
    * A class for pointer events.

From 8b833712726dc200af4eee7e1da2180050e39588 Mon Sep 17 00:00:00 2001
From: Florent gravin <florent.gravin@camptocamp.com>
Date: Tue, 18 Sep 2018 13:40:25 +0200
Subject: [PATCH 10/11] Feature opt_geometryOrProperties cannot be null

---
 src/ol/Feature.js            | 5 ++---
 src/ol/geom/Geometry.js      | 6 ++++--
 test/spec/ol/feature.test.js | 2 +-
 3 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/ol/Feature.js b/src/ol/Feature.js
index 3a3d4cf014..d03b5905cf 100644
--- a/src/ol/Feature.js
+++ b/src/ol/Feature.js
@@ -99,10 +99,9 @@ class Feature extends BaseObject {
       this.handleGeometryChanged_, this);
 
     if (opt_geometryOrProperties !== undefined) {
-      if (opt_geometryOrProperties instanceof Geometry ||
-          !opt_geometryOrProperties) {
+      if (opt_geometryOrProperties instanceof Geometry) {
 
-        const geometry = /** @type {?Geometry} */ (opt_geometryOrProperties);
+        const geometry = /** @type {Geometry} */ (opt_geometryOrProperties);
         this.setGeometry(geometry);
       } else {
         /** @type {Object<string, *>} */
diff --git a/src/ol/geom/Geometry.js b/src/ol/geom/Geometry.js
index 8c5cd360a9..9d353dc888 100644
--- a/src/ol/geom/Geometry.js
+++ b/src/ol/geom/Geometry.js
@@ -236,7 +236,7 @@ class Geometry extends BaseObject {
    */
   transform(source, destination) {
     /** @type {import("../proj/Projection.js").default} */
-    const sourceProj =  getProjection(source);
+    const sourceProj = getProjection(source);
     const transformFn = sourceProj.getUnits() == Units.TILE_PIXELS ?
       function(inCoordinates, outCoordinates, stride) {
         const pixelExtent = sourceProj.getExtent();
@@ -260,7 +260,9 @@ class Geometry extends BaseObject {
    * @param {number} y Y.
    * @return {boolean} Contains (x, y).
    */
-  containsXY = function(x, y) { return false};
+  containsXY(x, y) {
+    return false;
+  }
 
 }
 
diff --git a/test/spec/ol/feature.test.js b/test/spec/ol/feature.test.js
index 3e1980a7f8..16dee02871 100644
--- a/test/spec/ol/feature.test.js
+++ b/test/spec/ol/feature.test.js
@@ -102,7 +102,7 @@ describe('ol.Feature', function() {
 
     it('returns null for null geometry (constructor)', function() {
       const feature = new Feature(null);
-      expect(feature.getGeometry()).to.be(null);
+      expect(feature.getGeometry()).to.be(undefined);
     });
 
     it('returns null for null geometry (setGeometry())', function() {

From 9c6e14b05013c22776592857820d63c850d12c98 Mon Sep 17 00:00:00 2001
From: Florent gravin <florent.gravin@camptocamp.com>
Date: Wed, 19 Sep 2018 16:51:43 +0200
Subject: [PATCH 11/11] Remove duplicate containsXY fn

---
 src/ol/geom/Geometry.js | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/src/ol/geom/Geometry.js b/src/ol/geom/Geometry.js
index 9d353dc888..db0f44d270 100644
--- a/src/ol/geom/Geometry.js
+++ b/src/ol/geom/Geometry.js
@@ -255,15 +255,6 @@ class Geometry extends BaseObject {
     return this;
   }
 
-  /**
-   * @param {number} x X.
-   * @param {number} y Y.
-   * @return {boolean} Contains (x, y).
-   */
-  containsXY(x, y) {
-    return false;
-  }
-
 }