ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

protect for in loops with hasOwnProperty

Browse Source
This commit is contained in:
Bart van den Eijnden
2012-02-29 18:43:55 +01:00
parent d7a3ecac08
commit e3cc96dbfb
31 changed files with 385 additions and 266 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/OpenLayers/BaseTypes/Class.js
View File

@@ -91,9 +91,11 @@ OpenLayers.Util.extend = function(destination, source) {
destination = destination || {}; destination = destination || {};
if (source) { if (source) {
for (var property in source) { for (var property in source) {
var value = source[property]; if (source.hasOwnProperty(property)) {
if (value !== undefined) { var value = source[property];
destination[property] = value; if (value !== undefined) {
destination[property] = value;
}
} }
} }

16
lib/OpenLayers/Control/GetFeature.js
View File

@@ -258,7 +258,9 @@ OpenLayers.Control.GetFeature = OpenLayers.Class(OpenLayers.Control, {
activate: function () { activate: function () {
if (!this.active) { if (!this.active) {
for(var i in this.handlers) { for(var i in this.handlers) {
this.handlers[i].activate(); if (this.handlers.hasOwnProperty(i)) {
this.handlers[i].activate();
}
} }
} }
return OpenLayers.Control.prototype.activate.apply( return OpenLayers.Control.prototype.activate.apply(
@@ -276,7 +278,9 @@ OpenLayers.Control.GetFeature = OpenLayers.Class(OpenLayers.Control, {
deactivate: function () { deactivate: function () {
if (this.active) { if (this.active) {
for(var i in this.handlers) { for(var i in this.handlers) {
this.handlers[i].deactivate(); if (this.handlers.hasOwnProperty(i)) {
this.handlers[i].deactivate();
}
} }
} }
return OpenLayers.Control.prototype.deactivate.apply( return OpenLayers.Control.prototype.deactivate.apply(
@@ -560,7 +564,9 @@ OpenLayers.Control.GetFeature = OpenLayers.Class(OpenLayers.Control, {
unselectAll: function() { unselectAll: function() {
// we'll want an option to supress notification here // we'll want an option to supress notification here
for(var fid in this.features) { for(var fid in this.features) {
this.unselect(this.features[fid]); if (this.features.hasOwnProperty(fid)) {
this.unselect(this.features[fid]);
}
} }
}, },
@@ -573,7 +579,9 @@ OpenLayers.Control.GetFeature = OpenLayers.Class(OpenLayers.Control, {
*/ */
setMap: function(map) { setMap: function(map) {
for(var i in this.handlers) { for(var i in this.handlers) {
this.handlers[i].setMap(map); if (this.handlers.hasOwnProperty(i)) {
this.handlers[i].setMap(map);
}
} }
OpenLayers.Control.prototype.setMap.apply(this, arguments); OpenLayers.Control.prototype.setMap.apply(this, arguments);
}, },

54
lib/OpenLayers/Control/NavigationHistory.js
View File

@@ -193,7 +193,9 @@ OpenLayers.Control.NavigationHistory = OpenLayers.Class(OpenLayers.Control, {
this.next.destroy(); this.next.destroy();
this.deactivate(); this.deactivate();
for(var prop in this) { for(var prop in this) {
this[prop] = null; if (this.hasOwnProperty(prop)) {
this[prop] = null;
}
} }
}, },
@@ -334,25 +336,27 @@ OpenLayers.Control.NavigationHistory = OpenLayers.Class(OpenLayers.Control, {
setListeners: function() { setListeners: function() {
this.listeners = {}; this.listeners = {};
for(var type in this.registry) { for(var type in this.registry) {
this.listeners[type] = OpenLayers.Function.bind(function() { if (this.registry.hasOwnProperty(type)) {
if(!this.restoring) { this.listeners[type] = OpenLayers.Function.bind(function() {
var state = this.registry[type].apply(this, arguments); if(!this.restoring) {
this.previousStack.unshift(state); var state = this.registry[type].apply(this, arguments);
if(this.previousStack.length > 1) { this.previousStack.unshift(state);
this.onPreviousChange( if(this.previousStack.length > 1) {
this.previousStack[1], this.previousStack.length - 1 this.onPreviousChange(
); this.previousStack[1], this.previousStack.length - 1
);
}
if(this.previousStack.length > (this.limit + 1)) {
this.previousStack.pop();
}
if(this.nextStack.length > 0) {
this.nextStack = [];
this.onNextChange(null, 0);
}
} }
if(this.previousStack.length > (this.limit + 1)) { return true;
this.previousStack.pop(); }, this);
} }
if(this.nextStack.length > 0) {
this.nextStack = [];
this.onNextChange(null, 0);
}
}
return true;
}, this);
} }
}, },
@@ -371,7 +375,9 @@ OpenLayers.Control.NavigationHistory = OpenLayers.Class(OpenLayers.Control, {
this.setListeners(); this.setListeners();
} }
for(var type in this.listeners) { for(var type in this.listeners) {
this.map.events.register(type, this, this.listeners[type]); if (this.listeners.hasOwnProperty(type)) {
this.map.events.register(type, this, this.listeners[type]);
}
} }
activated = true; activated = true;
if(this.previousStack.length == 0) { if(this.previousStack.length == 0) {
@@ -405,9 +411,11 @@ OpenLayers.Control.NavigationHistory = OpenLayers.Class(OpenLayers.Control, {
if(this.map) { if(this.map) {
if(OpenLayers.Control.prototype.deactivate.apply(this)) { if(OpenLayers.Control.prototype.deactivate.apply(this)) {
for(var type in this.listeners) { for(var type in this.listeners) {
this.map.events.unregister( if (this.listeners.hasOwnProperty(type)) {
type, this, this.listeners[type] this.map.events.unregister(
); type, this, this.listeners[type]
);
}
} }
if(this.clearOnDeactivate) { if(this.clearOnDeactivate) {
this.clear(); this.clear();

13
lib/OpenLayers/Control/SLDSelect.js
View File

@@ -168,11 +168,16 @@ OpenLayers.Control.SLDSelect = OpenLayers.Class(OpenLayers.Control, {
* Take care of things that are not handled in superclass. * Take care of things that are not handled in superclass.
*/ */
destroy: function() { destroy: function() {
for (var key in this.layerCache) { var key;
delete this.layerCache[key]; for (key in this.layerCache) {
if (this.layerCache.hasOwnProperty(key)) {
delete this.layerCache[key];
}
} }
for (var key in this.wfsCache) { for (key in this.wfsCache) {
delete this.wfsCache[key]; if (this.wfsCache.hasOwnProperty(key)) {
delete this.wfsCache[key];
}
} }
OpenLayers.Control.prototype.destroy.apply(this, arguments); OpenLayers.Control.prototype.destroy.apply(this, arguments);
}, },

10
lib/OpenLayers/Control/WMSGetFeatureInfo.js
View File

@@ -456,10 +456,12 @@ OpenLayers.Control.WMSGetFeatureInfo = OpenLayers.Class(OpenLayers.Control, {
} }
var layers; var layers;
for (var url in services) { for (var url in services) {
layers = services[url]; if (services.hasOwnProperty(url)) {
var wmsOptions = this.buildWMSOptions(url, layers, layers = services[url];
clickPosition, layers[0].params.FORMAT); var wmsOptions = this.buildWMSOptions(url, layers,
OpenLayers.Request.GET(wmsOptions); clickPosition, layers[0].params.FORMAT);
OpenLayers.Request.GET(wmsOptions);
}
} }
} }
}, },

14
lib/OpenLayers/Format/GML/Base.js
View File

@@ -564,12 +564,14 @@ OpenLayers.Format.GML.Base = OpenLayers.Class(OpenLayers.Format.XML, {
this.writeNode("feature:_geometry", feature.geometry, node); this.writeNode("feature:_geometry", feature.geometry, node);
} }
for(var name in feature.attributes) { for(var name in feature.attributes) {
var value = feature.attributes[name]; if (feature.attributes.hasOwnProperty(name)) {
if(value != null) { var value = feature.attributes[name];
this.writeNode( if(value != null) {
"feature:_attribute", this.writeNode(
{name: name, value: value}, node "feature:_attribute",
); {name: name, value: value}, node
);
}
} }
} }
return node; return node;

18
lib/OpenLayers/Format/GeoRSS.js
View File

@@ -325,15 +325,17 @@ OpenLayers.Format.GeoRSS = OpenLayers.Class(OpenLayers.Format.XML, {
featureNode.appendChild(linkNode); featureNode.appendChild(linkNode);
} }
for(var attr in feature.attributes) { for(var attr in feature.attributes) {
if (attr == "link" || attr == "title" || attr == "description") { continue; } if (feature.attributes.hasOwnProperty(attr)) {
var attrText = this.createTextNode(feature.attributes[attr]); if (attr == "link" || attr == "title" || attr == "description") { continue; }
var nodename = attr; var attrText = this.createTextNode(feature.attributes[attr]);
if (attr.search(":") != -1) { var nodename = attr;
nodename = attr.split(":")[1]; if (attr.search(":") != -1) {
nodename = attr.split(":")[1];
}
var attrContainer = this.createElementNS(this.featureNS, "feature:"+nodename);
attrContainer.appendChild(attrText);
featureNode.appendChild(attrContainer);
} }
var attrContainer = this.createElementNS(this.featureNS, "feature:"+nodename);
attrContainer.appendChild(attrText);
featureNode.appendChild(attrContainer);
} }
featureNode.appendChild(geometryNode); featureNode.appendChild(geometryNode);
return featureNode; return featureNode;

64
lib/OpenLayers/Format/OSM.js
View File

@@ -140,33 +140,35 @@ OpenLayers.Format.OSM = OpenLayers.Class(OpenLayers.Format.XML, {
feat_list[i] = feat; feat_list[i] = feat;
} }
for (var node_id in nodes) { for (var node_id in nodes) {
var node = nodes[node_id]; if (nodes.hasOwnProperty(node_id)) {
if (!node.used || this.checkTags) { var node = nodes[node_id];
var tags = null; if (!node.used || this.checkTags) {
var tags = null;
if (this.checkTags) { if (this.checkTags) {
var result = this.getTags(node.node, true); var result = this.getTags(node.node, true);
if (node.used && !result[1]) { if (node.used && !result[1]) {
continue; continue;
}
tags = result[0];
} else {
tags = this.getTags(node.node);
} }
tags = result[0];
} else {
tags = this.getTags(node.node);
}
var feat = new OpenLayers.Feature.Vector( var feat = new OpenLayers.Feature.Vector(
new OpenLayers.Geometry.Point(node['lon'], node['lat']), new OpenLayers.Geometry.Point(node['lon'], node['lat']),
tags); tags);
if (this.internalProjection && this.externalProjection) { if (this.internalProjection && this.externalProjection) {
feat.geometry.transform(this.externalProjection, feat.geometry.transform(this.externalProjection,
this.internalProjection); this.internalProjection);
}
feat.osm_id = parseInt(node_id);
feat.fid = "node." + feat.osm_id;
feat_list.push(feat);
} }
feat.osm_id = parseInt(node_id); // Memory cleanup
feat.fid = "node." + feat.osm_id; node.node = null;
feat_list.push(feat);
} }
// Memory cleanup
node.node = null;
} }
return feat_list; return feat_list;
}, },
@@ -273,9 +275,11 @@ OpenLayers.Format.OSM = OpenLayers.Class(OpenLayers.Format.XML, {
} }
if (this.checkTags) { if (this.checkTags) {
for(var key in way.tags) { for(var key in way.tags) {
if (this.areaTags[key]) { if (way.tags.hasOwnProperty(key)) {
poly_tags = true; if (this.areaTags[key]) {
break; poly_tags = true;
break;
}
} }
} }
} }
@@ -430,10 +434,12 @@ OpenLayers.Format.OSM = OpenLayers.Class(OpenLayers.Format.XML, {
*/ */
serializeTags: function(feature, node) { serializeTags: function(feature, node) {
for (var key in feature.attributes) { for (var key in feature.attributes) {
var tag = this.createElementNS(null, "tag"); if (feature.attributes.hasOwnProperty(key)) {
tag.setAttribute("k", key); var tag = this.createElementNS(null, "tag");
tag.setAttribute("v", feature.attributes[key]); tag.setAttribute("k", key);
node.appendChild(tag); tag.setAttribute("v", feature.attributes[key]);
node.appendChild(tag);
}
} }
}, },

32
lib/OpenLayers/Format/SLD/v1.js
View File

@@ -541,9 +541,11 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.Filter.v1_0_0, {
getCssProperty: function(sym) { getCssProperty: function(sym) {
var css = null; var css = null;
for(var prop in this.cssMap) { for(var prop in this.cssMap) {
if(this.cssMap[prop] == sym) { if (this.cssMap.hasOwnProperty(prop)) {
css = prop; if(this.cssMap[prop] == sym) {
break; css = prop;
break;
}
} }
} }
return css; return css;
@@ -565,12 +567,14 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.Filter.v1_0_0, {
getGraphicFormat: function(href) { getGraphicFormat: function(href) {
var format, regex; var format, regex;
for(var key in this.graphicFormats) { for(var key in this.graphicFormats) {
if(this.graphicFormats[key].test(href)) { if (this.graphicFormats.hasOwnProperty(key)) {
format = key; if(this.graphicFormats[key].test(href)) {
break; format = key;
break;
}
} }
} }
return format || this.defautlGraphicFormat; return format || this.defaultGraphicFormat;
}, },
/** /**
@@ -676,7 +680,9 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.Filter.v1_0_0, {
} }
} else { } else {
for(var name in sld.namedLayers) { for(var name in sld.namedLayers) {
this.writeNode("NamedLayer", sld.namedLayers[name], root); if (sld.namedLayers.hasOwnProperty(name)) {
this.writeNode("NamedLayer", sld.namedLayers[name], root);
}
} }
} }
return root; return root;
@@ -769,11 +775,13 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.Filter.v1_0_0, {
ruleMap[zIndex].symbolizers.push(symbolizer.clone()); ruleMap[zIndex].symbolizers.push(symbolizer.clone());
} }
for (zIndex in ruleMap) { for (zIndex in ruleMap) {
if (!(zIndex in rulesByZ)) { if (ruleMap.hasOwnProperty(zIndex)) {
zValues.push(zIndex); if (!(zIndex in rulesByZ)) {
rulesByZ[zIndex] = []; zValues.push(zIndex);
rulesByZ[zIndex] = [];
}
rulesByZ[zIndex].push(ruleMap[zIndex]);
} }
rulesByZ[zIndex].push(ruleMap[zIndex]);
} }
} else { } else {
// no symbolizers in rule // no symbolizers in rule

10
lib/OpenLayers/Format/SLD/v1_0_0_GeoServer.js
View File

@@ -128,10 +128,12 @@ OpenLayers.Format.SLD.v1_0_0_GeoServer = OpenLayers.Class(
var options = symbolizer.vendorOptions; var options = symbolizer.vendorOptions;
if (options) { if (options) {
for (var key in symbolizer.vendorOptions) { for (var key in symbolizer.vendorOptions) {
this.writeNode("VendorOption", { if (symbolizer.vendorOptions.hasOwnProperty(key)) {
name: key, this.writeNode("VendorOption", {
value: symbolizer.vendorOptions[key] name: key,
}, node); value: symbolizer.vendorOptions[key]
}, node);
}
} }
} }
return node; return node;

8
lib/OpenLayers/Format/SOSGetObservation.js
View File

@@ -210,10 +210,14 @@ OpenLayers.Format.SOSGetObservation = OpenLayers.Class(OpenLayers.Format.XML, {
this.writeNode("eventTime", options, node); this.writeNode("eventTime", options, node);
} }
for (var procedure in options.procedures) { for (var procedure in options.procedures) {
this.writeNode("procedure", options.procedures[procedure], node); if (options.procedures.hasOwnProperty(procedure)) {
this.writeNode("procedure", options.procedures[procedure], node);
}
} }
for (var observedProperty in options.observedProperties) { for (var observedProperty in options.observedProperties) {
this.writeNode("observedProperty", options.observedProperties[observedProperty], node); if (options.observedProperties.hasOwnProperty(observedProperty)) {
this.writeNode("observedProperty", options.observedProperties[observedProperty], node);
}
} }
if (options.foi) { if (options.foi) {
this.writeNode("featureOfInterest", options.foi, node); this.writeNode("featureOfInterest", options.foi, node);

34
lib/OpenLayers/Format/WFS.js
View File

@@ -104,14 +104,16 @@ OpenLayers.Format.WFS = OpenLayers.Class(OpenLayers.Format.GML, {
var featureContainer = this.createElementNS(this.featureNS, "feature:" + this.featureName); var featureContainer = this.createElementNS(this.featureNS, "feature:" + this.featureName);
featureContainer.appendChild(geomContainer); featureContainer.appendChild(geomContainer);
for(var attr in feature.attributes) { for(var attr in feature.attributes) {
var attrText = this.createTextNode(feature.attributes[attr]); if (feature.attributes.hasOwnProperty(attr)) {
var nodename = attr; var attrText = this.createTextNode(feature.attributes[attr]);
if (attr.search(":") != -1) { var nodename = attr;
nodename = attr.split(":")[1]; if (attr.search(":") != -1) {
nodename = attr.split(":")[1];
}
var attrContainer = this.createElementNS(this.featureNS, "feature:" + nodename);
attrContainer.appendChild(attrText);
featureContainer.appendChild(attrContainer);
} }
var attrContainer = this.createElementNS(this.featureNS, "feature:" + nodename);
attrContainer.appendChild(attrText);
featureContainer.appendChild(attrContainer);
} }
return featureContainer; return featureContainer;
}, },
@@ -166,14 +168,16 @@ OpenLayers.Format.WFS = OpenLayers.Class(OpenLayers.Format.GML, {
// add in attributes // add in attributes
for(var propName in feature.attributes) { for(var propName in feature.attributes) {
propertyNode = this.createElementNS(this.wfsns, 'wfs:Property'); if (feature.attributes.hasOwnProperty(propName)) {
nameNode = this.createElementNS(this.wfsns, 'wfs:Name'); propertyNode = this.createElementNS(this.wfsns, 'wfs:Property');
nameNode.appendChild(this.createTextNode(propName)); nameNode = this.createElementNS(this.wfsns, 'wfs:Name');
propertyNode.appendChild(nameNode); nameNode.appendChild(this.createTextNode(propName));
valueNode = this.createElementNS(this.wfsns, 'wfs:Value'); propertyNode.appendChild(nameNode);
valueNode.appendChild(this.createTextNode(feature.attributes[propName])); valueNode = this.createElementNS(this.wfsns, 'wfs:Value');
propertyNode.appendChild(valueNode); valueNode.appendChild(this.createTextNode(feature.attributes[propName]));
updateNode.appendChild(propertyNode); propertyNode.appendChild(valueNode);
updateNode.appendChild(propertyNode);
}
} }

22
lib/OpenLayers/Format/WFST/v1.js
View File

@@ -332,12 +332,14 @@ OpenLayers.Format.WFST.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
// add in attributes // add in attributes
for(var key in feature.attributes) { for(var key in feature.attributes) {
if(feature.attributes[key] !== undefined && if (feature.attributes.hasOwnProperty(key)) {
(!modified || !modified.attributes || if(feature.attributes[key] !== undefined &&
(modified.attributes && modified.attributes[key] !== undefined))) { (!modified || !modified.attributes ||
this.writeNode( (modified.attributes && modified.attributes[key] !== undefined))) {
"Property", {name: key, value: feature.attributes[key]}, node this.writeNode(
); "Property", {name: key, value: feature.attributes[key]}, node
);
}
} }
} }
@@ -410,9 +412,11 @@ OpenLayers.Format.WFST.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
var parts = []; var parts = [];
var uri; var uri;
for(var key in schemaLocations) { for(var key in schemaLocations) {
uri = this.namespaces[key]; if (schemaLocations.hasOwnProperty(key)) {
if(uri) { uri = this.namespaces[key];
parts.push(uri + " " + schemaLocations[key]); if(uri) {
parts.push(uri + " " + schemaLocations[key]);
}
} }
} }
var value = parts.join(" ") || undefined; var value = parts.join(" ") || undefined;

58
lib/OpenLayers/Format/WMC/v1.js
View File

@@ -48,8 +48,10 @@ OpenLayers.Format.WMC.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
prefix = this.namespaces[this.defaultPrefix]; prefix = this.namespaces[this.defaultPrefix];
} else { } else {
for(prefix in this.namespaces) { for(prefix in this.namespaces) {
if(this.namespaces[prefix] == uri) { if (this.namespaces.hasOwnProperty(prefix)) {
break; if(this.namespaces[prefix] == uri) {
break;
}
} }
} }
} }
@@ -674,12 +676,14 @@ OpenLayers.Format.WMC.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
setAttributes: function(node, obj) { setAttributes: function(node, obj) {
var value; var value;
for(var name in obj) { for(var name in obj) {
value = obj[name].toString(); if (obj.hasOwnProperty(name)) {
if(value.match(/[A-Z]/)) { value = obj[name].toString();
// safari lowercases attributes with setAttribute if(value.match(/[A-Z]/)) {
this.setAttributeNS(node, null, name, value); // safari lowercases attributes with setAttribute
} else { this.setAttributeNS(node, null, name, value);
node.setAttribute(name, value); } else {
node.setAttribute(name, value);
}
} }
} }
}, },
@@ -1091,25 +1095,29 @@ OpenLayers.Format.WMC.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
userValue: true userValue: true
}; };
for (var dim in context.dimensions) { for (var dim in context.dimensions) {
var attributes = {}; if (context.dimensions.hasOwnProperty(dim)) {
var dimension = context.dimensions[dim]; var attributes = {};
for (var name in dimension) { var dimension = context.dimensions[dim];
if (typeof dimension[name] == "boolean") { for (var name in dimension) {
attributes[name] = Number(dimension[name]); if (dimension.hasOwnProperty(name)) {
} else { if (typeof dimension[name] == "boolean") {
attributes[name] = dimension[name]; attributes[name] = Number(dimension[name]);
} else {
attributes[name] = dimension[name];
}
}
}
var values = "";
if (attributes.values) {
values = attributes.values.join(",");
delete attributes.values;
} }
}
var values = "";
if (attributes.values) {
values = attributes.values.join(",");
delete attributes.values;
}
node.appendChild(this.createElementDefaultNS( node.appendChild(this.createElementDefaultNS(
"Dimension", values, attributes "Dimension", values, attributes
)); ));
} }
}
return node; return node;
}, },

4
lib/OpenLayers/Format/WMC/v1_1_0.js
View File

@@ -122,7 +122,9 @@ OpenLayers.Format.WMC.v1_1_0 = OpenLayers.Class(
// optional SRS element(s) // optional SRS element(s)
if (context.srs) { if (context.srs) {
for(var name in context.srs) { for(var name in context.srs) {
node.appendChild(this.createElementDefaultNS("SRS", name)); if (context.srs.hasOwnProperty(name)) {
node.appendChild(this.createElementDefaultNS("SRS", name));
}
} }
} }

6
lib/OpenLayers/Format/WMTSCapabilities.js
View File

@@ -84,8 +84,10 @@ OpenLayers.Format.WMTSCapabilities = OpenLayers.Class(OpenLayers.Format.XML.Vers
matrixSet: true matrixSet: true
}; };
for (var prop in required) { for (var prop in required) {
if (!(prop in config)) { if (required.hasOwnProperty(prop)) {
throw new Error("Missing property '" + prop + "' in layer configuration."); if (!(prop in config)) {
throw new Error("Missing property '" + prop + "' in layer configuration.");
}
} }
} }

16
lib/OpenLayers/Format/XML.js
View File

@@ -89,7 +89,9 @@ OpenLayers.Format.XML = OpenLayers.Class(OpenLayers.Format, {
this.namespaces = OpenLayers.Util.extend({}, this.namespaces); this.namespaces = OpenLayers.Util.extend({}, this.namespaces);
this.namespaceAlias = {}; this.namespaceAlias = {};
for(var alias in this.namespaces) { for(var alias in this.namespaces) {
this.namespaceAlias[this.namespaces[alias]] = alias; if (this.namespaces.hasOwnProperty(alias)) {
this.namespaceAlias[this.namespaces[alias]] = alias;
}
} }
}, },
@@ -558,11 +560,13 @@ OpenLayers.Format.XML = OpenLayers.Class(OpenLayers.Format, {
setAttributes: function(node, obj) { setAttributes: function(node, obj) {
var value, uri; var value, uri;
for(var name in obj) { for(var name in obj) {
if(obj[name] != null && obj[name].toString) { if (obj.hasOwnProperty(name)) {
value = obj[name].toString(); if(obj[name] != null && obj[name].toString) {
// check for qualified attribute name ("prefix:local") value = obj[name].toString();
uri = this.namespaces[name.substring(0, name.indexOf(":"))] || null; // check for qualified attribute name ("prefix:local")
this.setAttributeNS(node, uri, name, value); uri = this.namespaces[name.substring(0, name.indexOf(":"))] || null;
this.setAttributeNS(node, uri, name, value);
}
} }
} }
}, },

4
lib/OpenLayers/Layer.js
View File

@@ -423,7 +423,9 @@ OpenLayers.Layer = OpenLayers.Class({
getOptions: function() { getOptions: function() {
var options = {}; var options = {};
for(var o in this.options) { for(var o in this.options) {
options[o] = this[o]; if (this.options.hasOwnProperty(o)) {
options[o] = this[o];
}
} }
return options; return options;
}, },

6
lib/OpenLayers/Layer/HTTPRequest.js
View File

@@ -218,8 +218,10 @@ OpenLayers.Layer.HTTPRequest = OpenLayers.Class(OpenLayers.Layer, {
var urlParams = var urlParams =
OpenLayers.Util.upperCaseObject(OpenLayers.Util.getParameters(url)); OpenLayers.Util.upperCaseObject(OpenLayers.Util.getParameters(url));
for(var key in allParams) { for(var key in allParams) {
if(key.toUpperCase() in urlParams) { if (allParams.hasOwnProperty(key)) {
delete allParams[key]; if(key.toUpperCase() in urlParams) {
delete allParams[key];
}
} }
} }
paramsString = OpenLayers.Util.getParameterString(allParams); paramsString = OpenLayers.Util.getParameterString(allParams);

6
lib/OpenLayers/Layer/MapGuide.js
View File

@@ -346,8 +346,10 @@ OpenLayers.Layer.MapGuide = OpenLayers.Class(OpenLayers.Layer.Grid, {
var urlParams = OpenLayers.Util.upperCaseObject( var urlParams = OpenLayers.Util.upperCaseObject(
OpenLayers.Util.getParameters(url)); OpenLayers.Util.getParameters(url));
for(var key in allParams) { for(var key in allParams) {
if(key.toUpperCase() in urlParams) { if (allParams.hasOwnProperty(key)) {
delete allParams[key]; if(key.toUpperCase() in urlParams) {
delete allParams[key];
}
} }
} }
var paramsString = OpenLayers.Util.getParameterString(allParams); var paramsString = OpenLayers.Util.getParameterString(allParams);

6
lib/OpenLayers/Layer/MapServer.js
View File

@@ -142,8 +142,10 @@ OpenLayers.Layer.MapServer = OpenLayers.Class(OpenLayers.Layer.Grid, {
var urlParams = OpenLayers.Util.upperCaseObject( var urlParams = OpenLayers.Util.upperCaseObject(
OpenLayers.Util.getParameters(url)); OpenLayers.Util.getParameters(url));
for(var key in allParams) { for(var key in allParams) {
if(key.toUpperCase() in urlParams) { if (allParams.hasOwnProperty(key)) {
delete allParams[key]; if(key.toUpperCase() in urlParams) {
delete allParams[key];
}
} }
} }
paramsString = OpenLayers.Util.getParameterString(allParams); paramsString = OpenLayers.Util.getParameterString(allParams);

6
lib/OpenLayers/Layer/Vector.js
View File

@@ -509,8 +509,10 @@ OpenLayers.Layer.Vector = OpenLayers.Class(OpenLayers.Layer, {
if(!zoomChanged && coordSysUnchanged) { if(!zoomChanged && coordSysUnchanged) {
for(var i in this.unrenderedFeatures) { for(var i in this.unrenderedFeatures) {
var feature = this.unrenderedFeatures[i]; if (this.unrenderedFeatures.hasOwnProperty(i)) {
this.drawFeature(feature); var feature = this.unrenderedFeatures[i];
this.drawFeature(feature);
}
} }
} }
} }

6
lib/OpenLayers/Layer/WMTS.js
View File

@@ -229,8 +229,10 @@ OpenLayers.Layer.WMTS = OpenLayers.Class(OpenLayers.Layer.Grid, {
matrixSet: true matrixSet: true
}; };
for (var prop in required) { for (var prop in required) {
if (!(prop in config)) { if (required.hasOwnProperty(prop)) {
throw new Error("Missing property '" + prop + "' in layer configuration."); if (!(prop in config)) {
throw new Error("Missing property '" + prop + "' in layer configuration.");
}
} }
} }

6
lib/OpenLayers/Protocol/Script.js
View File

@@ -135,7 +135,7 @@ OpenLayers.Protocol.Script = OpenLayers.Class(OpenLayers.Protocol, {
}); });
this.filterToParams = function(filter, params) { this.filterToParams = function(filter, params) {
return format.write(filter, params); return format.write(filter, params);
} };
} }
}, },
@@ -311,7 +311,9 @@ OpenLayers.Protocol.Script = OpenLayers.Class(OpenLayers.Protocol, {
this.destroyRequest(response.priv); this.destroyRequest(response.priv);
} else { } else {
for (var key in this.pendingRequests) { for (var key in this.pendingRequests) {
this.destroyRequest(this.pendingRequests[key]); if (this.pendingRequests.hasOwnProperty(key)) {
this.destroyRequest(this.pendingRequests[key]);
}
} }
} }
}, },

4
lib/OpenLayers/Request.js
View File

@@ -181,7 +181,9 @@ OpenLayers.Request = {
config.method, url, config.async, config.user, config.password config.method, url, config.async, config.user, config.password
); );
for(var header in config.headers) { for(var header in config.headers) {
request.setRequestHeader(header, config.headers[header]); if (config.headers.hasOwnProperty(header)) {
request.setRequestHeader(header, config.headers[header]);
}
} }
var events = this.events; var events = this.events;

18
lib/OpenLayers/Rule.js
View File

@@ -128,7 +128,9 @@ OpenLayers.Rule = OpenLayers.Class({
*/ */
destroy: function() { destroy: function() {
for (var i in this.symbolizer) { for (var i in this.symbolizer) {
this.symbolizer[i] = null; if (this.symbolizer.hasOwnProperty(i)) {
this.symbolizer[i] = null;
}
} }
this.symbolizer = null; this.symbolizer = null;
delete this.symbolizers; delete this.symbolizers;
@@ -216,12 +218,14 @@ OpenLayers.Rule = OpenLayers.Class({
options.symbolizer = {}; options.symbolizer = {};
var value, type; var value, type;
for(var key in this.symbolizer) { for(var key in this.symbolizer) {
value = this.symbolizer[key]; if (this.symbolizer.hasOwnProperty(key)) {
type = typeof value; value = this.symbolizer[key];
if(type === "object") { type = typeof value;
options.symbolizer[key] = OpenLayers.Util.extend({}, value); if(type === "object") {
} else if(type === "string") { options.symbolizer[key] = OpenLayers.Util.extend({}, value);
options.symbolizer[key] = value; } else if(type === "string") {
options.symbolizer[key] = value;
}
} }
} }
} }

32
lib/OpenLayers/Style.js
View File

@@ -273,7 +273,9 @@ OpenLayers.Style = OpenLayers.Class({
OpenLayers.Util.extend(context, this.context); OpenLayers.Util.extend(context, this.context);
for (var i in this.propertyStyles) { for (var i in this.propertyStyles) {
style[i] = OpenLayers.Style.createLiteral(style[i], context, feature, i); if (this.propertyStyles.hasOwnProperty(i)) {
style[i] = OpenLayers.Style.createLiteral(style[i], context, feature, i);
}
} }
return style; return style;
}, },
@@ -301,14 +303,16 @@ OpenLayers.Style = OpenLayers.Class({
for (var i=0, len=rules.length; i<len; i++) { for (var i=0, len=rules.length; i<len; i++) {
symbolizer = rules[i].symbolizer; symbolizer = rules[i].symbolizer;
for (var key in symbolizer) { for (var key in symbolizer) {
value = symbolizer[key]; if (symbolizer.hasOwnProperty(key)) {
if (typeof value == "object") { value = symbolizer[key];
// symbolizer key is "Point", "Line" or "Polygon" if (typeof value == "object") {
this.addPropertyStyles(propertyStyles, value); // symbolizer key is "Point", "Line" or "Polygon"
} else { this.addPropertyStyles(propertyStyles, value);
// symbolizer is a hash of style properties } else {
this.addPropertyStyles(propertyStyles, symbolizer); // symbolizer is a hash of style properties
break; this.addPropertyStyles(propertyStyles, symbolizer);
break;
}
} }
} }
} }
@@ -329,10 +333,12 @@ OpenLayers.Style = OpenLayers.Class({
addPropertyStyles: function(propertyStyles, symbolizer) { addPropertyStyles: function(propertyStyles, symbolizer) {
var property; var property;
for (var key in symbolizer) { for (var key in symbolizer) {
property = symbolizer[key]; if (symbolizer.hasOwnProperty(key)) {
if (typeof property == "string" && property = symbolizer[key];
property.match(/\$\{\w+\}/)) { if (typeof property == "string" &&
propertyStyles[key] = true; property.match(/\$\{\w+\}/)) {
propertyStyles[key] = true;
}
} }
} }
return propertyStyles; return propertyStyles;

52
lib/OpenLayers/StyleMap.js
View File

@@ -63,19 +63,21 @@ OpenLayers.StyleMap = OpenLayers.Class({
this.styles["delete"] = style; this.styles["delete"] = style;
} else if(typeof style == "object") { } else if(typeof style == "object") {
for(var key in style) { for(var key in style) {
if(style[key] instanceof OpenLayers.Style) { if (style.hasOwnProperty(key)) {
// user passed a hash of style objects if(style[key] instanceof OpenLayers.Style) {
this.styles[key] = style[key]; // user passed a hash of style objects
} else if(typeof style[key] == "object") { this.styles[key] = style[key];
// user passsed a hash of style hashes } else if(typeof style[key] == "object") {
this.styles[key] = new OpenLayers.Style(style[key]); // user passsed a hash of style hashes
} else { this.styles[key] = new OpenLayers.Style(style[key]);
// user passed a style hash (i.e. symbolizer) } else {
this.styles["default"] = new OpenLayers.Style(style); // user passed a style hash (i.e. symbolizer)
this.styles["select"] = new OpenLayers.Style(style); this.styles["default"] = new OpenLayers.Style(style);
this.styles["temporary"] = new OpenLayers.Style(style); this.styles["select"] = new OpenLayers.Style(style);
this.styles["delete"] = new OpenLayers.Style(style); this.styles["temporary"] = new OpenLayers.Style(style);
break; this.styles["delete"] = new OpenLayers.Style(style);
break;
}
} }
} }
} }
@@ -87,7 +89,9 @@ OpenLayers.StyleMap = OpenLayers.Class({
*/ */
destroy: function() { destroy: function() {
for(var key in this.styles) { for(var key in this.styles) {
this.styles[key].destroy(); if (this.styles.hasOwnProperty(key)) {
this.styles[key].destroy();
}
} }
this.styles = null; this.styles = null;
}, },
@@ -144,15 +148,17 @@ OpenLayers.StyleMap = OpenLayers.Class({
addUniqueValueRules: function(renderIntent, property, symbolizers, context) { addUniqueValueRules: function(renderIntent, property, symbolizers, context) {
var rules = []; var rules = [];
for (var value in symbolizers) { for (var value in symbolizers) {
rules.push(new OpenLayers.Rule({ if (symbolizers.hasOwnProperty(value)) {
symbolizer: symbolizers[value], rules.push(new OpenLayers.Rule({
context: context, symbolizer: symbolizers[value],
filter: new OpenLayers.Filter.Comparison({ context: context,
type: OpenLayers.Filter.Comparison.EQUAL_TO, filter: new OpenLayers.Filter.Comparison({
property: property, type: OpenLayers.Filter.Comparison.EQUAL_TO,
value: value property: property,
}) value: value
})); })
}));
}
} }
this.styles[renderIntent].addRules(rules); this.styles[renderIntent].addRules(rules);
}, },

12
lib/OpenLayers/Tile/Image/IFrame.js
View File

@@ -163,11 +163,13 @@ OpenLayers.Tile.Image.IFrame = {
field; field;
for(var par in params) { for(var par in params) {
field = document.createElement('input'); if (params.hasOwnProperty(par)) {
field.type = 'hidden'; field = document.createElement('input');
field.name = par; field.type = 'hidden';
field.value = params[par]; field.name = par;
form.appendChild(field); field.value = params[par];
form.appendChild(field);
}
} }
return form; return form;

16
lib/OpenLayers/Tween.js
View File

@@ -127,14 +127,16 @@ OpenLayers.Tween = OpenLayers.Class({
play: function() { play: function() {
var value = {}; var value = {};
for (var i in this.begin) { for (var i in this.begin) {
var b = this.begin[i]; if (this.begin.hasOwnProperty(i)) {
var f = this.finish[i]; var b = this.begin[i];
if (b == null || f == null || isNaN(b) || isNaN(f)) { var f = this.finish[i];
throw new TypeError('invalid value for Tween'); if (b == null || f == null || isNaN(b) || isNaN(f)) {
} throw new TypeError('invalid value for Tween');
}
var c = f - b; var c = f - b;
value[i] = this.easing.apply(this, [this.time, b, c, this.duration]); value[i] = this.easing.apply(this, [this.time, b, c, this.duration]);
}
} }
this.time++; this.time++;

72
lib/OpenLayers/Util.js
View File

@@ -441,7 +441,9 @@ OpenLayers.Util.createAlphaImageDiv = function(id, px, sz, imgURL,
OpenLayers.Util.upperCaseObject = function (object) { OpenLayers.Util.upperCaseObject = function (object) {
var uObject = {}; var uObject = {};
for (var key in object) { for (var key in object) {
uObject[key.toUpperCase()] = object[key]; if (object.hasOwnProperty(key)) {
uObject[key.toUpperCase()] = object[key];
}
} }
return uObject; return uObject;
}; };
@@ -509,27 +511,29 @@ OpenLayers.Util.getParameterString = function(params) {
var paramsArray = []; var paramsArray = [];
for (var key in params) { for (var key in params) {
var value = params[key]; if (params.hasOwnProperty(key)) {
if ((value != null) && (typeof value != 'function')) { var value = params[key];
var encodedValue; if ((value != null) && (typeof value != 'function')) {
if (typeof value == 'object' && value.constructor == Array) { var encodedValue;
/* value is an array; encode items and separate with "," */ if (typeof value == 'object' && value.constructor == Array) {
var encodedItemArray = []; /* value is an array; encode items and separate with "," */
var item; var encodedItemArray = [];
for (var itemIndex=0, len=value.length; itemIndex<len; itemIndex++) { var item;
item = value[itemIndex]; for (var itemIndex=0, len=value.length; itemIndex<len; itemIndex++) {
encodedItemArray.push(encodeURIComponent( item = value[itemIndex];
(item === null || item === undefined) ? "" : item) encodedItemArray.push(encodeURIComponent(
); (item === null || item === undefined) ? "" : item)
} );
encodedValue = encodedItemArray.join(","); }
encodedValue = encodedItemArray.join(",");
}
else {
/* value is a string; simply encode */
encodedValue = encodeURIComponent(value);
}
paramsArray.push(encodeURIComponent(key) + "=" + encodedValue);
}
} }
else {
/* value is a string; simply encode */
encodedValue = encodeURIComponent(value);
}
paramsArray.push(encodeURIComponent(key) + "=" + encodedValue);
}
} }
return paramsArray.join("&"); return paramsArray.join("&");
@@ -1300,24 +1304,30 @@ OpenLayers.Util.isEquivalentUrl = function(url1, url2, options) {
var urlObj2 = OpenLayers.Util.createUrlObject(url2, options); var urlObj2 = OpenLayers.Util.createUrlObject(url2, options);
//compare all keys except for "args" (treated below) //compare all keys except for "args" (treated below)
for(var key in urlObj1) { for (var key in urlObj1) {
if(key !== "args") { if (urlObj1.hasOwnProperty(key)) {
if(urlObj1[key] != urlObj2[key]) { if(key !== "args") {
return false; if(urlObj1[key] != urlObj2[key]) {
return false;
}
} }
} }
} }
// compare search args - irrespective of order // compare search args - irrespective of order
for(var key in urlObj1.args) { for (var key in urlObj1.args) {
if(urlObj1.args[key] != urlObj2.args[key]) { if (urlObj1.args.hasOwnProperty(key)) {
return false; if(urlObj1.args[key] != urlObj2.args[key]) {
return false;
}
delete urlObj2.args[key];
} }
delete urlObj2.args[key];
} }
// urlObj2 shouldn't have any args left // urlObj2 shouldn't have any args left
for(var key in urlObj2.args) { for (var key in urlObj2.args) {
return false; if (urlObj2.args.hasOwnProperty(key)) {
return false;
}
} }
return true; return true;