protect for in loops with hasOwnProperty

lib/OpenLayers/BaseTypes/Class.js

@@ -91,11 +91,13 @@ OpenLayers.Util.extend = function(destination, source) {
     destination = destination || {};
     if (source) {
         for (var property in source) {
+            if (source.hasOwnProperty(property)) {
                 var value = source[property];
                 if (value !== undefined) {
                     destination[property] = value;
                 }
             }
+        }
 
         /**
          * IE doesn't include the toString property when iterating over an object's

lib/OpenLayers/Control/GetFeature.js

@@ -258,9 +258,11 @@ OpenLayers.Control.GetFeature = OpenLayers.Class(OpenLayers.Control, {
     activate: function () {
         if (!this.active) {
             for(var i in this.handlers) {
+                if (this.handlers.hasOwnProperty(i)) {
                     this.handlers[i].activate();
                 }
             }
+        }
         return OpenLayers.Control.prototype.activate.apply(
             this, arguments
         );
@@ -276,9 +278,11 @@ OpenLayers.Control.GetFeature = OpenLayers.Class(OpenLayers.Control, {
     deactivate: function () {
         if (this.active) {
             for(var i in this.handlers) {
+                if (this.handlers.hasOwnProperty(i)) {
                     this.handlers[i].deactivate();
                 }
             }
+        }
         return OpenLayers.Control.prototype.deactivate.apply(
             this, arguments
         );
@@ -560,8 +564,10 @@ OpenLayers.Control.GetFeature = OpenLayers.Class(OpenLayers.Control, {
     unselectAll: function() {
         // we'll want an option to supress notification here
         for(var fid in this.features) {
+            if (this.features.hasOwnProperty(fid)) {
                 this.unselect(this.features[fid]);
             }
+        }
     },
     
     /** 
@@ -573,8 +579,10 @@ OpenLayers.Control.GetFeature = OpenLayers.Class(OpenLayers.Control, {
      */
     setMap: function(map) {
         for(var i in this.handlers) {
+            if (this.handlers.hasOwnProperty(i)) {
                 this.handlers[i].setMap(map);
             }
+        }
         OpenLayers.Control.prototype.setMap.apply(this, arguments);
     },
     

lib/OpenLayers/Control/NavigationHistory.js

@@ -193,8 +193,10 @@ OpenLayers.Control.NavigationHistory = OpenLayers.Class(OpenLayers.Control, {
         this.next.destroy();
         this.deactivate();
         for(var prop in this) {
+            if (this.hasOwnProperty(prop)) {
                 this[prop] = null;
             }
+        }
     },
     
     /** 
@@ -334,6 +336,7 @@ OpenLayers.Control.NavigationHistory = OpenLayers.Class(OpenLayers.Control, {
     setListeners: function() {
         this.listeners = {};
         for(var type in this.registry) {
+            if (this.registry.hasOwnProperty(type)) {
                 this.listeners[type] = OpenLayers.Function.bind(function() {
                     if(!this.restoring) {
                         var state = this.registry[type].apply(this, arguments);
@@ -354,6 +357,7 @@ OpenLayers.Control.NavigationHistory = OpenLayers.Class(OpenLayers.Control, {
                     return true;
                 }, this);
             }
+        }
     },
 
     /**
@@ -371,8 +375,10 @@ OpenLayers.Control.NavigationHistory = OpenLayers.Class(OpenLayers.Control, {
                     this.setListeners();
                 }
                 for(var type in this.listeners) {
+                    if (this.listeners.hasOwnProperty(type)) {
                         this.map.events.register(type, this, this.listeners[type]);
                     }
+                }
                 activated = true;
                 if(this.previousStack.length == 0) {
                     this.initStack();
@@ -405,10 +411,12 @@ OpenLayers.Control.NavigationHistory = OpenLayers.Class(OpenLayers.Control, {
         if(this.map) {
             if(OpenLayers.Control.prototype.deactivate.apply(this)) {
                 for(var type in this.listeners) {
+                    if (this.listeners.hasOwnProperty(type)) {
                         this.map.events.unregister(
                             type, this, this.listeners[type]
                         );
                     }
+                }
                 if(this.clearOnDeactivate) {
                     this.clear();
                 }

lib/OpenLayers/Control/SLDSelect.js

@@ -168,12 +168,17 @@ OpenLayers.Control.SLDSelect = OpenLayers.Class(OpenLayers.Control, {
      * Take care of things that are not handled in superclass.
      */
     destroy: function() {
-        for (var key in this.layerCache) {
+        var key;
+        for (key in this.layerCache) {
+            if (this.layerCache.hasOwnProperty(key)) {
                 delete this.layerCache[key];
             }
-        for (var key in this.wfsCache) {
+        }
+        for (key in this.wfsCache) {
+            if (this.wfsCache.hasOwnProperty(key)) {
                 delete this.wfsCache[key];
             }
+        }
         OpenLayers.Control.prototype.destroy.apply(this, arguments);
     },
 

lib/OpenLayers/Control/WMSGetFeatureInfo.js

@@ -456,12 +456,14 @@ OpenLayers.Control.WMSGetFeatureInfo = OpenLayers.Class(OpenLayers.Control, {
             }
             var layers;
             for (var url in services) {
+                if (services.hasOwnProperty(url)) {
                     layers = services[url];
                     var wmsOptions = this.buildWMSOptions(url, layers, 
                         clickPosition, layers[0].params.FORMAT);
                     OpenLayers.Request.GET(wmsOptions); 
                 }
             }
+        }
     },
 
     /**

lib/OpenLayers/Format/GML/Base.js

@@ -564,6 +564,7 @@ OpenLayers.Format.GML.Base = OpenLayers.Class(OpenLayers.Format.XML, {
                     this.writeNode("feature:_geometry", feature.geometry, node);
                 }
                 for(var name in feature.attributes) {
+                    if (feature.attributes.hasOwnProperty(name)) {
                         var value = feature.attributes[name];
                         if(value != null) {
                             this.writeNode(
@@ -572,6 +573,7 @@ OpenLayers.Format.GML.Base = OpenLayers.Class(OpenLayers.Format.XML, {
                             );
                         }
                     }
+                }
                 return node;
             },
             "_geometry": function(geometry) {

lib/OpenLayers/Format/GeoRSS.js

@@ -325,6 +325,7 @@ OpenLayers.Format.GeoRSS = OpenLayers.Class(OpenLayers.Format.XML, {
             featureNode.appendChild(linkNode);
         }    
         for(var attr in feature.attributes) {
+            if (feature.attributes.hasOwnProperty(attr)) {
                 if (attr == "link" || attr == "title" || attr == "description") { continue; } 
                 var attrText = this.createTextNode(feature.attributes[attr]); 
                 var nodename = attr;
@@ -335,6 +336,7 @@ OpenLayers.Format.GeoRSS = OpenLayers.Class(OpenLayers.Format.XML, {
                 attrContainer.appendChild(attrText);
                 featureNode.appendChild(attrContainer);
             }
+        }    
         featureNode.appendChild(geometryNode);
         return featureNode;
     },    

lib/OpenLayers/Format/OSM.js

@@ -140,6 +140,7 @@ OpenLayers.Format.OSM = OpenLayers.Class(OpenLayers.Format.XML, {
             feat_list[i] = feat;
         } 
         for (var node_id in nodes) {
+            if (nodes.hasOwnProperty(node_id)) {
                 var node = nodes[node_id];
                 if (!node.used || this.checkTags) {
                     var tags = null;
@@ -168,6 +169,7 @@ OpenLayers.Format.OSM = OpenLayers.Class(OpenLayers.Format.XML, {
                 // Memory cleanup
                 node.node = null;
             }
+        }        
         return feat_list;
     },
 
@@ -273,12 +275,14 @@ OpenLayers.Format.OSM = OpenLayers.Class(OpenLayers.Format.XML, {
         }
         if (this.checkTags) {
             for(var key in way.tags) {
+                if (way.tags.hasOwnProperty(key)) {
                     if (this.areaTags[key]) {
                         poly_tags = true;
                         break;
                     }
                 }
             }
+        }    
         return poly_shaped && (this.checkTags ? poly_tags : true);            
     }, 
 
@@ -430,11 +434,13 @@ OpenLayers.Format.OSM = OpenLayers.Class(OpenLayers.Format.XML, {
      */
     serializeTags: function(feature, node) {
         for (var key in feature.attributes) {
+            if (feature.attributes.hasOwnProperty(key)) {
                 var tag = this.createElementNS(null, "tag");
                 tag.setAttribute("k", key);
                 tag.setAttribute("v", feature.attributes[key]);
                 node.appendChild(tag);
             }
+        }
     },
 
     /**

lib/OpenLayers/Format/SLD/v1.js

@@ -541,11 +541,13 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.Filter.v1_0_0, {
     getCssProperty: function(sym) {
         var css = null;
         for(var prop in this.cssMap) {
+            if (this.cssMap.hasOwnProperty(prop)) {
                 if(this.cssMap[prop] == sym) {
                     css = prop;
                     break;
                 }
             }
+        }
         return css;
     },
     
@@ -565,12 +567,14 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.Filter.v1_0_0, {
     getGraphicFormat: function(href) {
         var format, regex;
         for(var key in this.graphicFormats) {
+            if (this.graphicFormats.hasOwnProperty(key)) {
                 if(this.graphicFormats[key].test(href)) {
                     format = key;
                     break;
                 }
             }
-        return format || this.defautlGraphicFormat;
+        }
+        return format || this.defaultGraphicFormat;
     },
     
     /**
@@ -676,9 +680,11 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.Filter.v1_0_0, {
                     }
                 } else {
                     for(var name in sld.namedLayers) {
+                        if (sld.namedLayers.hasOwnProperty(name)) {
                             this.writeNode("NamedLayer", sld.namedLayers[name], root);
                         }
                     }
+                }
                 return root;
             },
             "Name": function(name) {
@@ -769,12 +775,14 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.Filter.v1_0_0, {
                                 ruleMap[zIndex].symbolizers.push(symbolizer.clone());
                             }
                             for (zIndex in ruleMap) {
+                                if (ruleMap.hasOwnProperty(zIndex)) {
                                     if (!(zIndex in rulesByZ)) {
                                         zValues.push(zIndex);
                                         rulesByZ[zIndex] = [];
                                     }
                                     rulesByZ[zIndex].push(ruleMap[zIndex]);
                                 }
+                            }
                         } else {
                             // no symbolizers in rule
                             rulesByZ[0].push(rule.clone());

lib/OpenLayers/Format/SLD/v1_0_0_GeoServer.js

@@ -128,12 +128,14 @@ OpenLayers.Format.SLD.v1_0_0_GeoServer = OpenLayers.Class(
         var options = symbolizer.vendorOptions;
         if (options) {
             for (var key in symbolizer.vendorOptions) {
+                if (symbolizer.vendorOptions.hasOwnProperty(key)) {
                     this.writeNode("VendorOption", {
                         name: key, 
                         value: symbolizer.vendorOptions[key]
                     }, node);
                 }
             }
+        }
         return node;
     },
 

lib/OpenLayers/Format/SOSGetObservation.js

@@ -210,11 +210,15 @@ OpenLayers.Format.SOSGetObservation = OpenLayers.Class(OpenLayers.Format.XML, {
                     this.writeNode("eventTime", options, node);
                 }
                 for (var procedure in options.procedures) {
+                    if (options.procedures.hasOwnProperty(procedure)) {
                         this.writeNode("procedure", options.procedures[procedure], node);
                     }
+                }
                 for (var observedProperty in options.observedProperties) {
+                    if (options.observedProperties.hasOwnProperty(observedProperty)) {
                         this.writeNode("observedProperty", options.observedProperties[observedProperty], node);
                     }
+                }
                 if (options.foi) {
                     this.writeNode("featureOfInterest", options.foi, node);
                 }

lib/OpenLayers/Format/WFS.js

@@ -104,6 +104,7 @@ OpenLayers.Format.WFS = OpenLayers.Class(OpenLayers.Format.GML, {
         var featureContainer = this.createElementNS(this.featureNS, "feature:" + this.featureName);
         featureContainer.appendChild(geomContainer);
         for(var attr in feature.attributes) {
+            if (feature.attributes.hasOwnProperty(attr)) {
                 var attrText = this.createTextNode(feature.attributes[attr]); 
                 var nodename = attr;
                 if (attr.search(":") != -1) {
@@ -113,6 +114,7 @@ OpenLayers.Format.WFS = OpenLayers.Class(OpenLayers.Format.GML, {
                 attrContainer.appendChild(attrText);
                 featureContainer.appendChild(attrContainer);
             }  
+        }  
         return featureContainer;
     },
     
@@ -166,6 +168,7 @@ OpenLayers.Format.WFS = OpenLayers.Class(OpenLayers.Format.GML, {
         
          // add in attributes
         for(var propName in feature.attributes) {
+            if (feature.attributes.hasOwnProperty(propName)) {
                 propertyNode = this.createElementNS(this.wfsns, 'wfs:Property');
                 nameNode = this.createElementNS(this.wfsns, 'wfs:Name');
                 nameNode.appendChild(this.createTextNode(propName));
@@ -175,6 +178,7 @@ OpenLayers.Format.WFS = OpenLayers.Class(OpenLayers.Format.GML, {
                 propertyNode.appendChild(valueNode);
                 updateNode.appendChild(propertyNode);
             }
+        }
         
         
         var filterNode = this.createElementNS(this.ogcns, 'ogc:Filter');

lib/OpenLayers/Format/WFST/v1.js

@@ -332,6 +332,7 @@ OpenLayers.Format.WFST.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
         
                 // add in attributes
                 for(var key in feature.attributes) {
+                    if (feature.attributes.hasOwnProperty(key)) {
                         if(feature.attributes[key] !== undefined &&
                                     (!modified || !modified.attributes ||
                                     (modified.attributes && modified.attributes[key] !== undefined))) {
@@ -340,6 +341,7 @@ OpenLayers.Format.WFST.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
                             );
                         }
                     }
+                }
                 
                 // add feature id filter
                 this.writeNode("ogc:Filter", new OpenLayers.Filter.FeatureId({
@@ -410,11 +412,13 @@ OpenLayers.Format.WFST.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
         var parts = [];
         var uri;
         for(var key in schemaLocations) {
+            if (schemaLocations.hasOwnProperty(key)) {
                 uri = this.namespaces[key];
                 if(uri) {
                     parts.push(uri + " " + schemaLocations[key]);
                 }
             }
+        }
         var value = parts.join(" ") || undefined;
         return value;
     },

lib/OpenLayers/Format/WMC/v1.js

@@ -48,11 +48,13 @@ OpenLayers.Format.WMC.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
             prefix = this.namespaces[this.defaultPrefix];
         } else {
             for(prefix in this.namespaces) {
+                if (this.namespaces.hasOwnProperty(prefix)) {
                     if(this.namespaces[prefix] == uri) {
                         break;
                     }
                 }
             }
+        }
         return prefix;
     },
     
@@ -674,6 +676,7 @@ OpenLayers.Format.WMC.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
     setAttributes: function(node, obj) {
         var value;
         for(var name in obj) {
+            if (obj.hasOwnProperty(name)) {
                 value = obj[name].toString();
                 if(value.match(/[A-Z]/)) {
                     // safari lowercases attributes with setAttribute
@@ -682,6 +685,7 @@ OpenLayers.Format.WMC.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
                     node.setAttribute(name, value);
                 }
             }
+        }
     },
 
     /**
@@ -1091,15 +1095,18 @@ OpenLayers.Format.WMC.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
              userValue: true
          };
          for (var dim in context.dimensions) {
+             if (context.dimensions.hasOwnProperty(dim)) {
                  var attributes = {};
                  var dimension = context.dimensions[dim];
                  for (var name in dimension) {
+                     if (dimension.hasOwnProperty(name)) {
                          if (typeof dimension[name] == "boolean") {
                              attributes[name] = Number(dimension[name]);
                          } else {
                              attributes[name] = dimension[name];
                          }
                      }
+                 }
                  var values = "";
                  if (attributes.values) {
                      values = attributes.values.join(",");
@@ -1110,6 +1117,7 @@ OpenLayers.Format.WMC.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
                      "Dimension", values, attributes
                  ));
             }
+        }
         return node;
     },
 

lib/OpenLayers/Format/WMC/v1_1_0.js

@@ -122,9 +122,11 @@ OpenLayers.Format.WMC.v1_1_0 = OpenLayers.Class(
         // optional SRS element(s)
         if (context.srs) {
             for(var name in context.srs) {
+                if (context.srs.hasOwnProperty(name)) {
                     node.appendChild(this.createElementDefaultNS("SRS", name));
                 }
             }
+        }
 
         // optional FormatList element
         node.appendChild(this.write_wmc_FormatList(context));

lib/OpenLayers/Format/WMTSCapabilities.js

@@ -84,10 +84,12 @@ OpenLayers.Format.WMTSCapabilities = OpenLayers.Class(OpenLayers.Format.XML.Vers
             matrixSet: true
         };
         for (var prop in required) {
+            if (required.hasOwnProperty(prop)) {
                 if (!(prop in config)) {
                     throw new Error("Missing property '" + prop + "' in layer configuration.");
                 }
             }
+        }
 
         var contents = capabilities.contents;
         var matrixSet = contents.tileMatrixSets[config.matrixSet];

lib/OpenLayers/Format/XML.js

@@ -89,8 +89,10 @@ OpenLayers.Format.XML = OpenLayers.Class(OpenLayers.Format, {
         this.namespaces = OpenLayers.Util.extend({}, this.namespaces);
         this.namespaceAlias = {};
         for(var alias in this.namespaces) {
+            if (this.namespaces.hasOwnProperty(alias)) {
                 this.namespaceAlias[this.namespaces[alias]] = alias;
             }
+        }
     },
     
     /**
@@ -558,6 +560,7 @@ OpenLayers.Format.XML = OpenLayers.Class(OpenLayers.Format, {
     setAttributes: function(node, obj) {
         var value, uri;
         for(var name in obj) {
+            if (obj.hasOwnProperty(name)) {
                 if(obj[name] != null && obj[name].toString) {
                     value = obj[name].toString();
                     // check for qualified attribute name ("prefix:local")
@@ -565,6 +568,7 @@ OpenLayers.Format.XML = OpenLayers.Class(OpenLayers.Format, {
                     this.setAttributeNS(node, uri, name, value);
                 }
             }
+        }
     },
 
     /**

lib/OpenLayers/Layer.js

@@ -423,8 +423,10 @@ OpenLayers.Layer = OpenLayers.Class({
     getOptions: function() {
         var options = {};
         for(var o in this.options) {
+            if (this.options.hasOwnProperty(o)) {
                 options[o] = this[o];
             }
+        }
         return options;
     },
     

lib/OpenLayers/Layer/HTTPRequest.js

@@ -218,10 +218,12 @@ OpenLayers.Layer.HTTPRequest = OpenLayers.Class(OpenLayers.Layer, {
         var urlParams = 
             OpenLayers.Util.upperCaseObject(OpenLayers.Util.getParameters(url));
         for(var key in allParams) {
+            if (allParams.hasOwnProperty(key)) {
                 if(key.toUpperCase() in urlParams) {
                     delete allParams[key];
                 }
             }
+        }
         paramsString = OpenLayers.Util.getParameterString(allParams);
         
         return OpenLayers.Util.urlAppend(url, paramsString);

lib/OpenLayers/Layer/MapGuide.js

@@ -346,10 +346,12 @@ OpenLayers.Layer.MapGuide = OpenLayers.Class(OpenLayers.Layer.Grid, {
         var urlParams = OpenLayers.Util.upperCaseObject(
                             OpenLayers.Util.getParameters(url));
         for(var key in allParams) {
+            if (allParams.hasOwnProperty(key)) {
                 if(key.toUpperCase() in urlParams) {
                     delete allParams[key];
                 }
             }
+        }
         var paramsString = OpenLayers.Util.getParameterString(allParams);
         
         /* MapGuide needs '+' seperating things like bounds/height/width.

lib/OpenLayers/Layer/MapServer.js

@@ -142,10 +142,12 @@ OpenLayers.Layer.MapServer = OpenLayers.Class(OpenLayers.Layer.Grid, {
         var urlParams = OpenLayers.Util.upperCaseObject(
                             OpenLayers.Util.getParameters(url));
         for(var key in allParams) {
+            if (allParams.hasOwnProperty(key)) {
                 if(key.toUpperCase() in urlParams) {
                     delete allParams[key];
                 }
             }
+        }
         paramsString = OpenLayers.Util.getParameterString(allParams);
         
         // requestString always starts with url

lib/OpenLayers/Layer/Vector.js

@@ -509,12 +509,14 @@ OpenLayers.Layer.Vector = OpenLayers.Class(OpenLayers.Layer, {
             
                 if(!zoomChanged && coordSysUnchanged) {
                     for(var i in this.unrenderedFeatures) {
+                        if (this.unrenderedFeatures.hasOwnProperty(i)) {
                             var feature = this.unrenderedFeatures[i];
                             this.drawFeature(feature);
                         }
                     }
                 }
             }
+        }
         if (!this.drawn || (!ng && (zoomChanged || !coordSysUnchanged))) {
             this.drawn = true;
             var feature;

lib/OpenLayers/Layer/WMTS.js

@@ -229,10 +229,12 @@ OpenLayers.Layer.WMTS = OpenLayers.Class(OpenLayers.Layer.Grid, {
             matrixSet: true
         };
         for (var prop in required) {
+            if (required.hasOwnProperty(prop)) {
                 if (!(prop in config)) {
                     throw new Error("Missing property '" + prop + "' in layer configuration.");
                 }
             }
+        }
 
         config.params = OpenLayers.Util.upperCaseObject(config.params);
         var args = [config.name, config.url, config.params, config];

lib/OpenLayers/Protocol/Script.js

@@ -135,7 +135,7 @@ OpenLayers.Protocol.Script = OpenLayers.Class(OpenLayers.Protocol, {
             });
             this.filterToParams = function(filter, params) {
                 return format.write(filter, params);
-            }
+            };
         }
     },
     
@@ -311,9 +311,11 @@ OpenLayers.Protocol.Script = OpenLayers.Class(OpenLayers.Protocol, {
             this.destroyRequest(response.priv);
         } else {
             for (var key in this.pendingRequests) {
+                if (this.pendingRequests.hasOwnProperty(key)) {
                     this.destroyRequest(this.pendingRequests[key]);
                 }
             }
+        }
     },
     
     /**

lib/OpenLayers/Request.js

@@ -181,8 +181,10 @@ OpenLayers.Request = {
             config.method, url, config.async, config.user, config.password
         );
         for(var header in config.headers) {
+            if (config.headers.hasOwnProperty(header)) {
                 request.setRequestHeader(header, config.headers[header]);
             }
+        }
 
         var events = this.events;
 

lib/OpenLayers/Rule.js

@@ -128,8 +128,10 @@ OpenLayers.Rule = OpenLayers.Class({
      */
     destroy: function() {
         for (var i in this.symbolizer) {
+            if (this.symbolizer.hasOwnProperty(i)) {
                 this.symbolizer[i] = null;
             }
+        }
         this.symbolizer = null;
         delete this.symbolizers;
     },
@@ -216,6 +218,7 @@ OpenLayers.Rule = OpenLayers.Class({
             options.symbolizer = {};
             var value, type;
             for(var key in this.symbolizer) {
+                if (this.symbolizer.hasOwnProperty(key)) {
                     value = this.symbolizer[key];
                     type = typeof value;
                     if(type === "object") {
@@ -225,6 +228,7 @@ OpenLayers.Rule = OpenLayers.Class({
                     }
                 }
             }
+        }
         // clone filter
         options.filter = this.filter && this.filter.clone();
         // clone context

lib/OpenLayers/Style.js

@@ -273,8 +273,10 @@ OpenLayers.Style = OpenLayers.Class({
         OpenLayers.Util.extend(context, this.context);
         
         for (var i in this.propertyStyles) {
+            if (this.propertyStyles.hasOwnProperty(i)) {
                 style[i] = OpenLayers.Style.createLiteral(style[i], context, feature, i);
             }
+        }
         return style;
     },
     
@@ -301,6 +303,7 @@ OpenLayers.Style = OpenLayers.Class({
         for (var i=0, len=rules.length; i<len; i++) {
             symbolizer = rules[i].symbolizer;
             for (var key in symbolizer) {
+                if (symbolizer.hasOwnProperty(key)) {
                     value = symbolizer[key];
                     if (typeof value == "object") {
                         // symbolizer key is "Point", "Line" or "Polygon"
@@ -312,6 +315,7 @@ OpenLayers.Style = OpenLayers.Class({
                     }
                 }
             }
+        }
         return propertyStyles;
     },
     
@@ -329,12 +333,14 @@ OpenLayers.Style = OpenLayers.Class({
     addPropertyStyles: function(propertyStyles, symbolizer) {
         var property;
         for (var key in symbolizer) {
+            if (symbolizer.hasOwnProperty(key)) {
                 property = symbolizer[key];
                 if (typeof property == "string" &&
                         property.match(/\$\{\w+\}/)) {
                     propertyStyles[key] = true;
                 }
             }
+        }
         return propertyStyles;
     },
     

lib/OpenLayers/StyleMap.js

@@ -63,6 +63,7 @@ OpenLayers.StyleMap = OpenLayers.Class({
             this.styles["delete"] = style;
         } else if(typeof style == "object") {
             for(var key in style) {
+                if (style.hasOwnProperty(key)) {
                     if(style[key] instanceof OpenLayers.Style) {
                         // user passed a hash of style objects
                         this.styles[key] = style[key];
@@ -79,6 +80,7 @@ OpenLayers.StyleMap = OpenLayers.Class({
                     }
                 }
             }
+        }
         OpenLayers.Util.extend(this, options);
     },
 
@@ -87,8 +89,10 @@ OpenLayers.StyleMap = OpenLayers.Class({
      */
     destroy: function() {
         for(var key in this.styles) {
+            if (this.styles.hasOwnProperty(key)) {
                 this.styles[key].destroy();
             }
+        }
         this.styles = null;
     },
     
@@ -144,6 +148,7 @@ OpenLayers.StyleMap = OpenLayers.Class({
     addUniqueValueRules: function(renderIntent, property, symbolizers, context) {
         var rules = [];
         for (var value in symbolizers) {
+            if (symbolizers.hasOwnProperty(value)) {
                 rules.push(new OpenLayers.Rule({
                     symbolizer: symbolizers[value],
                     context: context,
@@ -154,6 +159,7 @@ OpenLayers.StyleMap = OpenLayers.Class({
                     })
                 }));
             }
+        }
         this.styles[renderIntent].addRules(rules);
     },
 

lib/OpenLayers/Tile/Image/IFrame.js

@@ -163,12 +163,14 @@ OpenLayers.Tile.Image.IFrame = {
             field;
             
         for(var par in params) {
+            if (params.hasOwnProperty(par)) {
                 field = document.createElement('input');
                 field.type  = 'hidden';
                 field.name  = par;
                 field.value = params[par];
                 form.appendChild(field);
             }  
+        } 
 
         return form;
     },

lib/OpenLayers/Tween.js

@@ -127,6 +127,7 @@ OpenLayers.Tween = OpenLayers.Class({
     play: function() {
         var value = {};
         for (var i in this.begin) {
+            if (this.begin.hasOwnProperty(i)) {
                 var b = this.begin[i];
                 var f = this.finish[i];
                 if (b == null || f == null || isNaN(b) || isNaN(f)) {
@@ -136,6 +137,7 @@ OpenLayers.Tween = OpenLayers.Class({
                 var c = f - b;
                 value[i] = this.easing.apply(this, [this.time, b, c, this.duration]);
             }
+        }
         this.time++;
         
         if (this.callbacks && this.callbacks.eachStep) {

lib/OpenLayers/Util.js

@@ -441,8 +441,10 @@ OpenLayers.Util.createAlphaImageDiv = function(id, px, sz, imgURL,
 OpenLayers.Util.upperCaseObject = function (object) {
     var uObject = {};
     for (var key in object) {
+        if (object.hasOwnProperty(key)) {
             uObject[key.toUpperCase()] = object[key];
         }
+    }
     return uObject;
 };
 
@@ -509,6 +511,7 @@ OpenLayers.Util.getParameterString = function(params) {
     var paramsArray = [];
     
     for (var key in params) {
+        if (params.hasOwnProperty(key)) {
             var value = params[key];
             if ((value != null) && (typeof value != 'function')) {
                 var encodedValue;
@@ -531,6 +534,7 @@ OpenLayers.Util.getParameterString = function(params) {
                 paramsArray.push(encodeURIComponent(key) + "=" + encodedValue);
             }
         }
+    }
     
     return paramsArray.join("&");
 };
@@ -1300,25 +1304,31 @@ OpenLayers.Util.isEquivalentUrl = function(url1, url2, options) {
     var urlObj2 = OpenLayers.Util.createUrlObject(url2, options);
 
     //compare all keys except for "args" (treated below)
-    for(var key in urlObj1) {
+    for (var key in urlObj1) {
+        if (urlObj1.hasOwnProperty(key)) {
             if(key !== "args") {
                 if(urlObj1[key] != urlObj2[key]) {
                     return false;
                 }
             }
         }
+    }
 
     // compare search args - irrespective of order
-    for(var key in urlObj1.args) {
+    for (var key in urlObj1.args) {
+        if (urlObj1.args.hasOwnProperty(key)) {
             if(urlObj1.args[key] != urlObj2.args[key]) {
                 return false;
             }
             delete urlObj2.args[key];
         }
+    }
     // urlObj2 shouldn't have any args left
-    for(var key in urlObj2.args) {
+    for (var key in urlObj2.args) {
+        if (urlObj2.args.hasOwnProperty(key)) {
             return false;
         }
+    }
     
     return true;
 };