Refactor and optimize attributions

src/ol/base/coveragearea.js

@@ -18,15 +18,21 @@ ol.CoverageArea = function(extent) {
 };
 
 
+/**
+ * @param {ol.Extent} extent Extent.
+ * @return {boolean} Intersects.
+ */
+ol.CoverageArea.prototype.intersectsExtent = function(extent) {
+  return this.extent.intersects(extent);
+};
+
+
 /**
  * @param {ol.Extent} extent Extent.
  * @param {number} resolution Resolution.
  * @return {boolean} Intersects.
  */
-ol.CoverageArea.prototype.intersectsExtentAndResolution =
+ol.CoverageArea.prototype.intersectsExtentAndResolution = goog.abstractMethod;
-    function(extent, resolution) {
-  return this.extent.intersects(extent);
-};
 
 
 /**

src/ol/tile/tilecoveragearea.js

@@ -25,14 +25,16 @@ ol.TileCoverageArea = function(tileGrid, extent, minZ, maxZ) {
   this.tileGrid_ = tileGrid;
 
   /**
+   * @private
    * @type {number}
    */
-  this.minZ = minZ;
+  this.minZ_ = minZ;
 
   /**
+   * @private
    * @type {number}
    */
-  this.maxZ = maxZ;
+  this.maxZ_ = maxZ;
 
 };
 goog.inherits(ol.TileCoverageArea, ol.CoverageArea);
@@ -44,8 +46,17 @@ goog.inherits(ol.TileCoverageArea, ol.CoverageArea);
 ol.TileCoverageArea.prototype.intersectsExtentAndResolution =
     function(extent, resolution) {
   var z = this.tileGrid_.getZForResolution(resolution);
-  return this.minZ <= z && z <= this.maxZ &&
+  return this.intersectsExtentAndZ(extent, z);
-      goog.base(this, 'intersectsExtentAndResolution', extent, resolution);
+};
+
+
+/**
+ * @param {ol.Extent} extent Extent.
+ * @param {number} z Z.
+ * @return {boolean} Intersects.
+ */
+ol.TileCoverageArea.prototype.intersectsExtentAndZ = function(extent, z) {
+  return this.minZ_ <= z && z <= this.maxZ_ && this.intersectsExtent(extent);
 };
 
 
@@ -55,5 +66,6 @@ ol.TileCoverageArea.prototype.intersectsExtentAndResolution =
  */
 ol.TileCoverageArea.prototype.transform = function(transformFn) {
   var extent = this.extent.transform(transformFn);
-  return new ol.TileCoverageArea(this.tileGrid_, extent, this.minZ, this.maxZ);
+  return new ol.TileCoverageArea(
+      this.tileGrid_, extent, this.minZ_, this.maxZ_);
 };

src/ol/view/attribution.js

@@ -8,6 +8,7 @@ goog.require('goog.dom');
 goog.require('goog.dom.TagName');
 goog.require('goog.events');
 goog.require('goog.events.EventType');
+goog.require('goog.object');
 goog.require('goog.style');
 goog.require('ol.Collection');
 goog.require('ol.CoverageArea');
@@ -82,17 +83,27 @@ goog.inherits(ol.view.Attribution, ol.View);
 ol.view.Attribution.prototype.createAttributionElementsForLayer_ =
     function(layer) {
 
+  var store = layer.getStore();
+  var attributions = store.getAttributions();
+  if (goog.isNull(attributions)) {
+    return;
+  }
+
   var map = this.getMap();
   var mapIsDef = map.isDef();
   var mapExtent = /** @type {ol.Extent} */ map.getExtent();
   var mapProjection = /** @type {ol.Projection} */ map.getProjection();
-  var mapResolution = map.getResolution();
+  var mapResolution = /** @type {number} */ map.getResolution();
 
   var layerVisible = layer.getVisible();
 
-  var store = layer.getStore();
+  var attributionVisibilities;
-  var attributions = store.getAttributions();
+  if (mapIsDef && layerVisible) {
-  if (!goog.isNull(attributions)) {
+    attributionVisibilities = this.getLayerAttributionVisiblities_(
+        layer, mapExtent, mapResolution, mapProjection);
+  } else {
+    attributionVisibilities = null;
+  }
 
   goog.array.forEach(attributions, function(attribution) {
 
@@ -101,10 +112,11 @@ ol.view.Attribution.prototype.createAttributionElementsForLayer_ =
     var attributionElement = goog.dom.createElement(goog.dom.TagName.LI);
     attributionElement.innerHTML = attribution.getHtml();
 
-      var attributionVisible = mapIsDef && layerVisible &&
+    if (!map.isDef ||
-          this.getAttributionVisiblity_(
+        !layerVisible ||
-              attribution, mapExtent, mapResolution, mapProjection);
+        !attributionVisibilities[attributionKey]) {
-      goog.style.showElement(attributionElement, attributionVisible);
+      goog.style.showElement(attributionElement, false);
+    }
 
     this.ulElement_.appendChild(attributionElement);
 
@@ -112,8 +124,6 @@ ol.view.Attribution.prototype.createAttributionElementsForLayer_ =
 
   }, this);
 
-  }
-
 };
 
 
@@ -241,7 +251,7 @@ ol.view.Attribution.prototype.handleMapChanged = function() {
   var mapIsDef = map.isDef();
   var mapExtent = /** @type {ol.Extent} */ map.getExtent();
   var mapProjection = /** @type {ol.Projection} */ map.getProjection();
-  var mapResolution = /** @type {number} */ map.getResolution();
+  var mapResolution = map.getResolution();
 
   var layers = map.getLayers();
   layers.forEach(function(layer) {
@@ -277,15 +287,32 @@ ol.view.Attribution.prototype.handleMapLayersChanged = function() {
 
 
 /**
- * @param {ol.Attribution} attribution Attribution.
+ * @param {ol.Layer} layer Layer.
  * @param {ol.Extent} mapExtent Map extent.
  * @param {number} mapResolution Map resolution.
  * @param {ol.Projection} mapProjection Map projection.
- * @return {boolean} Attribution visibility.
+ * @return {Object.<number, boolean>} Attribution visibilities.
  * @private
  */
-ol.view.Attribution.prototype.getAttributionVisiblity_ =
+ol.view.Attribution.prototype.getLayerAttributionVisiblities_ =
-    function(attribution, mapExtent, mapResolution, mapProjection) {
+    function(layer, mapExtent, mapResolution, mapProjection) {
+
+  var store = layer.getStore();
+  var attributions = store.getAttributions();
+
+  if (goog.isNull(attributions)) {
+    return null;
+  }
+
+  var mapZ;
+  if (store instanceof ol.TileStore) {
+    var tileStore = /** @type {ol.TileStore} */ store;
+    var tileGrid = tileStore.getTileGrid();
+    mapZ = tileGrid.getZForResolution(mapResolution);
+  }
+
+  var attributionVisibilities = {};
+  goog.array.forEach(attributions, function(attribution) {
 
     var attributionKey = goog.getUid(attribution);
 
@@ -311,6 +338,18 @@ ol.view.Attribution.prototype.getAttributionVisiblity_ =
     }
 
     if (!goog.isNull(coverageAreas)) {
+      if (store instanceof ol.TileStore) {
+        attributionVisible = goog.array.some(
+            coverageAreas,
+            /**
+             * @param {ol.TileCoverageArea} tileCoverageArea Tile coverage area.
+             */
+            function(tileCoverageArea) {
+              goog.asserts.assert(
+                  tileCoverageArea instanceof ol.TileCoverageArea);
+              return tileCoverageArea.intersectsExtentAndZ(mapExtent, mapZ);
+            });
+      } else {
         attributionVisible = goog.array.some(
             coverageAreas,
             function(coverageArea) {
@@ -318,8 +357,13 @@ ol.view.Attribution.prototype.getAttributionVisiblity_ =
                   mapExtent, mapResolution);
             });
       }
+    }
 
-  return attributionVisible;
+    attributionVisibilities[attributionKey] = attributionVisible;
+
+  }, this);
+
+  return attributionVisibilities;
 
 };
 
@@ -334,13 +378,25 @@ ol.view.Attribution.prototype.getAttributionVisiblity_ =
  */
 ol.view.Attribution.prototype.updateLayerAttributionsVisibility_ =
     function(layer, mapIsDef, mapExtent, mapResolution, mapProjection) {
-  var layerVisible = layer.getVisible();
+  if (mapIsDef && layer.getVisible()) {
-  goog.array.forEach(layer.getStore().getAttributions(), function(attribution) {
+    var attributionVisibilities = this.getLayerAttributionVisiblities_(
-    var attributionKey = goog.getUid(attribution);
+        layer, mapExtent, mapResolution, mapProjection);
-    var attributionVisible = mapIsDef && layerVisible &&
+    goog.object.forEach(
-        this.getAttributionVisiblity_(
+        attributionVisibilities,
-            attribution, mapExtent, mapResolution, mapProjection);
+        function(attributionVisible, attributionKey) {
           var attributionElement = this.attributionElements_[attributionKey];
           goog.style.showElement(attributionElement, attributionVisible);
+        },
+        this);
+  } else {
+    var store = layer.getStore();
+    var attributions = store.getAttributions();
+    if (!goog.isNull(attributions)) {
+      goog.array.forEach(attributions, function(attribution) {
+        var attributionKey = goog.getUid(attribution);
+        var attributionElement = this.attributionElements_[attributionKey];
+        goog.style.showElement(attributionElement, false);
       }, this);
+    }
+  }
 };