Incorporate remaining review comments from @bartvde.

This commit is contained in:
ahocevar
2012-01-20 14:18:15 +01:00
parent e70569b2bb
commit e09ee34f23
3 changed files with 2 additions and 3 deletions

View File

@@ -354,7 +354,6 @@ OpenLayers.Control.OverviewMap = OpenLayers.Class(OpenLayers.Control, {
onButtonClick: function(evt) { onButtonClick: function(evt) {
if (evt.button === this.minimizeDiv) { if (evt.button === this.minimizeDiv) {
this.minimizeControl(); this.minimizeControl();
propagate = false;
} else if (evt.button === this.maximizeDiv) { } else if (evt.button === this.maximizeDiv) {
this.maximizeControl(); this.maximizeControl();
}; };

View File

@@ -170,7 +170,7 @@ OpenLayers.Control.Panel = OpenLayers.Class(OpenLayers.Control, {
draw: function() { draw: function() {
OpenLayers.Control.prototype.draw.apply(this, arguments); OpenLayers.Control.prototype.draw.apply(this, arguments);
if (this.div.parentNode === this.map.viewPortDiv) { if (this.div.parentNode === this.map.viewPortDiv) {
map.events.register("buttonclick", this, this.onButtonClick); this.map.events.register("buttonclick", this, this.onButtonClick);
} else { } else {
this.events.element = this.div; this.events.element = this.div;
this.events.register("buttonclick", this, this.onButtonClick); this.events.register("buttonclick", this, this.onButtonClick);

View File

@@ -13,7 +13,7 @@
* event type fires "buttonclick" on its <target> when a button was * event type fires "buttonclick" on its <target> when a button was
* clicked. Buttons are detected by the "olButton" class. * clicked. Buttons are detected by the "olButton" class.
* *
* This event type makes sure that button clicks do not interfer with other * This event type makes sure that button clicks do not interfere with other
* events that are registered on the same <element>. * events that are registered on the same <element>.
*/ */
OpenLayers.Events.buttonclick = OpenLayers.Class({ OpenLayers.Events.buttonclick = OpenLayers.Class({