Since popups have a reference back to map, allow them to determine where they should be drawn internally. Thus we can remove the computing from the addPopup() function in Map.js.

git-svn-id: http://svn.openlayers.org/trunk/openlayers@346 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf

lib/OpenLayers/Map.js

@@ -172,8 +172,7 @@ OpenLayers.Map.prototype = {
     addPopup: function(popup) {
         popup.map = this;
         this.popups.push(popup);
-        var px = this.getLayerPxFromLonLat(popup.lonlat)
+        var popupDiv = popup.draw();
-        var popupDiv = popup.draw(px);
         if (popupDiv) {
             popupDiv.style.zIndex = this.Z_INDEX_BASE['Popup'] +
                                     this.popups.length;

lib/OpenLayers/Popup.js

@@ -81,6 +81,10 @@ OpenLayers.Popup.prototype = {
     * @type DOMElement
     */
     draw: function(px) {
+        if ((px == null) && (this.map != null)) {
+            px = this.map.getLayerPxFromLonLat(this.lonlat);
+        }
+        
         if (this.div == null) {
             this.div = OpenLayers.Util.createDiv(this.id + "_div",
                                                   null,

lib/OpenLayers/Popup/Anchored.js

@@ -39,6 +39,9 @@ OpenLayers.Popup.Anchored.prototype =
     * @type DOMElement
     */
     draw: function(px) {
+        if ((px == null) && (this.map != null)) {
+            px = this.map.getLayerPxFromLonLat(this.lonlat);
+        }
         
         //calculate relative position
         this.relativePosition = this.calculateRelativePosition(px);