diff --git a/build/library.cfg b/build/library.cfg index 572cd5873c..eeae1dd758 100644 --- a/build/library.cfg +++ b/build/library.cfg @@ -30,7 +30,6 @@ OpenLayers/Geometry/MultiPolygon.js OpenLayers/Geometry/Point.js OpenLayers/Geometry/Polygon.js OpenLayers/Geometry/Rectangle.js -OpenLayers/Geometry/Surface.js OpenLayers/Geometry.js OpenLayers/Layer/GML.js OpenLayers/Layer/Vector.js diff --git a/lib/OpenLayers.js b/lib/OpenLayers.js index dfd10848dc..abc9d0a83d 100644 --- a/lib/OpenLayers.js +++ b/lib/OpenLayers.js @@ -212,7 +212,6 @@ "OpenLayers/Geometry/Polygon.js", "OpenLayers/Geometry/MultiLineString.js", "OpenLayers/Geometry/MultiPolygon.js", - "OpenLayers/Geometry/Surface.js", "OpenLayers/Renderer.js", "OpenLayers/Renderer/Elements.js", "OpenLayers/Renderer/NG.js", diff --git a/lib/OpenLayers/Geometry/Surface.js b/lib/OpenLayers/Geometry/Surface.js deleted file mode 100644 index e41bfe57dd..0000000000 --- a/lib/OpenLayers/Geometry/Surface.js +++ /dev/null @@ -1,13 +0,0 @@ -/* Copyright (c) 2006-2011 by OpenLayers Contributors (see authors.txt for - * full list of contributors). Published under the Clear BSD license. - * See http://svn.openlayers.org/trunk/openlayers/license.txt for the - * full text of the license. */ - -/** - * @requires OpenLayers/Geometry.js - */ - -OpenLayers.Geometry.Surface = OpenLayers.Class(OpenLayers.Geometry, { - - CLASS_NAME: "OpenLayers.Geometry.Surface" -}); diff --git a/lib/OpenLayers/Renderer/Elements.js b/lib/OpenLayers/Renderer/Elements.js index 31b9d53c95..af5234eaf6 100644 --- a/lib/OpenLayers/Renderer/Elements.js +++ b/lib/OpenLayers/Renderer/Elements.js @@ -740,9 +740,6 @@ OpenLayers.Renderer.Elements = OpenLayers.Class(OpenLayers.Renderer, { case "OpenLayers.Geometry.Polygon": drawn = this.drawPolygon(node, geometry); break; - case "OpenLayers.Geometry.Surface": - drawn = this.drawSurface(node, geometry); - break; case "OpenLayers.Geometry.Rectangle": drawn = this.drawRectangle(node, geometry); break; @@ -867,21 +864,6 @@ OpenLayers.Renderer.Elements = OpenLayers.Class(OpenLayers.Renderer, { */ drawCircle: function(node, geometry) {}, - /** - * Method: drawSurface - * Virtual function for drawing Surface Geometry. - * Should be implemented by subclasses. - * This method is only called by the renderer itself. - * - * Parameters: - * node - {DOMElement} - * geometry - {} - * - * Returns: - * {DOMElement} or false if the renderer could not draw the surface - */ - drawSurface: function(node, geometry) {}, - /** * Method: removeText * Removes a label diff --git a/lib/OpenLayers/Renderer/SVG.js b/lib/OpenLayers/Renderer/SVG.js index 89da0bd5fd..132c12c7d3 100644 --- a/lib/OpenLayers/Renderer/SVG.js +++ b/lib/OpenLayers/Renderer/SVG.js @@ -214,7 +214,6 @@ OpenLayers.Renderer.SVG = OpenLayers.Class(OpenLayers.Renderer.Elements, { break; case "OpenLayers.Geometry.Polygon": case "OpenLayers.Geometry.Curve": - case "OpenLayers.Geometry.Surface": nodeType = "path"; break; default: @@ -628,46 +627,6 @@ OpenLayers.Renderer.SVG = OpenLayers.Class(OpenLayers.Renderer.Elements, { } }, - /** - * Method: drawSurface - * This method is only called by the renderer itself. - * - * Parameters: - * node - {DOMElement} - * geometry - {} - * - * Returns: - * {DOMElement} or false if the renderer could not draw the surface - */ - drawSurface: function(node, geometry) { - - // create the svg path string representation - var d = null; - var draw = true; - for (var i=0, len=geometry.components.length; i} - * - * Returns: - * {DOMElement} or false if the renderer could not draw the surface - */ - drawSurface: function(node, geometry) { - - // create the svg path string representation - var d = []; - var draw = true; - for (var i=0, len=geometry.components.length; i} - * - * Returns: - * {DOMElement} - */ - drawSurface: function(node, geometry) { - - this.setNodeDimension(node, geometry); - - var resolution = this.getResolution(); - - var path = []; - var comp, x, y; - for (var i=0, len=geometry.components.length; i - - - - - - - diff --git a/tests/Renderer/Elements.html b/tests/Renderer/Elements.html index c38c0376a0..0fe940e204 100644 --- a/tests/Renderer/Elements.html +++ b/tests/Renderer/Elements.html @@ -188,7 +188,7 @@ } function test_Elements_drawGeometry_2(t) { - t.plan(9); + t.plan(8); setUp(); @@ -253,17 +253,6 @@ r.drawGeometry(polygon, style); t.ok(properDraw, "drawGeometry called drawPolygon when passed a polygon"); - // surface - var properDraw = false; - r.drawSurface = function(g) { - properDraw = true; - return {}; - } - var surface = OpenLayers.Util.applyDefaults({CLASS_NAME: 'OpenLayers.Geometry.Surface'}, geometry); - style = true; - r.drawGeometry(surface, style); - t.ok(properDraw, "drawGeometry called drawSurface when passed a surface"); - // rectangle var properDraw = false; r.drawRectangle = function(g) { diff --git a/tests/Renderer/SVG.html b/tests/Renderer/SVG.html index fd82093d5e..750e124a81 100644 --- a/tests/Renderer/SVG.html +++ b/tests/Renderer/SVG.html @@ -297,40 +297,6 @@ t.eq(node.getAttributeNS(null, "height"), "8", "height attribute is correctly set"); } - function test_SVG_drawsurface(t) { - if (!OpenLayers.Renderer.SVG.prototype.supported()) { - t.plan(0); - return; - } - - t.plan(3); - - var r = new OpenLayers.Renderer.SVG(document.body); - - var node = document.createElement('div'); - - var geometry = { - components: ['foo', 'bar', 'dude'] - } - g_GetString = false; - r.getShortString = function(c) { - g_GetString = true; - return c; - } - - r.drawSurface(node, geometry); - - t.ok(g_GetString, "getShortString is called"); - - t.eq(node.getAttributeNS(null, "d"), "M foo C bar dude Z", "d attribute is correctly set"); - - r.getShortString = function(c) { - return false; - } - - t.eq(r.drawSurface(node, geometry), false, "drawSurface returns false if one linearRing cannot be drawn"); - } - function test_SVG_getcomponentsstring(t) { if (!OpenLayers.Renderer.SVG.prototype.supported()) { t.plan(0); diff --git a/tests/Renderer/SVG2.html b/tests/Renderer/SVG2.html index 8e92a719f8..6ee12ee9b6 100644 --- a/tests/Renderer/SVG2.html +++ b/tests/Renderer/SVG2.html @@ -282,34 +282,6 @@ t.eq(node.getAttributeNS(null, "height"), "4", "height attribute is correctly set"); } - function test_SVG_drawsurface(t) { - if (!OpenLayers.Renderer.SVG2.prototype.supported()) { - t.plan(0); - return; - } - - t.plan(2); - - var r = new OpenLayers.Renderer.SVG2(document.body); - - var node = document.createElement('div'); - - var geometry = { - components: ['foo', 'bar', 'dude'] - } - g_GetString = false; - r.getShortString = function(c) { - g_GetString = true; - return c; - } - - r.drawSurface(node, geometry); - - t.ok(g_GetString, "getShortString is called"); - - t.eq(node.getAttributeNS(null, "d"), "M foo C bar dude Z", "d attribute is correctly set"); - } - function test_SVG_getcomponentsstring(t) { if (!OpenLayers.Renderer.SVG2.prototype.supported()) { t.plan(0); diff --git a/tests/list-tests.html b/tests/list-tests.html index c93c81c14a..db4a56faaf 100644 --- a/tests/list-tests.html +++ b/tests/list-tests.html @@ -124,7 +124,6 @@
  • Geometry/Point.html
  • Geometry/Polygon.html
  • Geometry/Rectangle.html
  • -
  • Geometry/Surface.html
  • Handler.html
  • Handler/Box.html
  • Handler/Click.html