Add EventType enum to ol.Object

This commit is contained in:
Tim Schaub
2016-12-04 14:20:57 -07:00
parent 3d2f677f2a
commit daba1fbcb6
5 changed files with 21 additions and 25 deletions

View File

@@ -5,7 +5,6 @@ goog.require('ol.Collection');
goog.require('ol.Map'); goog.require('ol.Map');
goog.require('ol.MapEvent'); goog.require('ol.MapEvent');
goog.require('ol.Object'); goog.require('ol.Object');
goog.require('ol.ObjectEventType');
goog.require('ol.Overlay'); goog.require('ol.Overlay');
goog.require('ol.View'); goog.require('ol.View');
goog.require('ol.control.Control'); goog.require('ol.control.Control');
@@ -166,7 +165,7 @@ ol.control.OverviewMap.prototype.setMap = function(map) {
if (map) { if (map) {
this.listenerKeys.push(ol.events.listen( this.listenerKeys.push(ol.events.listen(
map, ol.ObjectEventType.PROPERTYCHANGE, map, ol.Object.EventType.PROPERTYCHANGE,
this.handleMapPropertyChange_, this)); this.handleMapPropertyChange_, this));
// TODO: to really support map switching, this would need to be reworked // TODO: to really support map switching, this would need to be reworked

View File

@@ -4,7 +4,6 @@ goog.require('ol');
goog.require('ol.asserts'); goog.require('ol.asserts');
goog.require('ol.Collection'); goog.require('ol.Collection');
goog.require('ol.Object'); goog.require('ol.Object');
goog.require('ol.ObjectEventType');
goog.require('ol.events'); goog.require('ol.events');
goog.require('ol.events.EventType'); goog.require('ol.events.EventType');
goog.require('ol.extent'); goog.require('ol.extent');
@@ -104,7 +103,7 @@ ol.layer.Group.prototype.handleLayersChanged_ = function(event) {
for (i = 0, ii = layersArray.length; i < ii; i++) { for (i = 0, ii = layersArray.length; i < ii; i++) {
layer = layersArray[i]; layer = layersArray[i];
this.listenerKeys_[ol.getUid(layer).toString()] = [ this.listenerKeys_[ol.getUid(layer).toString()] = [
ol.events.listen(layer, ol.ObjectEventType.PROPERTYCHANGE, ol.events.listen(layer, ol.Object.EventType.PROPERTYCHANGE,
this.handleLayerChange_, this), this.handleLayerChange_, this),
ol.events.listen(layer, ol.events.EventType.CHANGE, ol.events.listen(layer, ol.events.EventType.CHANGE,
this.handleLayerChange_, this) this.handleLayerChange_, this)
@@ -125,7 +124,7 @@ ol.layer.Group.prototype.handleLayersAdd_ = function(collectionEvent) {
ol.DEBUG && console.assert(!(key in this.listenerKeys_), ol.DEBUG && console.assert(!(key in this.listenerKeys_),
'listeners already registered'); 'listeners already registered');
this.listenerKeys_[key] = [ this.listenerKeys_[key] = [
ol.events.listen(layer, ol.ObjectEventType.PROPERTYCHANGE, ol.events.listen(layer, ol.Object.EventType.PROPERTYCHANGE,
this.handleLayerChange_, this), this.handleLayerChange_, this),
ol.events.listen(layer, ol.events.EventType.CHANGE, ol.events.listen(layer, ol.events.EventType.CHANGE,
this.handleLayerChange_, this) this.handleLayerChange_, this)

View File

@@ -10,7 +10,6 @@ goog.require('ol.MapBrowserEvent');
goog.require('ol.MapBrowserEventHandler'); goog.require('ol.MapBrowserEventHandler');
goog.require('ol.MapEvent'); goog.require('ol.MapEvent');
goog.require('ol.Object'); goog.require('ol.Object');
goog.require('ol.ObjectEventType');
goog.require('ol.TileQueue'); goog.require('ol.TileQueue');
goog.require('ol.View'); goog.require('ol.View');
goog.require('ol.asserts'); goog.require('ol.asserts');
@@ -1104,7 +1103,7 @@ ol.Map.prototype.handleViewChanged_ = function() {
var view = this.getView(); var view = this.getView();
if (view) { if (view) {
this.viewPropertyListenerKey_ = ol.events.listen( this.viewPropertyListenerKey_ = ol.events.listen(
view, ol.ObjectEventType.PROPERTYCHANGE, view, ol.Object.EventType.PROPERTYCHANGE,
this.handleViewPropertyChanged_, this); this.handleViewPropertyChanged_, this);
this.viewChangeListenerKey_ = ol.events.listen( this.viewChangeListenerKey_ = ol.events.listen(
view, ol.events.EventType.CHANGE, view, ol.events.EventType.CHANGE,
@@ -1126,7 +1125,7 @@ ol.Map.prototype.handleLayerGroupChanged_ = function() {
if (layerGroup) { if (layerGroup) {
this.layerGroupPropertyListenerKeys_ = [ this.layerGroupPropertyListenerKeys_ = [
ol.events.listen( ol.events.listen(
layerGroup, ol.ObjectEventType.PROPERTYCHANGE, layerGroup, ol.Object.EventType.PROPERTYCHANGE,
this.render, this), this.render, this),
ol.events.listen( ol.events.listen(
layerGroup, ol.events.EventType.CHANGE, layerGroup, ol.events.EventType.CHANGE,

View File

@@ -1,6 +1,5 @@
goog.provide('ol.Object'); goog.provide('ol.Object');
goog.provide('ol.ObjectEvent'); goog.provide('ol.ObjectEvent');
goog.provide('ol.ObjectEventType');
goog.require('ol'); goog.require('ol');
goog.require('ol.Observable'); goog.require('ol.Observable');
@@ -8,19 +7,6 @@ goog.require('ol.events.Event');
goog.require('ol.obj'); goog.require('ol.obj');
/**
* @enum {string}
*/
ol.ObjectEventType = {
/**
* Triggered when a property is changed.
* @event ol.ObjectEvent#propertychange
* @api stable
*/
PROPERTYCHANGE: 'propertychange'
};
/** /**
* @classdesc * @classdesc
* Events emitted by {@link ol.Object} instances are instances of this type. * Events emitted by {@link ol.Object} instances are instances of this type.
@@ -182,7 +168,7 @@ ol.Object.prototype.notify = function(key, oldValue) {
var eventType; var eventType;
eventType = ol.Object.getChangeEventType(key); eventType = ol.Object.getChangeEventType(key);
this.dispatchEvent(new ol.ObjectEvent(eventType, key, oldValue)); this.dispatchEvent(new ol.ObjectEvent(eventType, key, oldValue));
eventType = ol.ObjectEventType.PROPERTYCHANGE; eventType = ol.Object.EventType.PROPERTYCHANGE;
this.dispatchEvent(new ol.ObjectEvent(eventType, key, oldValue)); this.dispatchEvent(new ol.ObjectEvent(eventType, key, oldValue));
}; };
@@ -237,3 +223,16 @@ ol.Object.prototype.unset = function(key, opt_silent) {
} }
} }
}; };
/**
* @enum {string}
*/
ol.Object.EventType = {
/**
* Triggered when a property is changed.
* @event ol.ObjectEvent#propertychange
* @api stable
*/
PROPERTYCHANGE: 'propertychange'
};

View File

@@ -5,7 +5,7 @@ goog.provide('ol.source.Vector');
goog.require('ol'); goog.require('ol');
goog.require('ol.Collection'); goog.require('ol.Collection');
goog.require('ol.ObjectEventType'); goog.require('ol.Object');
goog.require('ol.array'); goog.require('ol.array');
goog.require('ol.asserts'); goog.require('ol.asserts');
goog.require('ol.events'); goog.require('ol.events');
@@ -205,7 +205,7 @@ ol.source.Vector.prototype.setupChangeEvents_ = function(featureKey, feature) {
this.featureChangeKeys_[featureKey] = [ this.featureChangeKeys_[featureKey] = [
ol.events.listen(feature, ol.events.EventType.CHANGE, ol.events.listen(feature, ol.events.EventType.CHANGE,
this.handleFeatureChange_, this), this.handleFeatureChange_, this),
ol.events.listen(feature, ol.ObjectEventType.PROPERTYCHANGE, ol.events.listen(feature, ol.Object.EventType.PROPERTYCHANGE,
this.handleFeatureChange_, this) this.handleFeatureChange_, this)
]; ];
}; };