ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix for #855 - set marker as not 'drawn' when removed from the markers layer. thanks for the great patch and tests, Eric L.

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3784 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
euzuro
2007-07-23 14:48:39 +00:00
parent 454d77842e
commit d75f7c139f
2 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/OpenLayers/Layer/Markers.js
View File

@@ -102,6 +102,7 @@ OpenLayers.Layer.Markers = OpenLayers.Class(OpenLayers.Layer, {
if ((marker.icon != null) && (marker.icon.imageDiv != null) && if ((marker.icon != null) && (marker.icon.imageDiv != null) &&
(marker.icon.imageDiv.parentNode == this.div) ) { (marker.icon.imageDiv.parentNode == this.div) ) {
this.div.removeChild(marker.icon.imageDiv); this.div.removeChild(marker.icon.imageDiv);
marker.drawn = false;
} }
}, },

20
tests/Layer/test_Markers.html
View File

@@ -22,7 +22,25 @@
); );
t.eq( layer.markers.length, 1, "addLayer adds marker to layer." ); t.eq( layer.markers.length, 1, "addLayer adds marker to layer." );
} }
function test_98_Layer_Markers_addMarker_removeMarker (t) {
t.plan( 3 );
var map = new OpenLayers.Map('map');
var baseLayer = new OpenLayers.Layer.WMS("Test Layer",
"http://octo.metacarta.com/cgi-bin/mapserv?",
{map: "/mapdata/vmap_wms.map", layers: "basic"});
map.addLayer(baseLayer);
map.zoomToMaxExtent();
layer = new OpenLayers.Layer.Markers('Test Layer');
map.addLayer(layer);
var marker = new OpenLayers.Marker(new OpenLayers.LonLat(5,40));
layer.addMarker(marker);
t.ok( marker.icon.imageDiv.parentNode == layer.div, "addMarker adds marker image node into layer node." );
layer.removeMarker(marker);
t.ok( marker.icon.imageDiv.parentNode != layer.div, "removeMarker removes marker image node from layer node." );
layer.addMarker(marker);
t.ok( marker.icon.imageDiv.parentNode == layer.div, "addMarker adds marker image node into layer node." );
}
function test_99_Layer_Markers_destroy (t) { function test_99_Layer_Markers_destroy (t) {
t.plan( 1 ); t.plan( 1 );
layer = new OpenLayers.Layer.Markers('Test Layer'); layer = new OpenLayers.Layer.Markers('Test Layer');
@@ -35,6 +53,6 @@
</script> </script>
</head> </head>
<body> <body>
<div id="map"></div> <div id="map" style="width: 1080px; height: 600px;"/>
</body> </body>
</html> </html>