ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update typeDefs for Attribution and Control

Browse Source 
For consistency with docs, update type for labels to {string|HTMLElement}
This commit is contained in:
Matthijs Bon
2021-10-11 10:05:47 +02:00
parent c0009d5985
commit d4bc7d3f39
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ol/control/Attribution.js
+1 -1
View File
@@ -20,7 +20,7 @@ import {removeChildren, replaceNode} from '../dom.js';
* @property {boolean} [collapsed=true] Specify if attributions should * @property {boolean} [collapsed=true] Specify if attributions should
* be collapsed at startup. * be collapsed at startup.
* @property {string} [tipLabel='Attributions'] Text label to use for the button tip. * @property {string} [tipLabel='Attributions'] Text label to use for the button tip.
* @property {string} [label='i'] Text label to use for the * @property {string|HTMLElement} [label='i'] Text label to use for the
* collapsed attributions button. * collapsed attributions button.
* Instead of text, also an element (e.g. a `span` element) can be used. * Instead of text, also an element (e.g. a `span` element) can be used.
* @property {string} [expandClassName=className + '-expand'] CSS class name for the * @property {string} [expandClassName=className + '-expand'] CSS class name for the
src/ol/control/FullScreen.js
+2 -2
View File
@@ -44,7 +44,7 @@ const FullScreenEventType = {
/** /**
* @typedef {Object} Options * @typedef {Object} Options
* @property {string} [className='ol-full-screen'] CSS class name. * @property {string} [className='ol-full-screen'] CSS class name.
* @property {string|Text} [label='\u2922'] Text label to use for the button. * @property {string|HTMLElement} [label='\u2922'] Text label to use for the button.
* Instead of text, also an element (e.g. a `span` element) can be used. * Instead of text, also an element (e.g. a `span` element) can be used.
* @property {string|Text} [labelActive='\u00d7'] Text label to use for the * @property {string|Text} [labelActive='\u00d7'] Text label to use for the
* button when full-screen is active. * button when full-screen is active.
@@ -133,7 +133,7 @@ class FullScreen extends Control {
/** /**
* @private * @private
* @type {Text} * @type {Text|HTMLElement}
*/ */
this.labelNode_ = this.labelNode_ =
typeof label === 'string' ? document.createTextNode(label) : label; typeof label === 'string' ? document.createTextNode(label) : label;