From d3d0d1e007c1273390c5ba018fc670f4d9f000c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89ric=20Lemoine?= Date: Tue, 23 Apr 2013 14:44:36 +0200 Subject: [PATCH] Test isElement instead of isDef (thanks @fredj) --- src/ol/map.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/ol/map.js b/src/ol/map.js index 180887aefa..cfa2e6d613 100644 --- a/src/ol/map.js +++ b/src/ol/map.js @@ -691,10 +691,14 @@ ol.Map.prototype.handleSizeChanged_ = function() { * @private */ ol.Map.prototype.handleTargetChanged_ = function() { + // target may be undefined, null or an Element. If it's not + // an Element we remove the viewport from the DOM. If it's + // an Element we append the viewport element to it. var target = this.getTarget(); - if (!goog.isDef(target)) { + if (!goog.dom.isElement(target)) { goog.dom.removeNode(this.viewport_); } else { + goog.asserts.assert(goog.isDefAndNotNull(target)); goog.dom.appendChild(target, this.viewport_); } this.updateSize();