Avoid creating event object when nobody is listening

This commit is contained in:
Maximilian Krög
2022-02-09 21:03:11 +01:00
parent 96de98bfbb
commit d35d1cc8ad

View File

@@ -83,49 +83,50 @@ class Target extends Disposable {
* @api * @api
*/ */
dispatchEvent(event) { dispatchEvent(event) {
/** @type {import("./Event.js").default|Event} */ const isString = typeof event === 'string';
const evt = typeof event === 'string' ? new Event(event) : event; const type = isString ? event : event.type;
const type = evt.type; const listeners = this.listeners_ && this.listeners_[type];
if (!listeners) {
return;
}
const evt = isString ? new Event(event) : /** @type {Event} */ (event);
if (!evt.target) { if (!evt.target) {
evt.target = this.eventTarget_ || this; evt.target = this.eventTarget_ || this;
} }
const listeners = this.listeners_ && this.listeners_[type]; const dispatching = this.dispatching_ || (this.dispatching_ = {});
let propagate; const pendingRemovals =
if (listeners) { this.pendingRemovals_ || (this.pendingRemovals_ = {});
const dispatching = this.dispatching_ || (this.dispatching_ = {}); if (!(type in dispatching)) {
const pendingRemovals = dispatching[type] = 0;
this.pendingRemovals_ || (this.pendingRemovals_ = {}); pendingRemovals[type] = 0;
if (!(type in dispatching)) {
dispatching[type] = 0;
pendingRemovals[type] = 0;
}
++dispatching[type];
for (let i = 0, ii = listeners.length; i < ii; ++i) {
if ('handleEvent' in listeners[i]) {
propagate = /** @type {import("../events.js").ListenerObject} */ (
listeners[i]
).handleEvent(evt);
} else {
propagate = /** @type {import("../events.js").ListenerFunction} */ (
listeners[i]
).call(this, evt);
}
if (propagate === false || evt.propagationStopped) {
propagate = false;
break;
}
}
--dispatching[type];
if (dispatching[type] === 0) {
let pr = pendingRemovals[type];
delete pendingRemovals[type];
while (pr--) {
this.removeEventListener(type, VOID);
}
delete dispatching[type];
}
return propagate;
} }
++dispatching[type];
let propagate;
for (let i = 0, ii = listeners.length; i < ii; ++i) {
if ('handleEvent' in listeners[i]) {
propagate = /** @type {import("../events.js").ListenerObject} */ (
listeners[i]
).handleEvent(evt);
} else {
propagate = /** @type {import("../events.js").ListenerFunction} */ (
listeners[i]
).call(this, evt);
}
if (propagate === false || evt.propagationStopped) {
propagate = false;
break;
}
}
if (--dispatching[type] === 0) {
let pr = pendingRemovals[type];
delete pendingRemovals[type];
while (pr--) {
this.removeEventListener(type, VOID);
}
delete dispatching[type];
}
return propagate;
} }
/** /**