Merge pull request #11188 from michalzielanski/late-obj-init

Late object initialization

test/spec/ol/events/eventtarget.test.js

@@ -24,9 +24,6 @@ describe('ol.events.EventTarget', function () {
       expect(eventTarget).to.be.a(EventTarget);
       expect(eventTarget).to.be.a(Disposable);
     });
-    it('creates an empty listeners_ object', function () {
-      expect(Object.keys(eventTarget.listeners_)).to.have.length(0);
-    });
     it('accepts a default target', function (done) {
       const defaultTarget = {};
       const target = new EventTarget(defaultTarget);
@@ -36,16 +33,21 @@ describe('ol.events.EventTarget', function () {
       });
       target.dispatchEvent('my-event');
     });
+    it('does not initialize objects in advance', function () {
+      expect(eventTarget.pendingRemovals_).to.be(null);
+      expect(eventTarget.dispatching_).to.be(null);
+      expect(eventTarget.listeners_).to.be(null);
+    });
   });
 
   describe('#hasListener', function () {
     it('reports any listeners when called without argument', function () {
       expect(eventTarget.hasListener()).to.be(false);
-      eventTarget.listeners_['foo'] = [function () {}];
+      eventTarget.addEventListener('foo', function () {});
       expect(eventTarget.hasListener()).to.be(true);
     });
     it('reports listeners for the type passed as argument', function () {
-      eventTarget.listeners_['foo'] = [function () {}];
+      eventTarget.addEventListener('foo', function () {});
       expect(eventTarget.hasListener('foo')).to.be(true);
       expect(eventTarget.hasListener('bar')).to.be(false);
     });

test/spec/ol/object.test.js

@@ -101,6 +101,22 @@ describe('ol.Object', function () {
     });
   });
 
+  describe('hasProperties', function () {
+    it('has no properties after creation', function () {
+      expect(o.hasProperties()).to.eql(false);
+    });
+
+    it('has properties after set', function () {
+      o.set('foo', 1);
+      expect(o.hasProperties()).to.eql(true);
+    });
+
+    it('has no properties after unset all', function () {
+      o.unset('foo');
+      expect(o.hasProperties()).to.eql(false);
+    });
+  });
+
   describe('notify', function () {
     let listener1, listener2;