From cf81c29d314cd0cd0d0009f44799b8a87153e491 Mon Sep 17 00:00:00 2001 From: Tim Schaub Date: Thu, 9 Apr 2009 19:26:42 +0000 Subject: [PATCH] Making OpenLayers.String.trim work for multiline strings. Thanks etdube for the patch. r=me (closes #2034) git-svn-id: http://svn.openlayers.org/trunk/openlayers@9255 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf --- lib/OpenLayers/BaseTypes.js | 2 +- tests/BaseTypes.html | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/OpenLayers/BaseTypes.js b/lib/OpenLayers/BaseTypes.js index 0618102c70..1a12ff5528 100644 --- a/lib/OpenLayers/BaseTypes.js +++ b/lib/OpenLayers/BaseTypes.js @@ -67,7 +67,7 @@ OpenLayers.String = { * trailing spaces removed. */ trim: function(str) { - return str.replace(/^\s*(.*?)\s*$/, "$1"); + return str.replace(/^\s\s*/, '').replace(/\s\s*$/, ''); }, /** diff --git a/tests/BaseTypes.html b/tests/BaseTypes.html index 7953eafc60..cbb9db7398 100644 --- a/tests/BaseTypes.html +++ b/tests/BaseTypes.html @@ -35,7 +35,7 @@ } function test_String_trim(t) { - t.plan(5); + t.plan(6); var str = "chickenHead"; t.eq(OpenLayers.String.trim(str), @@ -53,6 +53,9 @@ t.eq(OpenLayers.String.trim(str), "chickenHead", "string with extra whitespace at beginning and end is trimmed correctly"); + str = "chicken\nHead "; + t.eq(OpenLayers.String.trim(str), + "chicken\nHead", "multi-line string with extra whitespace at end is trimmed correctly"); str = " "; t.eq(OpenLayers.String.trim(str), "", "whitespace string is trimmed correctly"); }