From cd2dfc7f108da15f3bc4a1ce15a85629e39b0e91 Mon Sep 17 00:00:00 2001 From: Andreas Hocevar Date: Sun, 14 Feb 2016 18:05:15 +0100 Subject: [PATCH] Use regular expression instead of String#endsWith() check --- src/ol/source/tilearcgisrestsource.js | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/src/ol/source/tilearcgisrestsource.js b/src/ol/source/tilearcgisrestsource.js index 451d4d3800..a6f257794e 100644 --- a/src/ol/source/tilearcgisrestsource.js +++ b/src/ol/source/tilearcgisrestsource.js @@ -2,7 +2,6 @@ goog.provide('ol.source.TileArcGISRest'); goog.require('goog.asserts'); goog.require('goog.math'); -goog.require('goog.string'); goog.require('goog.uri.utils'); goog.require('ol'); goog.require('ol.TileCoord'); @@ -109,20 +108,13 @@ ol.source.TileArcGISRest.prototype.getRequestUrl_ = function(tileCoord, tileSize url = urls[index]; } - if (!goog.string.endsWith(url, '/')) { - url = url + '/'; - } - - // If a MapServer, use export. If an ImageServer, use exportImage. - if (goog.string.endsWith(url, 'MapServer/')) { - url = url + 'export'; - } else if (goog.string.endsWith(url, 'ImageServer/')) { - url = url + 'exportImage'; - } else { + var modifiedUrl = url + .replace(/MapServer\/?$/, 'MapServer/export') + .replace(/ImageServer\/?$/, 'ImageServer/exportImage'); + if (modifiedUrl == url) { goog.asserts.fail('Unknown Rest Service', url); } - - return goog.uri.utils.appendParamsFromMap(url, params); + return goog.uri.utils.appendParamsFromMap(modifiedUrl, params); };