ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Dispatch a change event only if the value is different

Browse Source
This commit is contained in:
Frederic Junod
2015-11-16 15:15:16 +01:00
parent 18c41bfc19
commit ca575bd35d
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/ol/object.js
View File

@@ -206,7 +206,9 @@ ol.Object.prototype.set = function(key, value, opt_silent) {
} else { } else {
var oldValue = this.values_[key]; var oldValue = this.values_[key];
this.values_[key] = value; this.values_[key] = value;
this.notify(key, oldValue); if (oldValue !== value) {
this.notify(key, oldValue);
}
} }
}; };

7
test/spec/ol/object.test.js
View File

@@ -168,6 +168,13 @@ describe('ol.Object', function() {
expect(event.key).to.be('k'); expect(event.key).to.be('k');
}); });
it('dispatches events only if the value is different', function() {
o.set('k', 1);
o.set('k', 1);
expect(listener1.calledOnce).to.be(true);
expect(listener2.calledOnce).to.be(true);
});
}); });
describe('setter', function() { describe('setter', function() {