ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #801 from pgiraud/map_movestart_zoomchanged

Browse Source 
Send zoomChanged value when triggering movestart event
This commit is contained in:
Pierre GIRAUD
2012-12-17 04:56:32 -08:00
parent 257b249b9d 6c21c2043f
commit c9fa5aabad
2 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/OpenLayers/Map.js
+6 -2
View File
@@ -75,7 +75,9 @@ OpenLayers.Map = OpenLayers.Class({
* The *layer* property will be a reference to the changed layer. The * The *layer* property will be a reference to the changed layer. The
* *property* property will be a key to the changed property (name, * *property* property will be a key to the changed property (name,
* order, opacity, params, visibility or attribution). * order, opacity, params, visibility or attribution).
* movestart - triggered after the start of a drag, pan, or zoom * movestart - triggered after the start of a drag, pan, or zoom. The event
* object may include a *zoomChanged* property that tells whether the
* zoom has changed.
* move - triggered after each drag, pan, or zoom * move - triggered after each drag, pan, or zoom
* moveend - triggered after a drag, pan, or zoom completes * moveend - triggered after a drag, pan, or zoom completes
* zoomend - triggered after a zoom completes * zoomend - triggered after a zoom completes
@@ -1908,7 +1910,9 @@ OpenLayers.Map = OpenLayers.Class({
// if neither center nor zoom will change, no need to do anything // if neither center nor zoom will change, no need to do anything
if (zoomChanged || centerChanged || dragging) { if (zoomChanged || centerChanged || dragging) {
dragging || this.events.triggerEvent("movestart"); dragging || this.events.triggerEvent("movestart", {
zoomChanged: zoomChanged
});
if (centerChanged) { if (centerChanged) {
if (!zoomChanged && this.center) { if (!zoomChanged && this.center) {
tests/Map.html
+7 -2
View File
@@ -977,7 +977,7 @@
} }
function test_Map_moveTo(t) { function test_Map_moveTo(t) {
t.plan(8); t.plan(12);
map = new OpenLayers.Map('map'); map = new OpenLayers.Map('map');
var baseLayer = new OpenLayers.Layer.WMS("Test Layer", var baseLayer = new OpenLayers.Layer.WMS("Test Layer",
@@ -992,10 +992,15 @@
property: event.property property: event.property
}); });
}); });
baseLayer.events.on({ map.events.on({
move: function() { move: function() {
t.ok(true, "move listener called"); t.ok(true, "move listener called");
}, },
movestart: function(e) {
t.eq(e.zoomChanged, true, "movestart listener called with expected value");
}
});
baseLayer.events.on({
moveend: function(e) { moveend: function(e) {
t.eq(e.zoomChanged, true, "moveend listener called with expected value"); t.eq(e.zoomChanged, true, "moveend listener called with expected value");
} }