ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Improve ol.control.Rotate.prototype.resetNorth_ performance

Browse Source 
Changing. resetNorth_ function from O(n) to O(1).

To reproduce this issue, open the developer console and execute:

    map.getView().setRotation(5000000000);

Then click on the rotation button. Before the commit, it takes a few
seconds, after this commit it is instantaneous.

In addition, due to limited floating point precision, the previous code
calculates a different value from this one.
This commit is contained in:
Denilson Figueiredo de Sá
2015-09-30 09:37:51 -03:00
parent 8e122334ed
commit c8f0bb0ade
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/ol/control/rotatecontrol.js
View File

@@ -119,14 +119,15 @@ ol.control.Rotate.prototype.resetNorth_ = function() {
return; return;
} }
var currentRotation = view.getRotation(); var currentRotation = view.getRotation();
while (currentRotation < -Math.PI) {
currentRotation += 2 * Math.PI;
}
while (currentRotation > Math.PI) {
currentRotation -= 2 * Math.PI;
}
if (currentRotation !== undefined) { if (currentRotation !== undefined) {
if (this.duration_ > 0) { if (this.duration_ > 0) {
currentRotation = currentRotation % (2 * Math.PI);
if (currentRotation < -Math.PI) {
currentRotation += 2 * Math.PI;
}
if (currentRotation > Math.PI) {
currentRotation -= 2 * Math.PI;
}
map.beforeRender(ol.animation.rotate({ map.beforeRender(ol.animation.rotate({
rotation: currentRotation, rotation: currentRotation,
duration: this.duration_, duration: this.duration_,