ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

The getFeatureFromEvent now throws.

Browse Source 
An error is thrown if getFeatureFromEvent is called on a destroyed layer (see #7).
This commit is contained in:
tschaub
2011-10-11 09:34:38 -06:00
parent b1ee9d1f95
commit c6e66a3c5c
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Layer/Vector.html
+9 -3
View File
@@ -575,7 +575,7 @@
} }
function test_Layer_Vector_destroy (t) { function test_Layer_Vector_destroy (t) {
t.plan(5); t.plan(6);
var options = {protocol: new OpenLayers.Protocol(), var options = {protocol: new OpenLayers.Protocol(),
strategies: [new OpenLayers.Strategy(), new OpenLayers.Strategy()]} strategies: [new OpenLayers.Strategy(), new OpenLayers.Strategy()]}
@@ -584,8 +584,14 @@
map.addLayer(layer); map.addLayer(layer);
layer.destroy(); layer.destroy();
t.eq(layer.map, null, "layer.map is null after destroy"); t.eq(layer.map, null, "layer.map is null after destroy");
t.eq(layer.getFeatureFromEvent({'target':'map'}), null, t.ok(!layer.renderer, "layer.renderer is falsey");
"getFeatureIdFromEvent doesn't cause an error when called on layer which has been destroyed."); var err;
try {
layer.getFeatureFromEvent({target: "map"});
} catch (ex) {
err = ex;
}
t.ok(err, "Error thrown when calling getFeatureFromEvent on destroyed layer");
t.eq(layer.protocol, null, "layer.protocol is null after destroy"); t.eq(layer.protocol, null, "layer.protocol is null after destroy");
t.eq(layer.strategies, null, "layer.strategies is null after destroy"); t.eq(layer.strategies, null, "layer.strategies is null after destroy");