ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Making freehand drawing work on touch devices. Thanks jorix for the excellent patch. r=me (closes #3456)

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@12253 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
Tim Schaub
2011-08-17 02:13:06 +00:00
parent 98eabd4d89
commit c517de52f5
2 changed files with 79 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/OpenLayers/Handler/Path.js
+4
View File
@@ -417,6 +417,10 @@ OpenLayers.Handler.Path = OpenLayers.Class(OpenLayers.Handler.Point, {
var stopDown = this.stopDown; var stopDown = this.stopDown;
if(this.freehandMode(evt)) { if(this.freehandMode(evt)) {
stopDown = true; stopDown = true;
if (this.touch) {
this.modifyFeature(evt.xy, !!this.lastUp);
OpenLayers.Event.stop(evt);
}
} }
if (!this.touch && (!this.lastDown || if (!this.touch && (!this.lastDown ||
!this.passesTolerance(this.lastDown, evt.xy, !this.passesTolerance(this.lastDown, evt.xy,
tests/Handler/Path.html
+75
View File
@@ -1301,6 +1301,81 @@
map.destroy(); map.destroy();
} }
function test_set_freehand(t) {
t.plan(5);
var map = new OpenLayers.Map("map", {
resolutions: [1]
});
var layer = new OpenLayers.Layer.Vector("foo", {
maxExtent: new OpenLayers.Bounds(-10, -10, 10, 10),
isBaseLayer: true
});
map.addLayer(layer);
var control = new OpenLayers.Control({});
var geo, pointsCount;
var handler = new OpenLayers.Handler.Path(control, {
done: function(g) {
geo = g;
},
point: function() {
pointsCount++;
}
},
{freehand: true}
);
control.handler = handler;
map.addControl(control);
map.setCenter(new OpenLayers.LonLat(0, 0), 0);
handler.activate();
geo = null;
pointsCount = 0;
// Using mouse events
handler.mousemove(
{type: "mousemove", xy: new OpenLayers.Pixel(0, 0)});
handler.mousedown(
{type: "mousedown", xy: new OpenLayers.Pixel(0, 0)});
handler.mousemove(
{type: "mousemove", xy: new OpenLayers.Pixel(1, 1)});
handler.mousemove(
{type: "mousemove", xy: new OpenLayers.Pixel(2, 2)});
handler.mouseup(
{type: "mouseup", xy: new OpenLayers.Pixel(2, 2)});
t.ok(geo != null, "feature drawn when mouseup");
t.eq(pointsCount, 2, "two points have been added");
handler.deactivate();
var geoMouse = geo;
handler.activate();
geo = null;
pointsCount = 0;
// Using touch events
handler.touchstart(
{type: "touchstart", xy: new OpenLayers.Pixel(0, 0)});
try {
handler.touchmove(
{type: "touchmove", xy: new OpenLayers.Pixel(1, 1)});
handler.touchmove(
{type: "touchmove", xy: new OpenLayers.Pixel(2, 2)});
handler.touchend(
{type: "touchend"});
} catch(err) {
t.fail("occurred errors using touch events");
}
t.ok(geo != null, "feature drawn when touchend");
t.eq(pointsCount, 2, "two points have been added");
t.geom_eq(geo, geoMouse,
"geometry obtained using the mouse and touch events are the same");
map.destroy();
}
</script> </script>
</head> </head>
<body> <body>