From 43ef0920c2d9bf006cd1d769d2391b9b75a92cf8 Mon Sep 17 00:00:00 2001
From: Tom MacWright <tom@macwright.org>
Date: Sun, 20 Nov 2011 23:47:37 -0500
Subject: [PATCH 1/2] Removing camelize method.

---
 lib/OpenLayers/BaseTypes.js           | 22 ----------------------
 lib/OpenLayers/BaseTypes/Element.js   |  4 ++--
 lib/OpenLayers/Control/OverviewMap.js |  6 +++---
 lib/OpenLayers/Handler/Box.js         |  8 ++++----
 lib/OpenLayers/Popup.js               |  8 ++++----
 tests/BaseTypes.html                  | 27 ---------------------------
 tests/Handler/Box.html                |  2 +-
 7 files changed, 14 insertions(+), 63 deletions(-)

diff --git a/lib/OpenLayers/BaseTypes.js b/lib/OpenLayers/BaseTypes.js
index 05b06b8d3d..f19a70d223 100644
--- a/lib/OpenLayers/BaseTypes.js
+++ b/lib/OpenLayers/BaseTypes.js
@@ -60,28 +60,6 @@ OpenLayers.String = {
         return str.replace(/^\s\s*/, '').replace(/\s\s*$/, '');
     },
     
-    /**
-     * APIFunction: camelize
-     * Camel-case a hyphenated string. 
-     *     Ex. "chicken-head" becomes "chickenHead", and
-     *     "-chicken-head" becomes "ChickenHead".
-     *
-     * Parameters:
-     * str - {String} The string to be camelized.  The original is not modified.
-     * 
-     * Returns:
-     * {String} The string, camelized
-     */
-    camelize: function(str) {
-        var oStringList = str.split('-');
-        var camelizedString = oStringList[0];
-        for (var i=1, len=oStringList.length; i<len; i++) {
-            var s = oStringList[i];
-            camelizedString += s.charAt(0).toUpperCase() + s.substring(1);
-        }
-        return camelizedString;
-    },
-    
     /**
      * APIFunction: format
      * Given a string with tokens in the form ${token}, return a string
diff --git a/lib/OpenLayers/BaseTypes/Element.js b/lib/OpenLayers/BaseTypes/Element.js
index bc1d84ed8a..ac91354de5 100644
--- a/lib/OpenLayers/BaseTypes/Element.js
+++ b/lib/OpenLayers/BaseTypes/Element.js
@@ -163,7 +163,7 @@ OpenLayers.Element = {
 
         var value = null;
         if (element && element.style) {
-            value = element.style[OpenLayers.String.camelize(style)];
+            value = element.style[style];
             if (!value) {
                 if (document.defaultView && 
                     document.defaultView.getComputedStyle) {
@@ -171,7 +171,7 @@ OpenLayers.Element = {
                     var css = document.defaultView.getComputedStyle(element, null);
                     value = css ? css.getPropertyValue(style) : null;
                 } else if (element.currentStyle) {
-                    value = element.currentStyle[OpenLayers.String.camelize(style)];
+                    value = element.currentStyle[style];
                 }
             }
         
diff --git a/lib/OpenLayers/Control/OverviewMap.js b/lib/OpenLayers/Control/OverviewMap.js
index c1b2ff7922..55f9b4998e 100644
--- a/lib/OpenLayers/Control/OverviewMap.js
+++ b/lib/OpenLayers/Control/OverviewMap.js
@@ -499,14 +499,14 @@ OpenLayers.Control.OverviewMap = OpenLayers.Class(OpenLayers.Control, {
         this.ovmap.zoomToMaxExtent();
         // check extent rectangle border width
         this.wComp = parseInt(OpenLayers.Element.getStyle(this.extentRectangle,
-                                               'border-left-width')) +
+                                               'borderLeftWidth')) +
                      parseInt(OpenLayers.Element.getStyle(this.extentRectangle,
-                                               'border-right-width'));
+                                               'borderRightWidth'));
         this.wComp = (this.wComp) ? this.wComp : 2;
         this.hComp = parseInt(OpenLayers.Element.getStyle(this.extentRectangle,
                                                'border-top-width')) +
                      parseInt(OpenLayers.Element.getStyle(this.extentRectangle,
-                                               'border-bottom-width'));
+                                               'borderBottomWidth'));
         this.hComp = (this.hComp) ? this.hComp : 2;
 
         this.handlers.drag = new OpenLayers.Handler.Drag(
diff --git a/lib/OpenLayers/Handler/Box.js b/lib/OpenLayers/Handler/Box.js
index ca89c5e9f5..bee97e433c 100644
--- a/lib/OpenLayers/Handler/Box.js
+++ b/lib/OpenLayers/Handler/Box.js
@@ -220,13 +220,13 @@ OpenLayers.Handler.Box = OpenLayers.Class(OpenLayers.Handler, {
             document.body.removeChild(testDiv);
             
             var left = parseInt(OpenLayers.Element.getStyle(this.zoomBox,
-                "border-left-width"));
+                "borderLeftWidth"));
             var right = parseInt(OpenLayers.Element.getStyle(
-                this.zoomBox, "border-right-width"));
+                this.zoomBox, "borderRightWidth"));
             var top = parseInt(OpenLayers.Element.getStyle(this.zoomBox,
-                "border-top-width"));
+                "borderTopWidth"));
             var bottom = parseInt(OpenLayers.Element.getStyle(
-                this.zoomBox, "border-bottom-width"));
+                this.zoomBox, "borderBottomWidth"));
             this.boxOffsets = {
                 left: left,
                 right: right,
diff --git a/lib/OpenLayers/Popup.js b/lib/OpenLayers/Popup.js
index a5c82b8f15..f2dc9e172d 100644
--- a/lib/OpenLayers/Popup.js
+++ b/lib/OpenLayers/Popup.js
@@ -844,10 +844,10 @@ OpenLayers.Popup = OpenLayers.Class({
 	            
             //read the padding settings from css, put them in an OL.Bounds        
             contentDivPadding = new OpenLayers.Bounds(
-                OpenLayers.Element.getStyle(this.contentDiv, "padding-left"),
-                OpenLayers.Element.getStyle(this.contentDiv, "padding-bottom"),
-                OpenLayers.Element.getStyle(this.contentDiv, "padding-right"),
-                OpenLayers.Element.getStyle(this.contentDiv, "padding-top")
+                OpenLayers.Element.getStyle(this.contentDiv, "paddingLeft"),
+                OpenLayers.Element.getStyle(this.contentDiv, "paddingBottom"),
+                OpenLayers.Element.getStyle(this.contentDiv, "paddingRight"),
+                OpenLayers.Element.getStyle(this.contentDiv, "paddingTop")
             );
     
             //cache the value
diff --git a/tests/BaseTypes.html b/tests/BaseTypes.html
index c264d4a54f..772cc7bdc9 100644
--- a/tests/BaseTypes.html
+++ b/tests/BaseTypes.html
@@ -59,34 +59,7 @@
         str = " ";
         t.eq(OpenLayers.String.trim(str), "", "whitespace string is trimmed correctly");
     }
-        
-    function test_String_camelize(t) {
-        t.plan(7);
-        
-        var str = "chickenhead";
-        t.eq(OpenLayers.String.camelize(str), "chickenhead", "string with no hyphens is left alone");
 
-        str = "chicken-head";
-        t.eq(OpenLayers.String.camelize(str), "chickenHead", "string with one middle hyphen is camelized correctly");
-
-        str = "chicken-head-man";
-        t.eq(OpenLayers.String.camelize(str), "chickenHeadMan", "string with multiple middle hyphens is camelized correctly");
-
-        str = "-chickenhead";
-        t.eq(OpenLayers.String.camelize(str), "Chickenhead", "string with starting hyphen is camelized correctly (capitalized)");
-
-        str = "-chicken-head-man";
-        t.eq(OpenLayers.String.camelize(str), "ChickenHeadMan", "string with starting hypen and multiple middle hyphens is camelized correctly");
-
-        str = "chicken-";
-        t.eq(OpenLayers.String.camelize(str), "chicken", "string ending in hyphen is camelized correctly (hyphen dropped)");
-
-        str = "chicken-head-man-";
-        t.eq(OpenLayers.String.camelize(str), "chickenHeadMan", "string with multiple middle hyphens and end hyphen is camelized correctly (end hyphen dropped)");
-
-
-    }
-    
     function test_String_format(t) {
         var unchanged = [
             "", "${ ", "${", " ${", "${${", "${}", "${${}}", " ${ ${",
diff --git a/tests/Handler/Box.html b/tests/Handler/Box.html
index edb20d053d..4b497b7b43 100644
--- a/tests/Handler/Box.html
+++ b/tests/Handler/Box.html
@@ -41,7 +41,7 @@
         // Chromium 10: left is 0
         var testdiv = OpenLayers.Util.createDiv('testdiv', new OpenLayers.Pixel(5, 5));
         map.div.appendChild(testdiv);
-        var left = parseInt(OpenLayers.Element.getStyle(testdiv, 'border-left-width'));
+        var left = parseInt(OpenLayers.Element.getStyle(testdiv, 'borderLeftWidth'));
         map.div.removeChild(testdiv);
         var testAll = !isNaN(left);
 

From 5875b50a510898093e3898f6bf43645b4815a8e9 Mon Sep 17 00:00:00 2001
From: Tom MacWright <tom@macwright.org>
Date: Mon, 21 Nov 2011 15:42:46 -0500
Subject: [PATCH 2/2] Moving camelize and its tests to deprecated

---
 lib/deprecated.js                      | 24 ++++++++++++++++
 tests/deprecated/BaseTypes.html        | 40 ++++++++++++++++++++++++++
 tests/deprecated/BaseTypes/String.html | 40 ++++++++++++++++++++++++++
 tests/list-tests.html                  |  1 +
 4 files changed, 105 insertions(+)
 create mode 100644 tests/deprecated/BaseTypes.html
 create mode 100644 tests/deprecated/BaseTypes/String.html

diff --git a/lib/deprecated.js b/lib/deprecated.js
index 23f0d976b8..ebe9725b30 100644
--- a/lib/deprecated.js
+++ b/lib/deprecated.js
@@ -85,6 +85,30 @@ OpenLayers.Util.clearArray = function(array) {
     array.length = 0;
 };
 
+
+/**
+ * APIFunction: camelize
+ * Camel-case a hyphenated string. 
+ *     Ex. "chicken-head" becomes "chickenHead", and
+ *     "-chicken-head" becomes "ChickenHead".
+ *
+ * Parameters:
+ * str - {String} The string to be camelized.  The original is not modified.
+ * 
+ * Returns:
+ * {String} The string, camelized
+ */
+
+OpenLayers.String.camelize = function(str) {
+    var oStringList = str.split('-');
+    var camelizedString = oStringList[0];
+    for (var i=1, len=oStringList.length; i<len; i++) {
+        var s = oStringList[i];
+        camelizedString += s.charAt(0).toUpperCase() + s.substring(1);
+    }
+    return camelizedString;
+};
+
 /**
  * Function: setOpacity
  * *Deprecated*.  This function has been deprecated. Instead, please use 
diff --git a/tests/deprecated/BaseTypes.html b/tests/deprecated/BaseTypes.html
new file mode 100644
index 0000000000..b8a66b8574
--- /dev/null
+++ b/tests/deprecated/BaseTypes.html
@@ -0,0 +1,40 @@
+<html>
+<head>
+    <script src="../../OLLoader.js"></script>
+    <script src="../../../lib/deprecated.js"></script>
+
+    <script type="text/javascript">
+
+     function test_String_camelize(t) {
+        t.plan(7);
+        
+        var str = "chickenhead";
+        t.eq(OpenLayers.String.camelize(str), "chickenhead", "string with no hyphens is left alone");
+
+        str = "chicken-head";
+        t.eq(OpenLayers.String.camelize(str), "chickenHead", "string with one middle hyphen is camelized correctly");
+
+        str = "chicken-head-man";
+        t.eq(OpenLayers.String.camelize(str), "chickenHeadMan", "string with multiple middle hyphens is camelized correctly");
+
+        str = "-chickenhead";
+        t.eq(OpenLayers.String.camelize(str), "Chickenhead", "string with starting hyphen is camelized correctly (capitalized)");
+
+        str = "-chicken-head-man";
+        t.eq(OpenLayers.String.camelize(str), "ChickenHeadMan", "string with starting hypen and multiple middle hyphens is camelized correctly");
+
+        str = "chicken-";
+        t.eq(OpenLayers.String.camelize(str), "chicken", "string ending in hyphen is camelized correctly (hyphen dropped)");
+
+        str = "chicken-head-man-";
+        t.eq(OpenLayers.String.camelize(str), "chickenHeadMan", "string with multiple middle hyphens and end hyphen is camelized correctly (end hyphen dropped)");
+
+
+    }
+
+    </script>
+</head>
+<body>
+</body>
+</html>
+        
diff --git a/tests/deprecated/BaseTypes/String.html b/tests/deprecated/BaseTypes/String.html
new file mode 100644
index 0000000000..b8a66b8574
--- /dev/null
+++ b/tests/deprecated/BaseTypes/String.html
@@ -0,0 +1,40 @@
+<html>
+<head>
+    <script src="../../OLLoader.js"></script>
+    <script src="../../../lib/deprecated.js"></script>
+
+    <script type="text/javascript">
+
+     function test_String_camelize(t) {
+        t.plan(7);
+        
+        var str = "chickenhead";
+        t.eq(OpenLayers.String.camelize(str), "chickenhead", "string with no hyphens is left alone");
+
+        str = "chicken-head";
+        t.eq(OpenLayers.String.camelize(str), "chickenHead", "string with one middle hyphen is camelized correctly");
+
+        str = "chicken-head-man";
+        t.eq(OpenLayers.String.camelize(str), "chickenHeadMan", "string with multiple middle hyphens is camelized correctly");
+
+        str = "-chickenhead";
+        t.eq(OpenLayers.String.camelize(str), "Chickenhead", "string with starting hyphen is camelized correctly (capitalized)");
+
+        str = "-chicken-head-man";
+        t.eq(OpenLayers.String.camelize(str), "ChickenHeadMan", "string with starting hypen and multiple middle hyphens is camelized correctly");
+
+        str = "chicken-";
+        t.eq(OpenLayers.String.camelize(str), "chicken", "string ending in hyphen is camelized correctly (hyphen dropped)");
+
+        str = "chicken-head-man-";
+        t.eq(OpenLayers.String.camelize(str), "chickenHeadMan", "string with multiple middle hyphens and end hyphen is camelized correctly (end hyphen dropped)");
+
+
+    }
+
+    </script>
+</head>
+<body>
+</body>
+</html>
+        
diff --git a/tests/list-tests.html b/tests/list-tests.html
index adc9580f73..af7b6b29d6 100644
--- a/tests/list-tests.html
+++ b/tests/list-tests.html
@@ -226,6 +226,7 @@
     <li>deprecated/Ajax.html</li>
     <li>deprecated/BaseTypes/Class.html</li>
     <li>deprecated/BaseTypes/Element.html</li>
+    <li>deprecated/BaseTypes/String.html</li>
     <li>deprecated/Control/MouseToolbar.html</li>
     <li>deprecated/Layer/MapServer/Untiled.html</li>
     <li>deprecated/Layer/MultiMap.html</li>