ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

r2039 contained a small stylistic change that I thought was insignificant but upon further reflection is not. the '||' style is beautiful, but it breaks if a 0, '', or 'false' value is specified (as they all evaluate to false, and thus the default is taken). So if the user wants to specify a 0-width border, s/he cannot. This commit reverts to how it previously was, with the addition of {} as per OL coding standards. Also the addition of one small line break, also for coding standards

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2040 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
euzuro
2006-12-13 13:22:47 +00:00
parent d5a7f1ef5c
commit c014e5ea72
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/OpenLayers/Marker/Box.js
+8 -3
View File
@@ -9,7 +9,8 @@
* @requires OpenLayers/Marker.js * @requires OpenLayers/Marker.js
*/ */
OpenLayers.Marker.Box = OpenLayers.Class.create(); OpenLayers.Marker.Box = OpenLayers.Class.create();
OpenLayers.Marker.Box.prototype = OpenLayers.Class.inherit( OpenLayers.Marker, { OpenLayers.Marker.Box.prototype =
OpenLayers.Class.inherit( OpenLayers.Marker, {
/** @type OpenLayers.Bounds */ /** @type OpenLayers.Bounds */
bounds: null, bounds: null,
@@ -38,8 +39,12 @@ OpenLayers.Marker.Box.prototype = OpenLayers.Class.inherit( OpenLayers.Marker, {
* @param {int} width Default is 2 * @param {int} width Default is 2
*/ */
setBorder: function (color, width) { setBorder: function (color, width) {
color = color || "red"; if (!color) {
width = width || 2; color = "red";
}
if (!width) {
width = 2;
}
this.div.style.border = width + "px solid " + color; this.div.style.border = width + "px solid " + color;
}, },